[v3] virtio-gpu cleanups and obvious definitions

[PATCH v3 0/5] virtio-gpu cleanups and obvious definitions

Posted by Gurchetan Singh 11 months, 4 weeks ago

From: Gurchetan Singh <gurchetansingh@google.com>

v3 of "virtio-gpu cleanups and obvious definitions"

https://lists.gnu.org/archive/html/qemu-devel/2023-04/msg05392.html

All patches have been reviewed, though there was a question from
Bernhard Beschow about patch (3) and how it fits with the QOM:

https://lists.gnu.org/archive/html/qemu-devel/2023-05/msg00057.html

I go into detail in patch 3 commit message, but I think we meet
the requirements (which are tricky/fuzzy anyways).  Also, I think
this is the cleanest way to add another 3D virtgpu backend.  But
if anyone has other ideas, please do reply/review.

Antonio Caggiano (1):
  virtio-gpu: CONTEXT_INIT feature

Dr. David Alan Gilbert (1):
  virtio: Add shared memory capability

Gurchetan Singh (3):
  hw/display/virtio-gpu-virgl: virtio_gpu_gl -> virtio_gpu_virgl
  hw/display/virtio-gpu-virgl: make GL device more library agnostic
  hw/display/virtio-gpu-virgl: define callbacks in realize function

 hw/display/virtio-gpu-base.c   |   3 +
 hw/display/virtio-gpu-gl.c     | 114 +--------------------------
 hw/display/virtio-gpu-virgl.c  | 137 +++++++++++++++++++++++++++++++--
 hw/virtio/virtio-pci.c         |  18 +++++
 include/hw/virtio/virtio-gpu.h |  11 +--
 include/hw/virtio/virtio-pci.h |   4 +
 6 files changed, 160 insertions(+), 127 deletions(-)

-- 
2.40.1.521.gf1e218fcd8-goog

Re: [PATCH v3 0/5] virtio-gpu cleanups and obvious definitions

Posted by Marc-André Lureau 11 months, 3 weeks ago

Hi

On Thu, May 4, 2023 at 11:13 PM Gurchetan Singh <gurchetansingh@chromium.org>
wrote:

> From: Gurchetan Singh <gurchetansingh@google.com>
>
> v3 of "virtio-gpu cleanups and obvious definitions"
>
> https://lists.gnu.org/archive/html/qemu-devel/2023-04/msg05392.html
>
> All patches have been reviewed, though there was a question from
> Bernhard Beschow about patch (3) and how it fits with the QOM:
>
> https://lists.gnu.org/archive/html/qemu-devel/2023-05/msg00057.html
>
> I go into detail in patch 3 commit message, but I think we meet
> the requirements (which are tricky/fuzzy anyways).  Also, I think
> this is the cleanest way to add another 3D virtgpu backend.  But
> if anyone has other ideas, please do reply/review.
>
> Antonio Caggiano (1):
>   virtio-gpu: CONTEXT_INIT feature
>
> Dr. David Alan Gilbert (1):
>   virtio: Add shared memory capability
>
> Gurchetan Singh (3):
>   hw/display/virtio-gpu-virgl: virtio_gpu_gl -> virtio_gpu_virgl
>   hw/display/virtio-gpu-virgl: make GL device more library agnostic
>   hw/display/virtio-gpu-virgl: define callbacks in realize function
>
>  hw/display/virtio-gpu-base.c   |   3 +
>  hw/display/virtio-gpu-gl.c     | 114 +--------------------------
>  hw/display/virtio-gpu-virgl.c  | 137 +++++++++++++++++++++++++++++++--
>  hw/virtio/virtio-pci.c         |  18 +++++
>  include/hw/virtio/virtio-gpu.h |  11 +--
>  include/hw/virtio/virtio-pci.h |   4 +
>  6 files changed, 160 insertions(+), 127 deletions(-)
>
> --
> 2.40.1.521.gf1e218fcd8-goog
>
>
>
This looks fine to me:
Reviewed-by: Marc-André Lureau <marcandre.lureau@redhat.com>

however, do you have a series rebased on top that makes use of those
changes? (I think we may want to delay merging this one until it's actually
needed)


-- 
Marc-André Lureau

Re: [PATCH v3 0/5] virtio-gpu cleanups and obvious definitions

Posted by Gurchetan Singh 11 months, 3 weeks ago

On Tue, May 9, 2023 at 5:43 AM Marc-André Lureau <marcandre.lureau@gmail.com>
wrote:

> Hi
>
> On Thu, May 4, 2023 at 11:13 PM Gurchetan Singh <
> gurchetansingh@chromium.org> wrote:
>
>> From: Gurchetan Singh <gurchetansingh@google.com>
>>
>> v3 of "virtio-gpu cleanups and obvious definitions"
>>
>> https://lists.gnu.org/archive/html/qemu-devel/2023-04/msg05392.html
>>
>> All patches have been reviewed, though there was a question from
>> Bernhard Beschow about patch (3) and how it fits with the QOM:
>>
>> https://lists.gnu.org/archive/html/qemu-devel/2023-05/msg00057.html
>>
>> I go into detail in patch 3 commit message, but I think we meet
>> the requirements (which are tricky/fuzzy anyways).  Also, I think
>> this is the cleanest way to add another 3D virtgpu backend.  But
>> if anyone has other ideas, please do reply/review.
>>
>> Antonio Caggiano (1):
>>   virtio-gpu: CONTEXT_INIT feature
>>
>> Dr. David Alan Gilbert (1):
>>   virtio: Add shared memory capability
>>
>> Gurchetan Singh (3):
>>   hw/display/virtio-gpu-virgl: virtio_gpu_gl -> virtio_gpu_virgl
>>   hw/display/virtio-gpu-virgl: make GL device more library agnostic
>>   hw/display/virtio-gpu-virgl: define callbacks in realize function
>>
>>  hw/display/virtio-gpu-base.c   |   3 +
>>  hw/display/virtio-gpu-gl.c     | 114 +--------------------------
>>  hw/display/virtio-gpu-virgl.c  | 137 +++++++++++++++++++++++++++++++--
>>  hw/virtio/virtio-pci.c         |  18 +++++
>>  include/hw/virtio/virtio-gpu.h |  11 +--
>>  include/hw/virtio/virtio-pci.h |   4 +
>>  6 files changed, 160 insertions(+), 127 deletions(-)
>>
>> --
>> 2.40.1.521.gf1e218fcd8-goog
>>
>>
>>
> This looks fine to me:
> Reviewed-by: Marc-André Lureau <marcandre.lureau@redhat.com>
>
> however, do you have a series rebased on top that makes use of those
> changes? (I think we may want to delay merging this one until it's actually
> needed)
>

Got it.  Bernhard actually recommended a separate virtio-gpu-rutabaga
device instead of virtio-gpu-gl.  I went with that approach:

https://lists.gnu.org/archive/html/qemu-devel/2023-05/msg01571.html
https://gitlab.freedesktop.org/gurchetansingh/qemu-gfxstream/-/commits/qemu-gfxstream-3

I'll send out a new full-featured series once testing/hack cleanups are
complete -- so no further action is needed on your part.


>
>
> --
> Marc-André Lureau
>

Re: [PATCH v3 0/5] virtio-gpu cleanups and obvious definitions

Posted by Akihiko Odaki 11 months, 4 weeks ago

On 2023/05/05 4:12, Gurchetan Singh wrote:
> From: Gurchetan Singh <gurchetansingh@google.com>
> 
> v3 of "virtio-gpu cleanups and obvious definitions"
> 
> https://lists.gnu.org/archive/html/qemu-devel/2023-04/msg05392.html
> 
> All patches have been reviewed, though there was a question from
> Bernhard Beschow about patch (3) and how it fits with the QOM:
> 
> https://lists.gnu.org/archive/html/qemu-devel/2023-05/msg00057.html
> 
> I go into detail in patch 3 commit message, but I think we meet
> the requirements (which are tricky/fuzzy anyways).  Also, I think
> this is the cleanest way to add another 3D virtgpu backend.  But
> if anyone has other ideas, please do reply/review.
> 
> Antonio Caggiano (1):
>    virtio-gpu: CONTEXT_INIT feature
> 
> Dr. David Alan Gilbert (1):
>    virtio: Add shared memory capability
> 
> Gurchetan Singh (3):
>    hw/display/virtio-gpu-virgl: virtio_gpu_gl -> virtio_gpu_virgl
>    hw/display/virtio-gpu-virgl: make GL device more library agnostic
>    hw/display/virtio-gpu-virgl: define callbacks in realize function
> 
>   hw/display/virtio-gpu-base.c   |   3 +
>   hw/display/virtio-gpu-gl.c     | 114 +--------------------------
>   hw/display/virtio-gpu-virgl.c  | 137 +++++++++++++++++++++++++++++++--
>   hw/virtio/virtio-pci.c         |  18 +++++
>   include/hw/virtio/virtio-gpu.h |  11 +--
>   include/hw/virtio/virtio-pci.h |   4 +
>   6 files changed, 160 insertions(+), 127 deletions(-)
> 

For all patches:

Reviewed-by: Akihiko Odaki <akihiko.odaki@daynix.com>