This could only happen if the source send
RAM_SAVE_FLAG_HOOK (i.e. rdma) and destination don't have CONFIG_RDMA.

Signed-off-by: Juan Quintela <quintela@redhat.com>
---
 migration/qemu-file.c | 8 --------
 1 file changed, 8 deletions(-)

diff --git a/migration/qemu-file.c b/migration/qemu-file.c
index 112ba742fd..5783c9f385 100644
--- a/migration/qemu-file.c
+++ b/migration/qemu-file.c
@@ -343,14 +343,6 @@ void ram_control_load_hook(QEMUFile *f, uint64_t flags, void *data)
         if (ret < 0) {
             qemu_file_set_error(f, ret);
         }
-    } else {
-        /*
-         * Hook is a hook specifically requested by the source sending a flag
-         * that expects there to be a hook on the destination.
-         */
-        if (flags == RAM_CONTROL_HOOK) {
-            qemu_file_set_error(f, -EINVAL);
-        }
     }
 }
 
-- 
2.40.0

On Thu, May 04, 2023 at 01:44:42PM +0200, Juan Quintela wrote:
> This could only happen if the source send
> RAM_SAVE_FLAG_HOOK (i.e. rdma) and destination don't have CONFIG_RDMA.
> 
> Signed-off-by: Juan Quintela <quintela@redhat.com>

Bah, first patch to start reading the master code and it's already merged.
I'll stop here then... :)

-- 
Peter Xu

In $SUBJECT   s/recive/receive/

On Thu, May 04, 2023 at 01:44:42PM +0200, Juan Quintela wrote:
> This could only happen if the source send

s/send/sent/

> RAM_SAVE_FLAG_HOOK (i.e. rdma) and destination don't have CONFIG_RDMA.
> 
> Signed-off-by: Juan Quintela <quintela@redhat.com>
> ---
>  migration/qemu-file.c | 8 --------
>  1 file changed, 8 deletions(-)

Reviewed-by: Daniel P. Berrangé <berrange@redhat.com>

With regards,
Daniel
-- 
|: https://berrange.com      -o-    https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org         -o-            https://fstop138.berrange.com :|
|: https://entangle-photo.org    -o-    https://www.instagram.com/dberrange :|

Daniel P. Berrangé <berrange@redhat.com> wrote:
> In $SUBJECT   s/recive/receive/
>
> On Thu, May 04, 2023 at 01:44:42PM +0200, Juan Quintela wrote:
>> This could only happen if the source send
>
> s/send/sent/

Fixed.

>> RAM_SAVE_FLAG_HOOK (i.e. rdma) and destination don't have CONFIG_RDMA.
>> 
>> Signed-off-by: Juan Quintela <quintela@redhat.com>
>> ---
>>  migration/qemu-file.c | 8 --------
>>  1 file changed, 8 deletions(-)
>
> Reviewed-by: Daniel P. Berrangé <berrange@redhat.com>

Thanks.