testing/next: cirrus, docker, docs, ci, configs, gitlab

[PATCH 17/22] hw/xtensa: add VIRTIO as dependencies for XTENSA_VIRT

Posted by Alex Bennée 2 years, 7 months ago

These are needed for board creation so fail under "make check" with a
--without-default-devices build.

Signed-off-by: Alex Bennée <alex.bennee@linaro.org>
---
 hw/xtensa/Kconfig | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/hw/xtensa/Kconfig b/hw/xtensa/Kconfig
index 0740657ea5..a54a9d395e 100644
--- a/hw/xtensa/Kconfig
+++ b/hw/xtensa/Kconfig
@@ -6,6 +6,8 @@ config XTENSA_VIRT
     select XTENSA_SIM
     select PCI_EXPRESS_GENERIC_BRIDGE
     select PCI_DEVICES
+    select VIRTIO_PCI
+    select VIRTIO_NET
 
 config XTENSA_XTFPGA
     bool
-- 
2.39.2

Re: [PATCH 17/22] hw/xtensa: add VIRTIO as dependencies for XTENSA_VIRT

Posted by Paolo Bonzini 2 years, 7 months ago

On 5/3/23 11:12, Alex Bennée wrote:
> These are needed for board creation so fail under "make check" with a
> --without-default-devices build.
> 
> Signed-off-by: Alex Bennée<alex.bennee@linaro.org>
> ---
>   hw/xtensa/Kconfig | 2 ++
>   1 file changed, 2 insertions(+)
> 
> diff --git a/hw/xtensa/Kconfig b/hw/xtensa/Kconfig
> index 0740657ea5..a54a9d395e 100644
> --- a/hw/xtensa/Kconfig
> +++ b/hw/xtensa/Kconfig
> @@ -6,6 +6,8 @@ config XTENSA_VIRT
>       select XTENSA_SIM
>       select PCI_EXPRESS_GENERIC_BRIDGE
>       select PCI_DEVICES
> +    select VIRTIO_PCI
> +    select VIRTIO_NET

Not needed.

Paolo

Re: [PATCH 17/22] hw/xtensa: add VIRTIO as dependencies for XTENSA_VIRT

Posted by Max Filippov 2 years, 7 months ago

On Wed, May 3, 2023 at 2:12 AM Alex Bennée <alex.bennee@linaro.org> wrote:
>
> These are needed for board creation so fail under "make check" with a
> --without-default-devices build.
>
> Signed-off-by: Alex Bennée <alex.bennee@linaro.org>
> ---
>  hw/xtensa/Kconfig | 2 ++
>  1 file changed, 2 insertions(+)

Reviewed-by: Max Filippov <jcmvbkbc@gmail.com>

-- 
Thanks.
-- Max

Re: [PATCH 17/22] hw/xtensa: add VIRTIO as dependencies for XTENSA_VIRT

Posted by Richard Henderson 2 years, 7 months ago

On 5/3/23 10:12, Alex Bennée wrote:
> These are needed for board creation so fail under "make check" with a
> --without-default-devices build.
> 
> Signed-off-by: Alex Bennée <alex.bennee@linaro.org>
> ---
>   hw/xtensa/Kconfig | 2 ++
>   1 file changed, 2 insertions(+)
> 
> diff --git a/hw/xtensa/Kconfig b/hw/xtensa/Kconfig
> index 0740657ea5..a54a9d395e 100644
> --- a/hw/xtensa/Kconfig
> +++ b/hw/xtensa/Kconfig
> @@ -6,6 +6,8 @@ config XTENSA_VIRT
>       select XTENSA_SIM
>       select PCI_EXPRESS_GENERIC_BRIDGE
>       select PCI_DEVICES
> +    select VIRTIO_PCI
> +    select VIRTIO_NET
>   
>   config XTENSA_XTFPGA
>       bool

Reviewed-by: Richard Henderson <richard.henderson@linaro.org>

r~