testing/next: cirrus, docker, docs, ci, configs, gitlab

[PATCH 12/22] hw/hppa: add TULIP as a dependency for HPPA_B160L

Alex Bennée posted 22 patches 2 years, 7 months ago

Download mbox

Maintainers: "Alex Bennée" <alex.bennee@linaro.org>, "Philippe Mathieu-Daudé" <philmd@linaro.org>, Thomas Huth <thuth@redhat.com>, Wainer dos Santos Moschetta <wainersm@redhat.com>, Beraldo Leal <bleal@redhat.com>, Richard Henderson <richard.henderson@linaro.org>, Peter Maydell <peter.maydell@linaro.org>, Helge Deller <deller@gmx.de>, Xiaojuan Yang <yangxiaojuan@loongson.cn>, Song Gao <gaosong@loongson.cn>, Yoshinori Sato <ysato@users.sourceforge.jp>, Mark Cave-Ayland <mark.cave-ayland@ilande.co.uk>, Artyom Tarasenko <atar4qemu@gmail.com>, Gerd Hoffmann <kraxel@redhat.com>, Max Filippov <jcmvbkbc@gmail.com>, Pavel Dovgalyuk <pavel.dovgaluk@ispras.ru>, Paolo Bonzini <pbonzini@redhat.com>, Cleber Rosa <crosa@redhat.com>, Laurent Vivier <lvivier@redhat.com>

Expand all Fold all

[PATCH 12/22] hw/hppa: add TULIP as a dependency for HPPA_B160L

Posted by Alex Bennée 2 years, 7 months ago

These are needed for board creation so fail under "make check" with a
--without-default-devices build.

Signed-off-by: Alex Bennée <alex.bennee@linaro.org>
---
 hw/hppa/Kconfig | 1 +
 1 file changed, 1 insertion(+)

diff --git a/hw/hppa/Kconfig b/hw/hppa/Kconfig
index 5dd8b5b21e..f405663839 100644
--- a/hw/hppa/Kconfig
+++ b/hw/hppa/Kconfig
@@ -15,3 +15,4 @@ config HPPA_B160L
     select LASIPS2
     select PARALLEL
     select ARTIST
+    select TULIP
-- 
2.39.2

Re: [PATCH 12/22] hw/hppa: add TULIP as a dependency for HPPA_B160L

Posted by Paolo Bonzini 2 years, 7 months ago

On 5/3/23 11:12, Alex Bennée wrote:
> These are needed for board creation so fail under "make check" with a
> --without-default-devices build.
> 
> Signed-off-by: Alex Bennée <alex.bennee@linaro.org>

Not needed.  Selecting "LSI_SCSI_PCI" however is correct:

bus: main-system-bus
   type System
   dev: ps2-mouse, id ""
   dev: ps2-kbd, id ""
   dev: lasips2, id ""
   dev: fw_cfg_mem, id ""
   dev: serial-mm, id ""
   dev: isabus-bridge, id ""
   dev: dino-pcihost, id ""
     bus: pci
       type PCI
       dev: lsi53c895a, id ""
   dev: lasi-chip, id ""


Paolo

Re: [PATCH 12/22] hw/hppa: add TULIP as a dependency for HPPA_B160L

Posted by Richard Henderson 2 years, 7 months ago

On 5/3/23 10:12, Alex Bennée wrote:
> These are needed for board creation so fail under "make check" with a
> --without-default-devices build.
> 
> Signed-off-by: Alex Bennée <alex.bennee@linaro.org>
> ---
>   hw/hppa/Kconfig | 1 +
>   1 file changed, 1 insertion(+)
> 
> diff --git a/hw/hppa/Kconfig b/hw/hppa/Kconfig
> index 5dd8b5b21e..f405663839 100644
> --- a/hw/hppa/Kconfig
> +++ b/hw/hppa/Kconfig
> @@ -15,3 +15,4 @@ config HPPA_B160L
>       select LASIPS2
>       select PARALLEL
>       select ARTIST
> +    select TULIP

Reviewed-by: Richard Henderson <richard.henderson@linaro.org>

r~