target/hexagon/idef-parser/parser-helpers.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
Coverity reports a parameter that is "set but never used". This is caused
by an assignment operator being used instead of equality.
Cc: Taylor Simpson <tsimpson@quicinc.com>
Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
---
target/hexagon/idef-parser/parser-helpers.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/target/hexagon/idef-parser/parser-helpers.c b/target/hexagon/idef-parser/parser-helpers.c
index 86511efb62b9..0a01ec39b75e 100644
--- a/target/hexagon/idef-parser/parser-helpers.c
+++ b/target/hexagon/idef-parser/parser-helpers.c
@@ -1123,7 +1123,7 @@ HexValue gen_extend_op(Context *c,
HexValue *value,
HexSignedness signedness)
{
- unsigned bit_width = (dst_width = 64) ? 64 : 32;
+ unsigned bit_width = (dst_width == 64) ? 64 : 32;
HexValue value_m = *value;
HexValue src_width_m = *src_width;
--
2.40.0
On 4/27/23 14:56, Paolo Bonzini wrote: > Coverity reports a parameter that is "set but never used". This is caused > by an assignment operator being used instead of equality. > > Cc: Taylor Simpson <tsimpson@quicinc.com> > Signed-off-by: Paolo Bonzini <pbonzini@redhat.com> > --- > target/hexagon/idef-parser/parser-helpers.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/target/hexagon/idef-parser/parser-helpers.c b/target/hexagon/idef-parser/parser-helpers.c > index 86511efb62b9..0a01ec39b75e 100644 > --- a/target/hexagon/idef-parser/parser-helpers.c > +++ b/target/hexagon/idef-parser/parser-helpers.c > @@ -1123,7 +1123,7 @@ HexValue gen_extend_op(Context *c, > HexValue *value, > HexSignedness signedness) > { > - unsigned bit_width = (dst_width = 64) ? 64 : 32; > + unsigned bit_width = (dst_width == 64) ? 64 : 32; > HexValue value_m = *value; > HexValue src_width_m = *src_width; > Reviewed-by: Anton Johansson <anjo@rev.ng>
> -----Original Message----- > From: Paolo Bonzini <pbonzini@redhat.com> > Sent: Thursday, April 27, 2023 7:57 AM > To: qemu-devel@nongnu.org > Cc: Taylor Simpson <tsimpson@quicinc.com> > Subject: [PATCH] target/hexagon: fix = vs. == mishap > > WARNING: This email originated from outside of Qualcomm. Please be wary > of any links or attachments, and do not enable macros. > > Coverity reports a parameter that is "set but never used". This is caused by > an assignment operator being used instead of equality. > > Cc: Taylor Simpson <tsimpson@quicinc.com> > Signed-off-by: Paolo Bonzini <pbonzini@redhat.com> > --- > target/hexagon/idef-parser/parser-helpers.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/target/hexagon/idef-parser/parser-helpers.c > b/target/hexagon/idef-parser/parser-helpers.c > index 86511efb62b9..0a01ec39b75e 100644 > --- a/target/hexagon/idef-parser/parser-helpers.c > +++ b/target/hexagon/idef-parser/parser-helpers.c > @@ -1123,7 +1123,7 @@ HexValue gen_extend_op(Context *c, > HexValue *value, > HexSignedness signedness) { > - unsigned bit_width = (dst_width = 64) ? 64 : 32; > + unsigned bit_width = (dst_width == 64) ? 64 : 32; > HexValue value_m = *value; > HexValue src_width_m = *src_width; Cc: Alessandro Di Federico <ale@rev.ng> Cc: Anton Johansson <anjo@rev.ng> Reviewed-by: Taylor Simpson <tsimpson@quicinc.com>
On 4/27/23 13:56, Paolo Bonzini wrote: > Coverity reports a parameter that is "set but never used". This is caused > by an assignment operator being used instead of equality. > > Cc: Taylor Simpson<tsimpson@quicinc.com> > Signed-off-by: Paolo Bonzini<pbonzini@redhat.com> > --- > target/hexagon/idef-parser/parser-helpers.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) Reviewed-by: Richard Henderson <richard.henderson@linaro.org> r~
> -----Original Message----- > From: Richard Henderson <richard.henderson@linaro.org> > Sent: Thursday, April 27, 2023 8:33 AM > To: Paolo Bonzini <pbonzini@redhat.com>; qemu-devel@nongnu.org > Cc: Taylor Simpson <tsimpson@quicinc.com> > Subject: Re: [PATCH] target/hexagon: fix = vs. == mishap > > WARNING: This email originated from outside of Qualcomm. Please be wary > of any links or attachments, and do not enable macros. > > On 4/27/23 13:56, Paolo Bonzini wrote: > > Coverity reports a parameter that is "set but never used". This is > > caused by an assignment operator being used instead of equality. > > > > Cc: Taylor Simpson<tsimpson@quicinc.com> > > Signed-off-by: Paolo Bonzini<pbonzini@redhat.com> > > --- > > target/hexagon/idef-parser/parser-helpers.c | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > Reviewed-by: Richard Henderson <richard.henderson@linaro.org> Queued with next Hexagon update Thanks, Taylor
> -----Original Message----- > From: Taylor Simpson > Sent: Thursday, April 27, 2023 6:05 PM > To: Richard Henderson <richard.henderson@linaro.org>; Paolo Bonzini > <pbonzini@redhat.com>; qemu-devel@nongnu.org > Subject: RE: [PATCH] target/hexagon: fix = vs. == mishap > > > > > -----Original Message----- > > From: Richard Henderson <richard.henderson@linaro.org> > > Sent: Thursday, April 27, 2023 8:33 AM > > To: Paolo Bonzini <pbonzini@redhat.com>; qemu-devel@nongnu.org > > Cc: Taylor Simpson <tsimpson@quicinc.com> > > Subject: Re: [PATCH] target/hexagon: fix = vs. == mishap > > > > WARNING: This email originated from outside of Qualcomm. Please be > wary > > of any links or attachments, and do not enable macros. > > > > On 4/27/23 13:56, Paolo Bonzini wrote: > > > Coverity reports a parameter that is "set but never used". This is > > > caused by an assignment operator being used instead of equality. > > > > > > Cc: Taylor Simpson<tsimpson@quicinc.com> > > > Signed-off-by: Paolo Bonzini<pbonzini@redhat.com> > > > --- > > > target/hexagon/idef-parser/parser-helpers.c | 2 +- > > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > Reviewed-by: Richard Henderson <richard.henderson@linaro.org> > > Queued with next Hexagon update This patch is causing some yyassert's when idef-parser runs. They are coming from sign and zero extends. WARNING (A2_vavgw): 'Extending to a size smaller than the current size makes no sense' I will investigate. Taylor
© 2016 - 2024 Red Hat, Inc.