[PATCH v2 29/41] tests/qtest/libqos/igb: Set GPIE.Multiple_MSIX

Akihiko Odaki posted 41 patches 2 years, 9 months ago
There is a newer version of this series
[PATCH v2 29/41] tests/qtest/libqos/igb: Set GPIE.Multiple_MSIX
Posted by Akihiko Odaki 2 years, 9 months ago
GPIE.Multiple_MSIX is not set by default, and needs to be set to get
interrupts from multiple MSI-X vectors.

Signed-off-by: Akihiko Odaki <akihiko.odaki@daynix.com>
---
 tests/qtest/libqos/igb.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/tests/qtest/libqos/igb.c b/tests/qtest/libqos/igb.c
index 12fb531bf0..a603468beb 100644
--- a/tests/qtest/libqos/igb.c
+++ b/tests/qtest/libqos/igb.c
@@ -114,6 +114,7 @@ static void igb_pci_start_hw(QOSGraphObject *obj)
     e1000e_macreg_write(&d->e1000e, E1000_RCTL, E1000_RCTL_EN);
 
     /* Enable all interrupts */
+    e1000e_macreg_write(&d->e1000e, E1000_GPIE,  E1000_GPIE_MSIX_MODE);
     e1000e_macreg_write(&d->e1000e, E1000_IMS,  0xFFFFFFFF);
     e1000e_macreg_write(&d->e1000e, E1000_EIMS, 0xFFFFFFFF);
 
-- 
2.40.0
RE: [PATCH v2 29/41] tests/qtest/libqos/igb: Set GPIE.Multiple_MSIX
Posted by Sriram Yagnaraman 2 years, 9 months ago

> -----Original Message-----
> From: Akihiko Odaki <akihiko.odaki@daynix.com>
> Sent: Thursday, 20 April 2023 07:47
> Cc: Sriram Yagnaraman <sriram.yagnaraman@est.tech>; Jason Wang
> <jasowang@redhat.com>; Dmitry Fleytman <dmitry.fleytman@gmail.com>;
> Michael S . Tsirkin <mst@redhat.com>; Alex Bennée
> <alex.bennee@linaro.org>; Philippe Mathieu-Daudé <philmd@linaro.org>;
> Thomas Huth <thuth@redhat.com>; Wainer dos Santos Moschetta
> <wainersm@redhat.com>; Beraldo Leal <bleal@redhat.com>; Cleber Rosa
> <crosa@redhat.com>; Laurent Vivier <lvivier@redhat.com>; Paolo Bonzini
> <pbonzini@redhat.com>; qemu-devel@nongnu.org; Tomasz Dzieciol
> <t.dzieciol@partner.samsung.com>; Akihiko Odaki
> <akihiko.odaki@daynix.com>
> Subject: [PATCH v2 29/41] tests/qtest/libqos/igb: Set GPIE.Multiple_MSIX
> 
> GPIE.Multiple_MSIX is not set by default, and needs to be set to get interrupts
> from multiple MSI-X vectors.
> 
> Signed-off-by: Akihiko Odaki <akihiko.odaki@daynix.com>
> ---
>  tests/qtest/libqos/igb.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/tests/qtest/libqos/igb.c b/tests/qtest/libqos/igb.c index
> 12fb531bf0..a603468beb 100644
> --- a/tests/qtest/libqos/igb.c
> +++ b/tests/qtest/libqos/igb.c
> @@ -114,6 +114,7 @@ static void igb_pci_start_hw(QOSGraphObject *obj)
>      e1000e_macreg_write(&d->e1000e, E1000_RCTL, E1000_RCTL_EN);
> 
>      /* Enable all interrupts */
> +    e1000e_macreg_write(&d->e1000e, E1000_GPIE,
> E1000_GPIE_MSIX_MODE);
>      e1000e_macreg_write(&d->e1000e, E1000_IMS,  0xFFFFFFFF);
>      e1000e_macreg_write(&d->e1000e, E1000_EIMS, 0xFFFFFFFF);
> 
> --
> 2.40.0

Reviewed-by: Sriram Yagnaraman <sriram.yagnaraman@est.tech>