Re-enable qom-cast-debug by default

[PATCH 2/2] meson_options.txt: Enable qom-cast-debug by default again

Posted by Thomas Huth 2 years, 9 months ago

This switch had been disabled by default by accident in commit
c55cf6ab03f. But we should enable it by default instead to avoid
regressions in the QOM device hierarchy.

Fixes: c55cf6ab03 ("configure, meson: move some default-disabled options to meson_options.txt")
Signed-off-by: Thomas Huth <thuth@redhat.com>
---
 meson_options.txt             | 2 +-
 scripts/meson-buildoptions.sh | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/meson_options.txt b/meson_options.txt
index fc9447d267..2471dd02da 100644
--- a/meson_options.txt
+++ b/meson_options.txt
@@ -315,7 +315,7 @@ option('debug_mutex', type: 'boolean', value: false,
        description: 'mutex debugging support')
 option('debug_stack_usage', type: 'boolean', value: false,
        description: 'measure coroutine stack usage')
-option('qom_cast_debug', type: 'boolean', value: false,
+option('qom_cast_debug', type: 'boolean', value: true,
        description: 'cast debugging support')
 option('gprof', type: 'boolean', value: false,
        description: 'QEMU profiling with gprof',
diff --git a/scripts/meson-buildoptions.sh b/scripts/meson-buildoptions.sh
index 009fab1515..d4369a3ad8 100644
--- a/scripts/meson-buildoptions.sh
+++ b/scripts/meson-buildoptions.sh
@@ -14,6 +14,7 @@ meson_options_help() {
   printf "%s\n" '                           use idef-parser to automatically generate TCG'
   printf "%s\n" '                           code for the Hexagon frontend'
   printf "%s\n" '  --disable-install-blobs  install provided firmware blobs'
+  printf "%s\n" '  --disable-qom-cast-debug cast debugging support'
   printf "%s\n" '  --docdir=VALUE           Base directory for documentation installation'
   printf "%s\n" '                           (can be empty) [share/doc]'
   printf "%s\n" '  --enable-block-drv-whitelist-in-tools'
@@ -35,7 +36,6 @@ meson_options_help() {
   printf "%s\n" '  --enable-module-upgrades try to load modules from alternate paths for'
   printf "%s\n" '                           upgrades'
   printf "%s\n" '  --enable-profiler        profiler support'
-  printf "%s\n" '  --enable-qom-cast-debug  cast debugging support'
   printf "%s\n" '  --enable-rng-none        dummy RNG, avoid using /dev/(u)random and'
   printf "%s\n" '                           getrandom()'
   printf "%s\n" '  --enable-strip           Strip targets on install'
-- 
2.31.1

Re: [PATCH 2/2] meson_options.txt: Enable qom-cast-debug by default again

Posted by Philippe Mathieu-Daudé 2 years, 9 months ago

On 17/4/23 15:00, Thomas Huth wrote:
> This switch had been disabled by default by accident in commit
> c55cf6ab03f. But we should enable it by default instead to avoid
> regressions in the QOM device hierarchy.
> 
> Fixes: c55cf6ab03 ("configure, meson: move some default-disabled options to meson_options.txt")
> Signed-off-by: Thomas Huth <thuth@redhat.com>
> ---
>   meson_options.txt             | 2 +-
>   scripts/meson-buildoptions.sh | 2 +-
>   2 files changed, 2 insertions(+), 2 deletions(-)

Reported-by: Peter Maydell <peter.maydell@linaro.org>
Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>

Re: [PATCH 2/2] meson_options.txt: Enable qom-cast-debug by default again

Posted by Peter Maydell 2 years, 9 months ago

On Mon, 17 Apr 2023 at 14:00, Thomas Huth <thuth@redhat.com> wrote:
>
> This switch had been disabled by default by accident in commit
> c55cf6ab03f. But we should enable it by default instead to avoid
> regressions in the QOM device hierarchy.
>
> Fixes: c55cf6ab03 ("configure, meson: move some default-disabled options to meson_options.txt")
> Signed-off-by: Thomas Huth <thuth@redhat.com>
> ---
>  meson_options.txt             | 2 +-
>  scripts/meson-buildoptions.sh | 2 +-
>  2 files changed, 2 insertions(+), 2 deletions(-)

Reviewed-by: Peter Maydell <peter.maydell@linaro.org>

thanks
-- PMM