1
This bug seemed worth fixing for 8.0 since we need an rc4 anyway:
1
v2 changes: dropped the patch that enables the new 'notcg' CI test:
2
we were using uninitialized data for the guarded bit when
2
it doesn't pass on our aarch64 runner because the CI runner doesn't
3
combining stage 1 and stage 2 attrs.
3
have access to /dev/kvm.
4
4
5
thanks
5
thanks
6
-- PMM
6
-- PMM
7
7
8
The following changes since commit 08dede07030973c1053868bc64de7e10bfa02ad6:
8
The following changes since commit 7c18f2d663521f1b31b821a13358ce38075eaf7d:
9
9
10
Merge tag 'pull-ppc-20230409' of https://github.com/legoater/qemu into staging (2023-04-10 11:47:52 +0100)
10
Merge tag 'for-upstream' of https://gitlab.com/bonzini/qemu into staging (2023-04-29 23:07:17 +0100)
11
11
12
are available in the Git repository at:
12
are available in the Git repository at:
13
13
14
https://git.linaro.org/people/pmaydell/qemu-arm.git tags/pull-target-arm-20230410
14
https://git.linaro.org/people/pmaydell/qemu-arm.git tags/pull-target-arm-20230502-2
15
15
16
for you to fetch changes up to 8539dc00552e8ea60420856fc1262c8299bc6308:
16
for you to fetch changes up to a4ae17e5ec512862bf73e40dfbb1e7db71f2c1e7:
17
17
18
target/arm: Copy guarded bit in combine_cacheattrs (2023-04-10 14:31:40 +0100)
18
hw/net/allwinner-sun8i-emac: Correctly byteswap descriptor fields (2023-05-02 15:47:41 +0100)
19
19
20
----------------------------------------------------------------
20
----------------------------------------------------------------
21
target-arm: Fix bug where we weren't initializing
21
target-arm queue:
22
guarded bit state when combining S1/S2 attrs
22
* Support building Arm targets with CONFIG_TCG=no (ie KVM only)
23
* hw/net: npcm7xx_emc: set MAC in register space
24
* hw/arm/bcm2835_property: Implement "get command line" message
25
* Deprecate the '-singlestep' command line option in favour of
26
'-one-insn-per-tb' and '-accel one-insn-per-tb=on'
27
* Deprecate 'singlestep' member of QMP StatusInfo struct
28
* docs/about/deprecated.rst: Add "since 7.1" tag to dtb-kaslr-seed deprecation
29
* hw/net/msf2-emac: Don't modify descriptor in-place in emac_store_desc()
30
* raspi, aspeed: Write bootloader code correctly on big-endian hosts
31
* hw/intc/allwinner-a10-pic: Fix bug on big-endian hosts
32
* Fix bug in A32 ERET on big-endian hosts that caused guest crash
33
* hw/sd/allwinner-sdhost: Correctly byteswap descriptor fields
34
* hw/net/allwinner-sun8i-emac: Correctly byteswap descriptor fields
23
35
24
----------------------------------------------------------------
36
----------------------------------------------------------------
25
Richard Henderson (2):
37
Claudio Fontana (1):
26
target/arm: PTE bit GP only applies to stage1
38
target/arm: move cpu_tcg to tcg/cpu32.c
27
target/arm: Copy guarded bit in combine_cacheattrs
28
39
29
target/arm/ptw.c | 11 ++++++-----
40
Cédric Le Goater (2):
30
1 file changed, 6 insertions(+), 5 deletions(-)
41
hw/arm/boot: Make write_bootloader() public as arm_write_bootloader()
42
hw/arm/aspeed: Use arm_write_bootloader() to write the bootloader
43
44
Daniel Bertalan (1):
45
hw/arm/bcm2835_property: Implement "get command line" message
46
47
Fabiano Rosas (11):
48
target/arm: Move cortex sysregs into a separate file
49
target/arm: Remove dead code from cpu_max_set_sve_max_vq
50
target/arm: Extract TCG -cpu max code into a function
51
target/arm: Do not expose all -cpu max features to qtests
52
target/arm: Move 64-bit TCG CPUs into tcg/
53
tests/qtest: Adjust and document query-cpu-model-expansion test for arm
54
tests/qtest: Fix tests when no KVM or TCG are present
55
tests/avocado: Pass parameters to migration test
56
arm/Kconfig: Always select SEMIHOSTING when TCG is present
57
arm/Kconfig: Do not build TCG-only boards on a KVM-only build
58
tests/qtest: Restrict tpm-tis-i2c-test to CONFIG_TCG
59
60
Patrick Venture (1):
61
hw/net: npcm7xx_emc: set MAC in register space
62
63
Peter Maydell (18):
64
make one-insn-per-tb an accel option
65
softmmu: Don't use 'singlestep' global in QMP and HMP commands
66
accel/tcg: Use one_insn_per_tb global instead of old singlestep global
67
linux-user: Add '-one-insn-per-tb' option equivalent to '-singlestep'
68
bsd-user: Add '-one-insn-per-tb' option equivalent to '-singlestep'
69
Document that -singlestep command line option is deprecated
70
accel/tcg: Report one-insn-per-tb in 'info jit', not 'info status'
71
hmp: Add 'one-insn-per-tb' command equivalent to 'singlestep'
72
qapi/run-state.json: Fix missing newline at end of file
73
qmp: Deprecate 'singlestep' member of StatusInfo
74
docs/about/deprecated.rst: Add "since 7.1" tag to dtb-kaslr-seed deprecation
75
hw/net/msf2-emac: Don't modify descriptor in-place in emac_store_desc()
76
hw/arm/raspi: Use arm_write_bootloader() to write boot code
77
hw/intc/allwinner-a10-pic: Don't use set_bit()/clear_bit()
78
target/arm: Define and use new load_cpu_field_low32()
79
target/arm: Add compile time asserts to load/store_cpu_field macros
80
hw/sd/allwinner-sdhost: Correctly byteswap descriptor fields
81
hw/net/allwinner-sun8i-emac: Correctly byteswap descriptor fields
82
83
docs/about/deprecated.rst | 43 +-
84
docs/user/main.rst | 14 +-
85
configs/devices/aarch64-softmmu/default.mak | 4 -
86
configs/devices/arm-softmmu/default.mak | 39 --
87
qapi/run-state.json | 16 +-
88
accel/tcg/internal.h | 2 +
89
include/exec/cpu-common.h | 2 -
90
include/hw/arm/boot.h | 49 ++
91
include/hw/misc/bcm2835_property.h | 1 +
92
include/monitor/hmp.h | 2 +-
93
target/arm/cpregs.h | 6 +
94
target/arm/internals.h | 10 +-
95
target/arm/translate-a32.h | 24 +-
96
accel/tcg/cpu-exec.c | 2 +-
97
accel/tcg/monitor.c | 14 +
98
accel/tcg/tcg-all.c | 23 +
99
bsd-user/main.c | 14 +-
100
hw/arm/aspeed.c | 38 +-
101
hw/arm/bcm2835_peripherals.c | 2 +
102
hw/arm/bcm2836.c | 2 +
103
hw/arm/boot.c | 35 +-
104
hw/arm/raspi.c | 66 +--
105
hw/arm/virt.c | 6 +-
106
hw/intc/allwinner-a10-pic.c | 7 +-
107
hw/misc/bcm2835_property.c | 13 +-
108
hw/net/allwinner-sun8i-emac.c | 22 +-
109
hw/net/msf2-emac.c | 16 +-
110
hw/net/npcm7xx_emc.c | 32 +-
111
hw/sd/allwinner-sdhost.c | 31 +-
112
linux-user/main.c | 18 +-
113
softmmu/globals.c | 1 -
114
softmmu/runstate-hmp-cmds.c | 25 +-
115
softmmu/runstate.c | 10 +-
116
softmmu/vl.c | 17 +-
117
target/arm/cortex-regs.c | 69 +++
118
target/arm/cpu64.c | 702 +--------------------------
119
target/arm/{cpu_tcg.c => tcg/cpu32.c} | 72 +--
120
target/arm/tcg/cpu64.c | 723 ++++++++++++++++++++++++++++
121
target/arm/tcg/translate.c | 4 +-
122
tests/qtest/arm-cpu-features.c | 20 +-
123
tests/qtest/bios-tables-test.c | 11 +-
124
tests/qtest/boot-serial-test.c | 5 +
125
tests/qtest/migration-test.c | 9 +-
126
tests/qtest/pxe-test.c | 8 +-
127
tests/qtest/test-hmp.c | 1 +
128
tests/qtest/vmgenid-test.c | 9 +-
129
hmp-commands.hx | 25 +-
130
hw/arm/Kconfig | 43 +-
131
qemu-options.hx | 12 +-
132
target/arm/Kconfig | 7 +
133
target/arm/meson.build | 2 +-
134
target/arm/tcg/meson.build | 2 +
135
tcg/tci/README | 2 +-
136
tests/avocado/migration.py | 83 +++-
137
tests/qtest/meson.build | 3 +-
138
55 files changed, 1438 insertions(+), 980 deletions(-)
139
create mode 100644 target/arm/cortex-regs.c
140
rename target/arm/{cpu_tcg.c => tcg/cpu32.c} (93%)
141
create mode 100644 target/arm/tcg/cpu64.c
142
diff view generated by jsdifflib
Deleted patch
1
From: Richard Henderson <richard.henderson@linaro.org>
2
1
3
Only perform the extract of GP during the stage1 walk.
4
5
Reported-by: Peter Maydell <peter.maydell@linaro.org>
6
Signed-off-by: Richard Henderson <richard.henderson@linaro.org>
7
Reviewed-by: Peter Maydell <peter.maydell@linaro.org>
8
Message-id: 20230407185149.3253946-2-richard.henderson@linaro.org
9
Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
10
---
11
target/arm/ptw.c | 10 +++++-----
12
1 file changed, 5 insertions(+), 5 deletions(-)
13
14
diff --git a/target/arm/ptw.c b/target/arm/ptw.c
15
index XXXXXXX..XXXXXXX 100644
16
--- a/target/arm/ptw.c
17
+++ b/target/arm/ptw.c
18
@@ -XXX,XX +XXX,XX @@ static bool get_phys_addr_lpae(CPUARMState *env, S1Translate *ptw,
19
result->f.attrs.secure = false;
20
}
21
22
- /* When in aarch64 mode, and BTI is enabled, remember GP in the TLB. */
23
- if (aarch64 && cpu_isar_feature(aa64_bti, cpu)) {
24
- result->f.guarded = extract64(attrs, 50, 1); /* GP */
25
- }
26
-
27
if (regime_is_stage2(mmu_idx)) {
28
result->cacheattrs.is_s2_format = true;
29
result->cacheattrs.attrs = extract32(attrs, 2, 4);
30
@@ -XXX,XX +XXX,XX @@ static bool get_phys_addr_lpae(CPUARMState *env, S1Translate *ptw,
31
assert(attrindx <= 7);
32
result->cacheattrs.is_s2_format = false;
33
result->cacheattrs.attrs = extract64(mair, attrindx * 8, 8);
34
+
35
+ /* When in aarch64 mode, and BTI is enabled, remember GP in the TLB. */
36
+ if (aarch64 && cpu_isar_feature(aa64_bti, cpu)) {
37
+ result->f.guarded = extract64(attrs, 50, 1); /* GP */
38
+ }
39
}
40
41
/*
42
--
43
2.34.1
diff view generated by jsdifflib
Deleted patch
1
From: Richard Henderson <richard.henderson@linaro.org>
2
1
3
The guarded bit comes from the stage1 walk.
4
5
Fixes: Coverity CID 1507929
6
Signed-off-by: Richard Henderson <richard.henderson@linaro.org>
7
Reviewed-by: Peter Maydell <peter.maydell@linaro.org>
8
Message-id: 20230407185149.3253946-3-richard.henderson@linaro.org
9
Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
10
---
11
target/arm/ptw.c | 1 +
12
1 file changed, 1 insertion(+)
13
14
diff --git a/target/arm/ptw.c b/target/arm/ptw.c
15
index XXXXXXX..XXXXXXX 100644
16
--- a/target/arm/ptw.c
17
+++ b/target/arm/ptw.c
18
@@ -XXX,XX +XXX,XX @@ static ARMCacheAttrs combine_cacheattrs(uint64_t hcr,
19
20
assert(!s1.is_s2_format);
21
ret.is_s2_format = false;
22
+ ret.guarded = s1.guarded;
23
24
if (s1.attrs == 0xf0) {
25
tagged = true;
26
--
27
2.34.1
diff view generated by jsdifflib