1 | This bug seemed worth fixing for 8.0 since we need an rc4 anyway: | 1 | v1->v2: fix up format string issues in aspeed_i3c.c |
---|---|---|---|
2 | we were using uninitialized data for the guarded bit when | ||
3 | combining stage 1 and stage 2 attrs. | ||
4 | 2 | ||
5 | thanks | ||
6 | -- PMM | 3 | -- PMM |
7 | 4 | ||
8 | The following changes since commit 08dede07030973c1053868bc64de7e10bfa02ad6: | 5 | The following changes since commit b10d00d8811fa4eed4862963273d7353ce310c82: |
9 | 6 | ||
10 | Merge tag 'pull-ppc-20230409' of https://github.com/legoater/qemu into staging (2023-04-10 11:47:52 +0100) | 7 | Merge remote-tracking branch 'remotes/kraxel/tags/seabios-20220118-pull-request' into staging (2022-01-19 18:46:28 +0000) |
11 | 8 | ||
12 | are available in the Git repository at: | 9 | are available in the Git repository at: |
13 | 10 | ||
14 | https://git.linaro.org/people/pmaydell/qemu-arm.git tags/pull-target-arm-20230410 | 11 | https://git.linaro.org/people/pmaydell/qemu-arm.git tags/pull-target-arm-20220120-1 |
15 | 12 | ||
16 | for you to fetch changes up to 8539dc00552e8ea60420856fc1262c8299bc6308: | 13 | for you to fetch changes up to b9d383ab797f54ae5fa8746117770709921dc529: |
17 | 14 | ||
18 | target/arm: Copy guarded bit in combine_cacheattrs (2023-04-10 14:31:40 +0100) | 15 | hw/intc/arm_gicv3: Check for !MEMTX_OK instead of MEMTX_ERROR (2022-01-20 16:04:58 +0000) |
19 | 16 | ||
20 | ---------------------------------------------------------------- | 17 | ---------------------------------------------------------------- |
21 | target-arm: Fix bug where we weren't initializing | 18 | target-arm: |
22 | guarded bit state when combining S1/S2 attrs | 19 | * hw/intc/arm_gicv3_its: Fix various minor bugs |
20 | * hw/arm/aspeed: Add the i3c device to the AST2600 SoC | ||
21 | * hw/arm: kudo: add lm75s behind bus 1 switch at 75 | ||
22 | * hw/arm/virt: Fix support for running guests on hosts | ||
23 | with restricted IPA ranges | ||
24 | * hw/intc/arm_gic: Allow reset of the running priority | ||
25 | * hw/intc/arm_gic: Implement read of GICC_IIDR | ||
26 | * hw/arm/virt: Support for virtio-mem-pci | ||
27 | * hw/arm/virt: Support CPU cluster on ARM virt machine | ||
28 | * docs/can: convert to restructuredText | ||
29 | * hw/net: Move MV88W8618 network device out of hw/arm/ directory | ||
30 | * hw/arm/virt: KVM: Enable PAuth when supported by the host | ||
23 | 31 | ||
24 | ---------------------------------------------------------------- | 32 | ---------------------------------------------------------------- |
25 | Richard Henderson (2): | 33 | Gavin Shan (2): |
26 | target/arm: PTE bit GP only applies to stage1 | 34 | virtio-mem: Correct default THP size for ARM64 |
27 | target/arm: Copy guarded bit in combine_cacheattrs | 35 | hw/arm/virt: Support for virtio-mem-pci |
28 | 36 | ||
29 | target/arm/ptw.c | 11 ++++++----- | 37 | Lucas Ramage (1): |
30 | 1 file changed, 6 insertions(+), 5 deletions(-) | 38 | docs/can: convert to restructuredText |
39 | |||
40 | Marc Zyngier (7): | ||
41 | hw/arm/virt: KVM: Enable PAuth when supported by the host | ||
42 | hw/arm/virt: Add a control for the the highmem PCIe MMIO | ||
43 | hw/arm/virt: Add a control for the the highmem redistributors | ||
44 | hw/arm/virt: Honor highmem setting when computing the memory map | ||
45 | hw/arm/virt: Use the PA range to compute the memory map | ||
46 | hw/arm/virt: Disable highmem devices that don't fit in the PA range | ||
47 | hw/arm/virt: Drop superfluous checks against highmem | ||
48 | |||
49 | Patrick Venture (1): | ||
50 | hw/arm: kudo add lm75s behind bus 1 switch at 75 | ||
51 | |||
52 | Peter Maydell (13): | ||
53 | hw/intc/arm_gicv3_its: Fix event ID bounds checks | ||
54 | hw/intc/arm_gicv3_its: Convert int ID check to num_intids convention | ||
55 | hw/intc/arm_gicv3_its: Fix handling of process_its_cmd() return value | ||
56 | hw/intc/arm_gicv3_its: Don't use data if reading command failed | ||
57 | hw/intc/arm_gicv3_its: Use enum for return value of process_* functions | ||
58 | hw/intc/arm_gicv3_its: Fix return codes in process_its_cmd() | ||
59 | hw/intc/arm_gicv3_its: Refactor process_its_cmd() to reduce nesting | ||
60 | hw/intc/arm_gicv3_its: Fix return codes in process_mapti() | ||
61 | hw/intc/arm_gicv3_its: Fix return codes in process_mapc() | ||
62 | hw/intc/arm_gicv3_its: Fix return codes in process_mapd() | ||
63 | hw/intc/arm_gicv3_its: Factor out "find address of table entry" code | ||
64 | hw/intc/arm_gicv3_its: Check indexes before use, not after | ||
65 | hw/intc/arm_gicv3_its: Range-check ICID before indexing into collection table | ||
66 | |||
67 | Petr Pavlu (2): | ||
68 | hw/intc/arm_gic: Implement read of GICC_IIDR | ||
69 | hw/intc/arm_gic: Allow reset of the running priority | ||
70 | |||
71 | Philippe Mathieu-Daudé (4): | ||
72 | hw: Move MARVELL_88W8618 Kconfig from audio/ to arm/ | ||
73 | hw/arm/musicpal: Fix coding style of code related to MV88W8618 device | ||
74 | hw/net: Move MV88W8618 network device out of hw/arm/ directory | ||
75 | hw/intc/arm_gicv3: Check for !MEMTX_OK instead of MEMTX_ERROR | ||
76 | |||
77 | Troy Lee (2): | ||
78 | hw/misc/aspeed_i3c.c: Introduce a dummy AST2600 I3C model. | ||
79 | hw/arm/aspeed: Add the i3c device to the AST2600 SoC | ||
80 | |||
81 | Yanan Wang (6): | ||
82 | hw/arm/virt: Support CPU cluster on ARM virt machine | ||
83 | hw/arm/virt: Support cluster level in DT cpu-map | ||
84 | hw/acpi/aml-build: Improve scalability of PPTT generation | ||
85 | tests/acpi/bios-tables-test: Allow changes to virt/PPTT file | ||
86 | hw/acpi/aml-build: Support cluster level in PPTT generation | ||
87 | tests/acpi/bios-table-test: Update expected virt/PPTT file | ||
88 | |||
89 | docs/system/arm/cpu-features.rst | 4 - | ||
90 | docs/system/device-emulation.rst | 1 + | ||
91 | docs/{can.txt => system/devices/can.rst} | 90 +++--- | ||
92 | include/hw/arm/aspeed_soc.h | 3 + | ||
93 | include/hw/arm/virt.h | 5 +- | ||
94 | include/hw/misc/aspeed_i3c.h | 48 +++ | ||
95 | include/hw/net/mv88w8618_eth.h | 12 + | ||
96 | target/arm/cpu.h | 1 + | ||
97 | hw/acpi/aml-build.c | 68 +++-- | ||
98 | hw/arm/aspeed_ast2600.c | 16 + | ||
99 | hw/arm/musicpal.c | 381 +----------------------- | ||
100 | hw/arm/npcm7xx_boards.c | 10 +- | ||
101 | hw/arm/virt-acpi-build.c | 10 +- | ||
102 | hw/arm/virt.c | 184 ++++++++++-- | ||
103 | hw/intc/arm_gic.c | 11 + | ||
104 | hw/intc/arm_gicv3_its.c | 492 ++++++++++++++----------------- | ||
105 | hw/intc/arm_gicv3_redist.c | 4 +- | ||
106 | hw/misc/aspeed_i3c.c | 384 ++++++++++++++++++++++++ | ||
107 | hw/net/mv88w8618_eth.c | 403 +++++++++++++++++++++++++ | ||
108 | hw/virtio/virtio-mem.c | 36 ++- | ||
109 | target/arm/cpu.c | 16 +- | ||
110 | target/arm/cpu64.c | 31 +- | ||
111 | target/arm/kvm64.c | 21 ++ | ||
112 | MAINTAINERS | 2 + | ||
113 | hw/arm/Kconfig | 4 + | ||
114 | hw/audio/Kconfig | 3 - | ||
115 | hw/misc/meson.build | 1 + | ||
116 | hw/misc/trace-events | 6 + | ||
117 | hw/net/meson.build | 1 + | ||
118 | qemu-options.hx | 10 + | ||
119 | tests/data/acpi/virt/PPTT | Bin 76 -> 96 bytes | ||
120 | 31 files changed, 1476 insertions(+), 782 deletions(-) | ||
121 | rename docs/{can.txt => system/devices/can.rst} (68%) | ||
122 | create mode 100644 include/hw/misc/aspeed_i3c.h | ||
123 | create mode 100644 include/hw/net/mv88w8618_eth.h | ||
124 | create mode 100644 hw/misc/aspeed_i3c.c | ||
125 | create mode 100644 hw/net/mv88w8618_eth.c | ||
126 | diff view generated by jsdifflib |
Deleted patch | |||
---|---|---|---|
1 | From: Richard Henderson <richard.henderson@linaro.org> | ||
2 | 1 | ||
3 | Only perform the extract of GP during the stage1 walk. | ||
4 | |||
5 | Reported-by: Peter Maydell <peter.maydell@linaro.org> | ||
6 | Signed-off-by: Richard Henderson <richard.henderson@linaro.org> | ||
7 | Reviewed-by: Peter Maydell <peter.maydell@linaro.org> | ||
8 | Message-id: 20230407185149.3253946-2-richard.henderson@linaro.org | ||
9 | Signed-off-by: Peter Maydell <peter.maydell@linaro.org> | ||
10 | --- | ||
11 | target/arm/ptw.c | 10 +++++----- | ||
12 | 1 file changed, 5 insertions(+), 5 deletions(-) | ||
13 | |||
14 | diff --git a/target/arm/ptw.c b/target/arm/ptw.c | ||
15 | index XXXXXXX..XXXXXXX 100644 | ||
16 | --- a/target/arm/ptw.c | ||
17 | +++ b/target/arm/ptw.c | ||
18 | @@ -XXX,XX +XXX,XX @@ static bool get_phys_addr_lpae(CPUARMState *env, S1Translate *ptw, | ||
19 | result->f.attrs.secure = false; | ||
20 | } | ||
21 | |||
22 | - /* When in aarch64 mode, and BTI is enabled, remember GP in the TLB. */ | ||
23 | - if (aarch64 && cpu_isar_feature(aa64_bti, cpu)) { | ||
24 | - result->f.guarded = extract64(attrs, 50, 1); /* GP */ | ||
25 | - } | ||
26 | - | ||
27 | if (regime_is_stage2(mmu_idx)) { | ||
28 | result->cacheattrs.is_s2_format = true; | ||
29 | result->cacheattrs.attrs = extract32(attrs, 2, 4); | ||
30 | @@ -XXX,XX +XXX,XX @@ static bool get_phys_addr_lpae(CPUARMState *env, S1Translate *ptw, | ||
31 | assert(attrindx <= 7); | ||
32 | result->cacheattrs.is_s2_format = false; | ||
33 | result->cacheattrs.attrs = extract64(mair, attrindx * 8, 8); | ||
34 | + | ||
35 | + /* When in aarch64 mode, and BTI is enabled, remember GP in the TLB. */ | ||
36 | + if (aarch64 && cpu_isar_feature(aa64_bti, cpu)) { | ||
37 | + result->f.guarded = extract64(attrs, 50, 1); /* GP */ | ||
38 | + } | ||
39 | } | ||
40 | |||
41 | /* | ||
42 | -- | ||
43 | 2.34.1 | diff view generated by jsdifflib |
Deleted patch | |||
---|---|---|---|
1 | From: Richard Henderson <richard.henderson@linaro.org> | ||
2 | 1 | ||
3 | The guarded bit comes from the stage1 walk. | ||
4 | |||
5 | Fixes: Coverity CID 1507929 | ||
6 | Signed-off-by: Richard Henderson <richard.henderson@linaro.org> | ||
7 | Reviewed-by: Peter Maydell <peter.maydell@linaro.org> | ||
8 | Message-id: 20230407185149.3253946-3-richard.henderson@linaro.org | ||
9 | Signed-off-by: Peter Maydell <peter.maydell@linaro.org> | ||
10 | --- | ||
11 | target/arm/ptw.c | 1 + | ||
12 | 1 file changed, 1 insertion(+) | ||
13 | |||
14 | diff --git a/target/arm/ptw.c b/target/arm/ptw.c | ||
15 | index XXXXXXX..XXXXXXX 100644 | ||
16 | --- a/target/arm/ptw.c | ||
17 | +++ b/target/arm/ptw.c | ||
18 | @@ -XXX,XX +XXX,XX @@ static ARMCacheAttrs combine_cacheattrs(uint64_t hcr, | ||
19 | |||
20 | assert(!s1.is_s2_format); | ||
21 | ret.is_s2_format = false; | ||
22 | + ret.guarded = s1.guarded; | ||
23 | |||
24 | if (s1.attrs == 0xf0) { | ||
25 | tagged = true; | ||
26 | -- | ||
27 | 2.34.1 | diff view generated by jsdifflib |