1
This bug seemed worth fixing for 8.0 since we need an rc4 anyway:
1
v2 update: fix memory leaks in pvpanic-pci test case spotted by
2
we were using uninitialized data for the guarded bit when
2
oss-fuzz gitlab CI run.
3
combining stage 1 and stage 2 attrs.
4
3
5
thanks
6
-- PMM
4
-- PMM
7
5
8
The following changes since commit 08dede07030973c1053868bc64de7e10bfa02ad6:
6
The following changes since commit 7e7eb9f852a46b51a71ae9d82590b2e4d28827ee:
9
7
10
Merge tag 'pull-ppc-20230409' of https://github.com/legoater/qemu into staging (2023-04-10 11:47:52 +0100)
8
Merge remote-tracking branch 'remotes/armbru/tags/pull-qapi-2021-01-28' into staging (2021-01-28 22:43:18 +0000)
11
9
12
are available in the Git repository at:
10
are available in the Git repository at:
13
11
14
https://git.linaro.org/people/pmaydell/qemu-arm.git tags/pull-target-arm-20230410
12
https://git.linaro.org/people/pmaydell/qemu-arm.git tags/pull-target-arm-20210129-1
15
13
16
for you to fetch changes up to 8539dc00552e8ea60420856fc1262c8299bc6308:
14
for you to fetch changes up to 14711b6f54708b9583796db02b12ee7bd0331502:
17
15
18
target/arm: Copy guarded bit in combine_cacheattrs (2023-04-10 14:31:40 +0100)
16
hw/arm/stellaris: Remove board-creation reset of STELLARIS_SYS (2021-01-29 15:54:44 +0000)
19
17
20
----------------------------------------------------------------
18
----------------------------------------------------------------
21
target-arm: Fix bug where we weren't initializing
19
target-arm queue:
22
guarded bit state when combining S1/S2 attrs
20
* Implement ID_PFR2
21
* Conditionalize DBGDIDR
22
* rename xlnx-zcu102.canbusN properties
23
* provide powerdown/reset mechanism for secure firmware on 'virt' board
24
* hw/misc: Fix arith overflow in NPCM7XX PWM module
25
* target/arm: Replace magic value by MMU_DATA_LOAD definition
26
* configure: fix preadv errors on Catalina macOS with new XCode
27
* Various configure and other cleanups in preparation for iOS support
28
* hvf: Add hypervisor entitlement to output binaries (needed for Big Sur)
29
* Implement pvpanic-pci device
30
* Convert the CMSDK timer devices to the Clock framework
23
31
24
----------------------------------------------------------------
32
----------------------------------------------------------------
33
Alexander Graf (1):
34
hvf: Add hypervisor entitlement to output binaries
35
36
Hao Wu (1):
37
hw/misc: Fix arith overflow in NPCM7XX PWM module
38
39
Joelle van Dyne (7):
40
configure: cross-compiling with empty cross_prefix
41
osdep: build with non-working system() function
42
darwin: remove redundant dependency declaration
43
darwin: fix cross-compiling for Darwin
44
configure: cross compile should use x86_64 cpu_family
45
darwin: detect CoreAudio for build
46
darwin: remove 64-bit build detection on 32-bit OS
47
48
Maxim Uvarov (3):
49
hw: gpio: implement gpio-pwr driver for qemu reset/poweroff
50
arm-virt: refactor gpios creation
51
arm-virt: add secure pl061 for reset/power down
52
53
Mihai Carabas (4):
54
hw/misc/pvpanic: split-out generic and bus dependent code
55
hw/misc/pvpanic: add PCI interface support
56
pvpanic : update pvpanic spec document
57
tests/qtest: add a test case for pvpanic-pci
58
59
Paolo Bonzini (1):
60
arm: rename xlnx-zcu102.canbusN properties
61
62
Peter Maydell (26):
63
configure: Move preadv check to meson.build
64
ptimer: Add new ptimer_set_period_from_clock() function
65
clock: Add new clock_has_source() function
66
tests: Add a simple test of the CMSDK APB timer
67
tests: Add a simple test of the CMSDK APB watchdog
68
tests: Add a simple test of the CMSDK APB dual timer
69
hw/timer/cmsdk-apb-timer: Rename CMSDKAPBTIMER struct to CMSDKAPBTimer
70
hw/timer/cmsdk-apb-timer: Add Clock input
71
hw/timer/cmsdk-apb-dualtimer: Add Clock input
72
hw/watchdog/cmsdk-apb-watchdog: Add Clock input
73
hw/arm/armsse: Rename "MAINCLK" property to "MAINCLK_FRQ"
74
hw/arm/armsse: Wire up clocks
75
hw/arm/mps2: Inline CMSDK_APB_TIMER creation
76
hw/arm/mps2: Create and connect SYSCLK Clock
77
hw/arm/mps2-tz: Create and connect ARMSSE Clocks
78
hw/arm/musca: Create and connect ARMSSE Clocks
79
hw/arm/stellaris: Convert SSYS to QOM device
80
hw/arm/stellaris: Create Clock input for watchdog
81
hw/timer/cmsdk-apb-timer: Convert to use Clock input
82
hw/timer/cmsdk-apb-dualtimer: Convert to use Clock input
83
hw/watchdog/cmsdk-apb-watchdog: Convert to use Clock input
84
tests/qtest/cmsdk-apb-watchdog-test: Test clock changes
85
hw/arm/armsse: Use Clock to set system_clock_scale
86
arm: Don't set freq properties on CMSDK timer, dualtimer, watchdog, ARMSSE
87
arm: Remove frq properties on CMSDK timer, dualtimer, watchdog, ARMSSE
88
hw/arm/stellaris: Remove board-creation reset of STELLARIS_SYS
89
90
Philippe Mathieu-Daudé (1):
91
target/arm: Replace magic value by MMU_DATA_LOAD definition
92
25
Richard Henderson (2):
93
Richard Henderson (2):
26
target/arm: PTE bit GP only applies to stage1
94
target/arm: Implement ID_PFR2
27
target/arm: Copy guarded bit in combine_cacheattrs
95
target/arm: Conditionalize DBGDIDR
28
96
29
target/arm/ptw.c | 11 ++++++-----
97
docs/devel/clocks.rst | 16 +++
30
1 file changed, 6 insertions(+), 5 deletions(-)
98
docs/specs/pci-ids.txt | 1 +
99
docs/specs/pvpanic.txt | 13 ++-
100
docs/system/arm/virt.rst | 2 +
101
configure | 78 ++++++++------
102
meson.build | 34 ++++++-
103
include/hw/arm/armsse.h | 14 ++-
104
include/hw/arm/virt.h | 2 +
105
include/hw/clock.h | 15 +++
106
include/hw/misc/pvpanic.h | 24 ++++-
107
include/hw/pci/pci.h | 1 +
108
include/hw/ptimer.h | 22 ++++
109
include/hw/timer/cmsdk-apb-dualtimer.h | 5 +-
110
include/hw/timer/cmsdk-apb-timer.h | 34 ++-----
111
include/hw/watchdog/cmsdk-apb-watchdog.h | 5 +-
112
include/qemu/osdep.h | 12 +++
113
include/qemu/typedefs.h | 1 +
114
target/arm/cpu.h | 1 +
115
hw/arm/armsse.c | 48 ++++++---
116
hw/arm/mps2-tz.c | 14 ++-
117
hw/arm/mps2.c | 28 ++++-
118
hw/arm/musca.c | 13 ++-
119
hw/arm/stellaris.c | 170 +++++++++++++++++++++++--------
120
hw/arm/virt.c | 111 ++++++++++++++++----
121
hw/arm/xlnx-zcu102.c | 4 +-
122
hw/core/ptimer.c | 34 +++++++
123
hw/gpio/gpio_pwr.c | 70 +++++++++++++
124
hw/misc/npcm7xx_pwm.c | 23 ++++-
125
hw/misc/pvpanic-isa.c | 94 +++++++++++++++++
126
hw/misc/pvpanic-pci.c | 94 +++++++++++++++++
127
hw/misc/pvpanic.c | 85 ++--------------
128
hw/timer/cmsdk-apb-dualtimer.c | 53 +++++++---
129
hw/timer/cmsdk-apb-timer.c | 55 +++++-----
130
hw/watchdog/cmsdk-apb-watchdog.c | 29 ++++--
131
target/arm/helper.c | 27 +++--
132
target/arm/kvm64.c | 2 +
133
tests/qtest/cmsdk-apb-dualtimer-test.c | 130 +++++++++++++++++++++++
134
tests/qtest/cmsdk-apb-timer-test.c | 75 ++++++++++++++
135
tests/qtest/cmsdk-apb-watchdog-test.c | 131 ++++++++++++++++++++++++
136
tests/qtest/npcm7xx_pwm-test.c | 4 +-
137
tests/qtest/pvpanic-pci-test.c | 98 ++++++++++++++++++
138
tests/qtest/xlnx-can-test.c | 30 +++---
139
MAINTAINERS | 3 +
140
accel/hvf/entitlements.plist | 8 ++
141
hw/arm/Kconfig | 1 +
142
hw/gpio/Kconfig | 3 +
143
hw/gpio/meson.build | 1 +
144
hw/i386/Kconfig | 2 +-
145
hw/misc/Kconfig | 12 ++-
146
hw/misc/meson.build | 4 +-
147
scripts/entitlement.sh | 13 +++
148
tests/qtest/meson.build | 6 +-
149
52 files changed, 1436 insertions(+), 319 deletions(-)
150
create mode 100644 hw/gpio/gpio_pwr.c
151
create mode 100644 hw/misc/pvpanic-isa.c
152
create mode 100644 hw/misc/pvpanic-pci.c
153
create mode 100644 tests/qtest/cmsdk-apb-dualtimer-test.c
154
create mode 100644 tests/qtest/cmsdk-apb-timer-test.c
155
create mode 100644 tests/qtest/cmsdk-apb-watchdog-test.c
156
create mode 100644 tests/qtest/pvpanic-pci-test.c
157
create mode 100644 accel/hvf/entitlements.plist
158
create mode 100755 scripts/entitlement.sh
159
diff view generated by jsdifflib
Deleted patch
1
From: Richard Henderson <richard.henderson@linaro.org>
2
1
3
Only perform the extract of GP during the stage1 walk.
4
5
Reported-by: Peter Maydell <peter.maydell@linaro.org>
6
Signed-off-by: Richard Henderson <richard.henderson@linaro.org>
7
Reviewed-by: Peter Maydell <peter.maydell@linaro.org>
8
Message-id: 20230407185149.3253946-2-richard.henderson@linaro.org
9
Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
10
---
11
target/arm/ptw.c | 10 +++++-----
12
1 file changed, 5 insertions(+), 5 deletions(-)
13
14
diff --git a/target/arm/ptw.c b/target/arm/ptw.c
15
index XXXXXXX..XXXXXXX 100644
16
--- a/target/arm/ptw.c
17
+++ b/target/arm/ptw.c
18
@@ -XXX,XX +XXX,XX @@ static bool get_phys_addr_lpae(CPUARMState *env, S1Translate *ptw,
19
result->f.attrs.secure = false;
20
}
21
22
- /* When in aarch64 mode, and BTI is enabled, remember GP in the TLB. */
23
- if (aarch64 && cpu_isar_feature(aa64_bti, cpu)) {
24
- result->f.guarded = extract64(attrs, 50, 1); /* GP */
25
- }
26
-
27
if (regime_is_stage2(mmu_idx)) {
28
result->cacheattrs.is_s2_format = true;
29
result->cacheattrs.attrs = extract32(attrs, 2, 4);
30
@@ -XXX,XX +XXX,XX @@ static bool get_phys_addr_lpae(CPUARMState *env, S1Translate *ptw,
31
assert(attrindx <= 7);
32
result->cacheattrs.is_s2_format = false;
33
result->cacheattrs.attrs = extract64(mair, attrindx * 8, 8);
34
+
35
+ /* When in aarch64 mode, and BTI is enabled, remember GP in the TLB. */
36
+ if (aarch64 && cpu_isar_feature(aa64_bti, cpu)) {
37
+ result->f.guarded = extract64(attrs, 50, 1); /* GP */
38
+ }
39
}
40
41
/*
42
--
43
2.34.1
diff view generated by jsdifflib
Deleted patch
1
From: Richard Henderson <richard.henderson@linaro.org>
2
1
3
The guarded bit comes from the stage1 walk.
4
5
Fixes: Coverity CID 1507929
6
Signed-off-by: Richard Henderson <richard.henderson@linaro.org>
7
Reviewed-by: Peter Maydell <peter.maydell@linaro.org>
8
Message-id: 20230407185149.3253946-3-richard.henderson@linaro.org
9
Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
10
---
11
target/arm/ptw.c | 1 +
12
1 file changed, 1 insertion(+)
13
14
diff --git a/target/arm/ptw.c b/target/arm/ptw.c
15
index XXXXXXX..XXXXXXX 100644
16
--- a/target/arm/ptw.c
17
+++ b/target/arm/ptw.c
18
@@ -XXX,XX +XXX,XX @@ static ARMCacheAttrs combine_cacheattrs(uint64_t hcr,
19
20
assert(!s1.is_s2_format);
21
ret.is_s2_format = false;
22
+ ret.guarded = s1.guarded;
23
24
if (s1.attrs == 0xf0) {
25
tagged = true;
26
--
27
2.34.1
diff view generated by jsdifflib