1
This bug seemed worth fixing for 8.0 since we need an rc4 anyway:
1
v2: drop the 'merge the manuals' patch: it breaks the gitlab job which tries
2
we were using uninitialized data for the guarded bit when
2
to publish the docs on gitlab, and I also realised I forgot to update the
3
combining stage 1 and stage 2 attrs.
3
Windows installer scripts.
4
4
5
thanks
6
-- PMM
5
-- PMM
7
6
8
The following changes since commit 08dede07030973c1053868bc64de7e10bfa02ad6:
7
The following changes since commit b3f846c59d8405bb87c551187721fc92ff2f1b92:
9
8
10
Merge tag 'pull-ppc-20230409' of https://github.com/legoater/qemu into staging (2023-04-10 11:47:52 +0100)
9
Merge remote-tracking branch 'remotes/huth-gitlab/tags/pull-request-2021-01-11v2' into staging (2021-01-11 15:15:35 +0000)
11
10
12
are available in the Git repository at:
11
are available in the Git repository at:
13
12
14
https://git.linaro.org/people/pmaydell/qemu-arm.git tags/pull-target-arm-20230410
13
https://git.linaro.org/people/pmaydell/qemu-arm.git tags/pull-target-arm-20210112-1
15
14
16
for you to fetch changes up to 8539dc00552e8ea60420856fc1262c8299bc6308:
15
for you to fetch changes up to 1ff5a063d60c7737de11465516331b8ca8700865:
17
16
18
target/arm: Copy guarded bit in combine_cacheattrs (2023-04-10 14:31:40 +0100)
17
ui/cocoa: Fix openFile: deprecation on Big Sur (2021-01-12 21:19:02 +0000)
19
18
20
----------------------------------------------------------------
19
----------------------------------------------------------------
21
target-arm: Fix bug where we weren't initializing
20
target-arm queue:
22
guarded bit state when combining S1/S2 attrs
21
* arm: Support emulation of ARMv8.4-TTST extension
22
* arm: Update cpu.h ID register field definitions
23
* arm: Fix breakage of XScale instruction emulation
24
* hw/net/lan9118: Fix RX Status FIFO PEEK value
25
* npcm7xx: Add ADC and PWM emulation
26
* ui/cocoa: Make "open docs" help menu entry work again when binary
27
is run from the build tree
28
* ui/cocoa: Fix openFile: deprecation on Big Sur
29
* docs: Add qemu-storage-daemon(1) manpage to meson.build
23
30
24
----------------------------------------------------------------
31
----------------------------------------------------------------
25
Richard Henderson (2):
32
Hao Wu (6):
26
target/arm: PTE bit GP only applies to stage1
33
hw/misc: Add clock converter in NPCM7XX CLK module
27
target/arm: Copy guarded bit in combine_cacheattrs
34
hw/timer: Refactor NPCM7XX Timer to use CLK clock
35
hw/adc: Add an ADC module for NPCM7XX
36
hw/misc: Add a PWM module for NPCM7XX
37
hw/misc: Add QTest for NPCM7XX PWM Module
38
hw/*: Use type casting for SysBusDevice in NPCM7XX
28
39
29
target/arm/ptw.c | 11 ++++++-----
40
Leif Lindholm (6):
30
1 file changed, 6 insertions(+), 5 deletions(-)
41
target/arm: fix typo in cpu.h ID_AA64PFR1 field name
42
target/arm: make ARMCPU.clidr 64-bit
43
target/arm: make ARMCPU.ctr 64-bit
44
target/arm: add descriptions of CLIDR_EL1, CCSIDR_EL1, CTR_EL0 to cpu.h
45
target/arm: add aarch64 ID register fields to cpu.h
46
target/arm: add aarch32 ID register fields to cpu.h
47
48
Peter Maydell (4):
49
docs: Add qemu-storage-daemon(1) manpage to meson.build
50
target/arm: Don't decode insns in the XScale/iWMMXt space as cp insns
51
hw/net/lan9118: Fix RX Status FIFO PEEK value
52
hw/net/lan9118: Add symbolic constants for register offsets
53
54
Roman Bolshakov (2):
55
ui/cocoa: Update path to docs in build tree
56
ui/cocoa: Fix openFile: deprecation on Big Sur
57
58
Rémi Denis-Courmont (2):
59
target/arm: ARMv8.4-TTST extension
60
target/arm: enable Small Translation tables in max CPU
61
62
docs/meson.build | 1 +
63
docs/system/arm/nuvoton.rst | 4 +-
64
meson.build | 1 +
65
hw/adc/trace.h | 1 +
66
include/hw/adc/npcm7xx_adc.h | 69 ++++
67
include/hw/arm/npcm7xx.h | 4 +
68
include/hw/misc/npcm7xx_clk.h | 146 ++++++-
69
include/hw/misc/npcm7xx_pwm.h | 105 +++++
70
include/hw/timer/npcm7xx_timer.h | 1 +
71
target/arm/cpu.h | 85 ++++-
72
hw/adc/npcm7xx_adc.c | 301 +++++++++++++++
73
hw/arm/npcm7xx.c | 55 ++-
74
hw/arm/npcm7xx_boards.c | 2 +-
75
hw/mem/npcm7xx_mc.c | 2 +-
76
hw/misc/npcm7xx_clk.c | 807 ++++++++++++++++++++++++++++++++++++++-
77
hw/misc/npcm7xx_gcr.c | 2 +-
78
hw/misc/npcm7xx_pwm.c | 550 ++++++++++++++++++++++++++
79
hw/misc/npcm7xx_rng.c | 2 +-
80
hw/net/lan9118.c | 26 +-
81
hw/nvram/npcm7xx_otp.c | 2 +-
82
hw/ssi/npcm7xx_fiu.c | 2 +-
83
hw/timer/npcm7xx_timer.c | 39 +-
84
target/arm/cpu64.c | 1 +
85
target/arm/helper.c | 15 +-
86
target/arm/translate.c | 7 +
87
tests/qtest/npcm7xx_adc-test.c | 377 ++++++++++++++++++
88
tests/qtest/npcm7xx_pwm-test.c | 490 ++++++++++++++++++++++++
89
hw/adc/meson.build | 1 +
90
hw/adc/trace-events | 5 +
91
hw/misc/meson.build | 1 +
92
hw/misc/trace-events | 6 +
93
tests/qtest/meson.build | 4 +-
94
ui/cocoa.m | 7 +-
95
33 files changed, 3054 insertions(+), 67 deletions(-)
96
create mode 100644 hw/adc/trace.h
97
create mode 100644 include/hw/adc/npcm7xx_adc.h
98
create mode 100644 include/hw/misc/npcm7xx_pwm.h
99
create mode 100644 hw/adc/npcm7xx_adc.c
100
create mode 100644 hw/misc/npcm7xx_pwm.c
101
create mode 100644 tests/qtest/npcm7xx_adc-test.c
102
create mode 100644 tests/qtest/npcm7xx_pwm-test.c
103
create mode 100644 hw/adc/trace-events
104
diff view generated by jsdifflib
Deleted patch
1
From: Richard Henderson <richard.henderson@linaro.org>
2
1
3
Only perform the extract of GP during the stage1 walk.
4
5
Reported-by: Peter Maydell <peter.maydell@linaro.org>
6
Signed-off-by: Richard Henderson <richard.henderson@linaro.org>
7
Reviewed-by: Peter Maydell <peter.maydell@linaro.org>
8
Message-id: 20230407185149.3253946-2-richard.henderson@linaro.org
9
Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
10
---
11
target/arm/ptw.c | 10 +++++-----
12
1 file changed, 5 insertions(+), 5 deletions(-)
13
14
diff --git a/target/arm/ptw.c b/target/arm/ptw.c
15
index XXXXXXX..XXXXXXX 100644
16
--- a/target/arm/ptw.c
17
+++ b/target/arm/ptw.c
18
@@ -XXX,XX +XXX,XX @@ static bool get_phys_addr_lpae(CPUARMState *env, S1Translate *ptw,
19
result->f.attrs.secure = false;
20
}
21
22
- /* When in aarch64 mode, and BTI is enabled, remember GP in the TLB. */
23
- if (aarch64 && cpu_isar_feature(aa64_bti, cpu)) {
24
- result->f.guarded = extract64(attrs, 50, 1); /* GP */
25
- }
26
-
27
if (regime_is_stage2(mmu_idx)) {
28
result->cacheattrs.is_s2_format = true;
29
result->cacheattrs.attrs = extract32(attrs, 2, 4);
30
@@ -XXX,XX +XXX,XX @@ static bool get_phys_addr_lpae(CPUARMState *env, S1Translate *ptw,
31
assert(attrindx <= 7);
32
result->cacheattrs.is_s2_format = false;
33
result->cacheattrs.attrs = extract64(mair, attrindx * 8, 8);
34
+
35
+ /* When in aarch64 mode, and BTI is enabled, remember GP in the TLB. */
36
+ if (aarch64 && cpu_isar_feature(aa64_bti, cpu)) {
37
+ result->f.guarded = extract64(attrs, 50, 1); /* GP */
38
+ }
39
}
40
41
/*
42
--
43
2.34.1
diff view generated by jsdifflib
Deleted patch
1
From: Richard Henderson <richard.henderson@linaro.org>
2
1
3
The guarded bit comes from the stage1 walk.
4
5
Fixes: Coverity CID 1507929
6
Signed-off-by: Richard Henderson <richard.henderson@linaro.org>
7
Reviewed-by: Peter Maydell <peter.maydell@linaro.org>
8
Message-id: 20230407185149.3253946-3-richard.henderson@linaro.org
9
Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
10
---
11
target/arm/ptw.c | 1 +
12
1 file changed, 1 insertion(+)
13
14
diff --git a/target/arm/ptw.c b/target/arm/ptw.c
15
index XXXXXXX..XXXXXXX 100644
16
--- a/target/arm/ptw.c
17
+++ b/target/arm/ptw.c
18
@@ -XXX,XX +XXX,XX @@ static ARMCacheAttrs combine_cacheattrs(uint64_t hcr,
19
20
assert(!s1.is_s2_format);
21
ret.is_s2_format = false;
22
+ ret.guarded = s1.guarded;
23
24
if (s1.attrs == 0xf0) {
25
tagged = true;
26
--
27
2.34.1
diff view generated by jsdifflib