1 | This bug seemed worth fixing for 8.0 since we need an rc4 anyway: | 1 | v1->v2 changes: dropped the patch adding the new ast2600 |
---|---|---|---|
2 | we were using uninitialized data for the guarded bit when | 2 | board, as it doesn't pass "make check" on 32-bit hosts or |
3 | combining stage 1 and stage 2 attrs. | 3 | low-memory hosts. |
4 | 4 | ||
5 | thanks | 5 | thanks |
6 | -- PMM | 6 | -- PMM |
7 | 7 | ||
8 | The following changes since commit 08dede07030973c1053868bc64de7e10bfa02ad6: | 8 | The following changes since commit 3af78db68176a049e2570822f64604e0692c1447: |
9 | 9 | ||
10 | Merge tag 'pull-ppc-20230409' of https://github.com/legoater/qemu into staging (2023-04-10 11:47:52 +0100) | 10 | Merge remote-tracking branch 'remotes/kevin/tags/for-upstream' into staging (2019-10-15 13:25:05 +0100) |
11 | 11 | ||
12 | are available in the Git repository at: | 12 | are available in the Git repository at: |
13 | 13 | ||
14 | https://git.linaro.org/people/pmaydell/qemu-arm.git tags/pull-target-arm-20230410 | 14 | https://git.linaro.org/people/pmaydell/qemu-arm.git tags/pull-target-arm-20191015 |
15 | 15 | ||
16 | for you to fetch changes up to 8539dc00552e8ea60420856fc1262c8299bc6308: | 16 | for you to fetch changes up to 19845504da1bdee4be7d0fba33da5be9efa4c11b: |
17 | 17 | ||
18 | target/arm: Copy guarded bit in combine_cacheattrs (2023-04-10 14:31:40 +0100) | 18 | hw/misc/bcm2835_mbox: Add trace events (2019-10-15 18:09:05 +0100) |
19 | 19 | ||
20 | ---------------------------------------------------------------- | 20 | ---------------------------------------------------------------- |
21 | target-arm: Fix bug where we weren't initializing | 21 | target-arm queue: |
22 | guarded bit state when combining S1/S2 attrs | 22 | * Add Aspeed AST2600 SoC support (but no new board model yet) |
23 | * aspeed/wdt: Check correct register for clock source | ||
24 | * bcm2835: code cleanups, better logging, trace events | ||
25 | * implement v2.0 of the Arm semihosting specification | ||
26 | * provide new 'transaction-based' ptimer API and use it | ||
27 | for the Arm devices that use ptimers | ||
28 | * ARM: KVM: support more than 256 CPUs | ||
23 | 29 | ||
24 | ---------------------------------------------------------------- | 30 | ---------------------------------------------------------------- |
25 | Richard Henderson (2): | 31 | Amithash Prasad (1): |
26 | target/arm: PTE bit GP only applies to stage1 | 32 | aspeed/wdt: Check correct register for clock source |
27 | target/arm: Copy guarded bit in combine_cacheattrs | 33 | |
28 | 34 | Cédric Le Goater (14): | |
29 | target/arm/ptw.c | 11 ++++++----- | 35 | aspeed/timer: Introduce an object class per SoC |
30 | 1 file changed, 6 insertions(+), 5 deletions(-) | 36 | aspeed/timer: Add support for control register 3 |
37 | aspeed/timer: Add AST2600 support | ||
38 | aspeed/timer: Add support for IRQ status register on the AST2600 | ||
39 | aspeed/sdmc: Introduce an object class per SoC | ||
40 | watchdog/aspeed: Introduce an object class per SoC | ||
41 | aspeed/smc: Introduce segment operations | ||
42 | aspeed/smc: Add AST2600 support | ||
43 | aspeed/i2c: Introduce an object class per SoC | ||
44 | aspeed/i2c: Add AST2600 support | ||
45 | aspeed: Introduce an object class per SoC | ||
46 | aspeed/soc: Add AST2600 support | ||
47 | m25p80: Add support for w25q512jv | ||
48 | aspeed: add support for the Aspeed MII controller of the AST2600 | ||
49 | |||
50 | Eddie James (1): | ||
51 | hw/sd/aspeed_sdhci: New device | ||
52 | |||
53 | Eric Auger (3): | ||
54 | linux headers: update against v5.4-rc1 | ||
55 | intc/arm_gic: Support IRQ injection for more than 256 vpus | ||
56 | ARM: KVM: Check KVM_CAP_ARM_IRQ_LINE_LAYOUT_2 for smp_cpus > 256 | ||
57 | |||
58 | Joel Stanley (5): | ||
59 | hw: aspeed_scu: Add AST2600 support | ||
60 | aspeed/sdmc: Add AST2600 support | ||
61 | hw: wdt_aspeed: Add AST2600 support | ||
62 | aspeed: Parameterise number of MACs | ||
63 | aspeed/soc: Add ASPEED Video stub | ||
64 | |||
65 | Peter Maydell (36): | ||
66 | ptimer: Rename ptimer_init() to ptimer_init_with_bh() | ||
67 | ptimer: Provide new transaction-based API | ||
68 | tests/ptimer-test: Switch to transaction-based ptimer API | ||
69 | hw/timer/arm_timer.c: Switch to transaction-based ptimer API | ||
70 | hw/arm/musicpal.c: Switch to transaction-based ptimer API | ||
71 | hw/timer/allwinner-a10-pit.c: Switch to transaction-based ptimer API | ||
72 | hw/timer/arm_mptimer.c: Switch to transaction-based ptimer API | ||
73 | hw/timer/cmsdk-apb-dualtimer.c: Switch to transaction-based ptimer API | ||
74 | hw/timer/cmsdk-apb-timer.c: Switch to transaction-based ptimer API | ||
75 | hw/timer/digic-timer.c: Switch to transaction-based ptimer API | ||
76 | hw/timer/exynos4210_mct.c: Switch GFRC to transaction-based ptimer API | ||
77 | hw/timer/exynos4210_mct.c: Switch LFRC to transaction-based ptimer API | ||
78 | hw/timer/exynos4210_mct.c: Switch ltick to transaction-based ptimer API | ||
79 | hw/timer/exynos4210_pwm.c: Switch to transaction-based ptimer API | ||
80 | hw/timer/exynos4210_rtc.c: Switch 1Hz ptimer to transaction-based API | ||
81 | hw/timer/exynos4210_rtc.c: Switch main ptimer to transaction-based API | ||
82 | hw/timer/imx_epit.c: Switch to transaction-based ptimer API | ||
83 | hw/timer/imx_gpt.c: Switch to transaction-based ptimer API | ||
84 | hw/timer/mss-timerc: Switch to transaction-based ptimer API | ||
85 | hw/watchdog/cmsdk-apb-watchdog.c: Switch to transaction-based ptimer API | ||
86 | hw/net/lan9118.c: Switch to transaction-based ptimer API | ||
87 | target/arm/arm-semi: Capture errno in softmmu version of set_swi_errno() | ||
88 | target/arm/arm-semi: Always set some kind of errno for failed calls | ||
89 | target/arm/arm-semi: Correct comment about gdb syscall races | ||
90 | target/arm/arm-semi: Make semihosting code hand out its own file descriptors | ||
91 | target/arm/arm-semi: Restrict use of TaskState* | ||
92 | target/arm/arm-semi: Use set_swi_errno() in gdbstub callback functions | ||
93 | target/arm/arm-semi: Factor out implementation of SYS_CLOSE | ||
94 | target/arm/arm-semi: Factor out implementation of SYS_WRITE | ||
95 | target/arm/arm-semi: Factor out implementation of SYS_READ | ||
96 | target/arm/arm-semi: Factor out implementation of SYS_ISTTY | ||
97 | target/arm/arm-semi: Factor out implementation of SYS_SEEK | ||
98 | target/arm/arm-semi: Factor out implementation of SYS_FLEN | ||
99 | target/arm/arm-semi: Implement support for semihosting feature detection | ||
100 | target/arm/arm-semi: Implement SH_EXT_EXIT_EXTENDED extension | ||
101 | target/arm/arm-semi: Implement SH_EXT_STDOUT_STDERR extension | ||
102 | |||
103 | Philippe Mathieu-Daudé (6): | ||
104 | hw/arm/raspi: Use the IEC binary prefix definitions | ||
105 | hw/arm/bcm2835_peripherals: Improve logging | ||
106 | hw/arm/bcm2835_peripherals: Name various address spaces | ||
107 | hw/arm/bcm2835: Rename some definitions | ||
108 | hw/arm/bcm2835: Add various unimplemented peripherals | ||
109 | hw/misc/bcm2835_mbox: Add trace events | ||
110 | |||
111 | Rashmica Gupta (1): | ||
112 | hw/gpio: Add in AST2600 specific implementation | ||
113 | |||
114 | hw/arm/Makefile.objs | 2 +- | ||
115 | hw/sd/Makefile.objs | 1 + | ||
116 | include/hw/arm/aspeed_soc.h | 29 +- | ||
117 | include/hw/arm/bcm2835_peripherals.h | 15 + | ||
118 | include/hw/arm/raspi_platform.h | 24 +- | ||
119 | include/hw/i2c/aspeed_i2c.h | 20 +- | ||
120 | include/hw/misc/aspeed_scu.h | 7 +- | ||
121 | include/hw/misc/aspeed_sdmc.h | 20 +- | ||
122 | include/hw/net/ftgmac100.h | 17 + | ||
123 | include/hw/ptimer.h | 83 ++- | ||
124 | include/hw/sd/aspeed_sdhci.h | 34 ++ | ||
125 | include/hw/ssi/aspeed_smc.h | 4 + | ||
126 | include/hw/timer/aspeed_timer.h | 18 + | ||
127 | include/hw/timer/mss-timer.h | 1 - | ||
128 | include/hw/watchdog/wdt_aspeed.h | 19 +- | ||
129 | include/standard-headers/asm-x86/bootparam.h | 2 + | ||
130 | include/standard-headers/asm-x86/kvm_para.h | 1 + | ||
131 | include/standard-headers/linux/ethtool.h | 24 + | ||
132 | include/standard-headers/linux/pci_regs.h | 19 +- | ||
133 | include/standard-headers/linux/virtio_fs.h | 19 + | ||
134 | include/standard-headers/linux/virtio_ids.h | 2 + | ||
135 | include/standard-headers/linux/virtio_iommu.h | 165 ++++++ | ||
136 | include/standard-headers/linux/virtio_pmem.h | 6 +- | ||
137 | linux-headers/asm-arm/kvm.h | 16 +- | ||
138 | linux-headers/asm-arm/unistd-common.h | 2 + | ||
139 | linux-headers/asm-arm64/kvm.h | 21 +- | ||
140 | linux-headers/asm-generic/mman-common.h | 18 +- | ||
141 | linux-headers/asm-generic/mman.h | 10 +- | ||
142 | linux-headers/asm-generic/unistd.h | 10 +- | ||
143 | linux-headers/asm-mips/mman.h | 3 + | ||
144 | linux-headers/asm-mips/unistd_n32.h | 1 + | ||
145 | linux-headers/asm-mips/unistd_n64.h | 1 + | ||
146 | linux-headers/asm-mips/unistd_o32.h | 1 + | ||
147 | linux-headers/asm-powerpc/mman.h | 6 +- | ||
148 | linux-headers/asm-powerpc/unistd_32.h | 2 + | ||
149 | linux-headers/asm-powerpc/unistd_64.h | 2 + | ||
150 | linux-headers/asm-s390/kvm.h | 6 + | ||
151 | linux-headers/asm-s390/unistd_32.h | 2 + | ||
152 | linux-headers/asm-s390/unistd_64.h | 2 + | ||
153 | linux-headers/asm-x86/kvm.h | 28 +- | ||
154 | linux-headers/asm-x86/unistd.h | 2 +- | ||
155 | linux-headers/asm-x86/unistd_32.h | 2 + | ||
156 | linux-headers/asm-x86/unistd_64.h | 2 + | ||
157 | linux-headers/asm-x86/unistd_x32.h | 2 + | ||
158 | linux-headers/linux/kvm.h | 12 +- | ||
159 | linux-headers/linux/psp-sev.h | 5 +- | ||
160 | linux-headers/linux/vfio.h | 71 ++- | ||
161 | target/arm/kvm_arm.h | 1 + | ||
162 | hw/arm/aspeed.c | 19 +- | ||
163 | hw/arm/aspeed_ast2600.c | 523 +++++++++++++++++++ | ||
164 | hw/arm/aspeed_soc.c | 199 +++++--- | ||
165 | hw/arm/bcm2835_peripherals.c | 38 +- | ||
166 | hw/arm/bcm2836.c | 2 +- | ||
167 | hw/arm/musicpal.c | 16 +- | ||
168 | hw/arm/raspi.c | 4 +- | ||
169 | hw/block/m25p80.c | 1 + | ||
170 | hw/char/bcm2835_aux.c | 5 +- | ||
171 | hw/core/ptimer.c | 154 +++++- | ||
172 | hw/display/bcm2835_fb.c | 2 +- | ||
173 | hw/dma/bcm2835_dma.c | 10 +- | ||
174 | hw/dma/xilinx_axidma.c | 2 +- | ||
175 | hw/gpio/aspeed_gpio.c | 142 +++++- | ||
176 | hw/i2c/aspeed_i2c.c | 106 +++- | ||
177 | hw/intc/arm_gic_kvm.c | 7 +- | ||
178 | hw/intc/bcm2836_control.c | 7 +- | ||
179 | hw/m68k/mcf5206.c | 2 +- | ||
180 | hw/m68k/mcf5208.c | 2 +- | ||
181 | hw/misc/aspeed_scu.c | 194 ++++++- | ||
182 | hw/misc/aspeed_sdmc.c | 250 ++++++--- | ||
183 | hw/misc/bcm2835_mbox.c | 14 +- | ||
184 | hw/misc/bcm2835_property.c | 20 +- | ||
185 | hw/net/fsl_etsec/etsec.c | 2 +- | ||
186 | hw/net/ftgmac100.c | 162 ++++++ | ||
187 | hw/net/lan9118.c | 11 +- | ||
188 | hw/sd/aspeed_sdhci.c | 198 ++++++++ | ||
189 | hw/ssi/aspeed_smc.c | 177 ++++++- | ||
190 | hw/timer/allwinner-a10-pit.c | 12 +- | ||
191 | hw/timer/altera_timer.c | 2 +- | ||
192 | hw/timer/arm_mptimer.c | 18 +- | ||
193 | hw/timer/arm_timer.c | 16 +- | ||
194 | hw/timer/aspeed_timer.c | 213 +++++++- | ||
195 | hw/timer/cmsdk-apb-dualtimer.c | 14 +- | ||
196 | hw/timer/cmsdk-apb-timer.c | 15 +- | ||
197 | hw/timer/digic-timer.c | 16 +- | ||
198 | hw/timer/etraxfs_timer.c | 6 +- | ||
199 | hw/timer/exynos4210_mct.c | 107 +++- | ||
200 | hw/timer/exynos4210_pwm.c | 17 +- | ||
201 | hw/timer/exynos4210_rtc.c | 22 +- | ||
202 | hw/timer/grlib_gptimer.c | 2 +- | ||
203 | hw/timer/imx_epit.c | 32 +- | ||
204 | hw/timer/imx_gpt.c | 21 +- | ||
205 | hw/timer/lm32_timer.c | 2 +- | ||
206 | hw/timer/milkymist-sysctl.c | 4 +- | ||
207 | hw/timer/mss-timer.c | 11 +- | ||
208 | hw/timer/puv3_ost.c | 2 +- | ||
209 | hw/timer/sh_timer.c | 2 +- | ||
210 | hw/timer/slavio_timer.c | 2 +- | ||
211 | hw/timer/xilinx_timer.c | 2 +- | ||
212 | hw/watchdog/cmsdk-apb-watchdog.c | 13 +- | ||
213 | hw/watchdog/wdt_aspeed.c | 153 +++--- | ||
214 | target/arm/arm-semi.c | 707 +++++++++++++++++++++----- | ||
215 | target/arm/cpu.c | 10 +- | ||
216 | target/arm/kvm.c | 22 +- | ||
217 | tests/ptimer-test.c | 106 +++- | ||
218 | hw/misc/trace-events | 6 + | ||
219 | 105 files changed, 3934 insertions(+), 650 deletions(-) | ||
220 | create mode 100644 include/hw/sd/aspeed_sdhci.h | ||
221 | create mode 100644 include/standard-headers/linux/virtio_fs.h | ||
222 | create mode 100644 include/standard-headers/linux/virtio_iommu.h | ||
223 | create mode 100644 hw/arm/aspeed_ast2600.c | ||
224 | create mode 100644 hw/sd/aspeed_sdhci.c | ||
225 | diff view generated by jsdifflib |
Deleted patch | |||
---|---|---|---|
1 | From: Richard Henderson <richard.henderson@linaro.org> | ||
2 | 1 | ||
3 | Only perform the extract of GP during the stage1 walk. | ||
4 | |||
5 | Reported-by: Peter Maydell <peter.maydell@linaro.org> | ||
6 | Signed-off-by: Richard Henderson <richard.henderson@linaro.org> | ||
7 | Reviewed-by: Peter Maydell <peter.maydell@linaro.org> | ||
8 | Message-id: 20230407185149.3253946-2-richard.henderson@linaro.org | ||
9 | Signed-off-by: Peter Maydell <peter.maydell@linaro.org> | ||
10 | --- | ||
11 | target/arm/ptw.c | 10 +++++----- | ||
12 | 1 file changed, 5 insertions(+), 5 deletions(-) | ||
13 | |||
14 | diff --git a/target/arm/ptw.c b/target/arm/ptw.c | ||
15 | index XXXXXXX..XXXXXXX 100644 | ||
16 | --- a/target/arm/ptw.c | ||
17 | +++ b/target/arm/ptw.c | ||
18 | @@ -XXX,XX +XXX,XX @@ static bool get_phys_addr_lpae(CPUARMState *env, S1Translate *ptw, | ||
19 | result->f.attrs.secure = false; | ||
20 | } | ||
21 | |||
22 | - /* When in aarch64 mode, and BTI is enabled, remember GP in the TLB. */ | ||
23 | - if (aarch64 && cpu_isar_feature(aa64_bti, cpu)) { | ||
24 | - result->f.guarded = extract64(attrs, 50, 1); /* GP */ | ||
25 | - } | ||
26 | - | ||
27 | if (regime_is_stage2(mmu_idx)) { | ||
28 | result->cacheattrs.is_s2_format = true; | ||
29 | result->cacheattrs.attrs = extract32(attrs, 2, 4); | ||
30 | @@ -XXX,XX +XXX,XX @@ static bool get_phys_addr_lpae(CPUARMState *env, S1Translate *ptw, | ||
31 | assert(attrindx <= 7); | ||
32 | result->cacheattrs.is_s2_format = false; | ||
33 | result->cacheattrs.attrs = extract64(mair, attrindx * 8, 8); | ||
34 | + | ||
35 | + /* When in aarch64 mode, and BTI is enabled, remember GP in the TLB. */ | ||
36 | + if (aarch64 && cpu_isar_feature(aa64_bti, cpu)) { | ||
37 | + result->f.guarded = extract64(attrs, 50, 1); /* GP */ | ||
38 | + } | ||
39 | } | ||
40 | |||
41 | /* | ||
42 | -- | ||
43 | 2.34.1 | diff view generated by jsdifflib |
Deleted patch | |||
---|---|---|---|
1 | From: Richard Henderson <richard.henderson@linaro.org> | ||
2 | 1 | ||
3 | The guarded bit comes from the stage1 walk. | ||
4 | |||
5 | Fixes: Coverity CID 1507929 | ||
6 | Signed-off-by: Richard Henderson <richard.henderson@linaro.org> | ||
7 | Reviewed-by: Peter Maydell <peter.maydell@linaro.org> | ||
8 | Message-id: 20230407185149.3253946-3-richard.henderson@linaro.org | ||
9 | Signed-off-by: Peter Maydell <peter.maydell@linaro.org> | ||
10 | --- | ||
11 | target/arm/ptw.c | 1 + | ||
12 | 1 file changed, 1 insertion(+) | ||
13 | |||
14 | diff --git a/target/arm/ptw.c b/target/arm/ptw.c | ||
15 | index XXXXXXX..XXXXXXX 100644 | ||
16 | --- a/target/arm/ptw.c | ||
17 | +++ b/target/arm/ptw.c | ||
18 | @@ -XXX,XX +XXX,XX @@ static ARMCacheAttrs combine_cacheattrs(uint64_t hcr, | ||
19 | |||
20 | assert(!s1.is_s2_format); | ||
21 | ret.is_s2_format = false; | ||
22 | + ret.guarded = s1.guarded; | ||
23 | |||
24 | if (s1.attrs == 0xf0) { | ||
25 | tagged = true; | ||
26 | -- | ||
27 | 2.34.1 | diff view generated by jsdifflib |