[v2] tracing: install trace events file only if necessary

[PATCH V2] tracing: install trace events file only if necessary

casantos@redhat.com posted 1 patch 1 year ago

Diff against v1 v3 v4
Download mbox

Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/qemu tags/patchew/20230327173058.199027-1-casantos@redhat.com

Maintainers: Stefan Hajnoczi <stefanha@redhat.com>

There is a newer version of this series

trace/meson.build | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

Expand all Fold all

[PATCH V2] tracing: install trace events file only if necessary

Posted by casantos@redhat.com 1 year ago

From: Carlos Santos <casantos@redhat.com>

It is not useful when configuring with --enable-trace-backends=nop.

Signed-off-by: Carlos Santos <casantos@redhat.com>
---
Changes v1->v2:
  Install based on chosen trace backend, not on chosen emulators.
---
 trace/meson.build | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/trace/meson.build b/trace/meson.build
index 8e80be895c..3d96b4eea0 100644
--- a/trace/meson.build
+++ b/trace/meson.build
@@ -64,7 +64,7 @@ trace_events_all = custom_target('trace-events-all',
                                  input: trace_events_files,
                                  command: [ 'cat', '@INPUT@' ],
                                  capture: true,
-                                 install: true,
+                                 install: get_option('trace_backends') != 'nop'
                                  install_dir: qemu_datadir)
 
 if 'ust' in get_option('trace_backends')
-- 
2.31.1

Re: [PATCH V2] tracing: install trace events file only if necessary

Posted by Daniel P. Berrangé 1 year ago

On Mon, Mar 27, 2023 at 02:30:58PM -0300, casantos@redhat.com wrote:
> From: Carlos Santos <casantos@redhat.com>
> 
> It is not useful when configuring with --enable-trace-backends=nop.
> 
> Signed-off-by: Carlos Santos <casantos@redhat.com>
> ---

Reviewed-by: Daniel P. Berrangé <berrange@redhat.com>


With regards,
Daniel
-- 
|: https://berrange.com      -o-    https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org         -o-            https://fstop138.berrange.com :|
|: https://entangle-photo.org    -o-    https://www.instagram.com/dberrange :|

Re: [PATCH V2] tracing: install trace events file only if necessary

Posted by Carlos Santos 1 year ago

On Mon, Mar 27, 2023 at 2:59 PM Daniel P. Berrangé <berrange@redhat.com> wrote:
>
> On Mon, Mar 27, 2023 at 02:30:58PM -0300, casantos@redhat.com wrote:
> > From: Carlos Santos <casantos@redhat.com>
> >
> > It is not useful when configuring with --enable-trace-backends=nop.
> >
> > Signed-off-by: Carlos Santos <casantos@redhat.com>
> > ---
>
> Reviewed-by: Daniel P. Berrangé <berrange@redhat.com>
>
>
> With regards,
> Daniel
> --
> |: https://berrange.com      -o-    https://www.flickr.com/photos/dberrange :|
> |: https://libvirt.org         -o-            https://fstop138.berrange.com :|
> |: https://entangle-photo.org    -o-    https://www.instagram.com/dberrange :|
>

I updated the patch to fix the array comparison and add a missing comma.

-- 
Carlos Santos
Senior Software Maintenance Engineer
Red Hat
casantos@redhat.com    T: +55-11-3534-6186