On 3/2/23 13:37, Frederic Barrat wrote:
> A short series with some cleanup around user-created PHB. The main
> point is to remove errors seen from the firmware (skiboot) when using
> user-created PHBs, as we were always showing all the default PHBs in
> the device tree, so skiboot tried to probe non-existing devices. The
> first 2 patches allow to only export the user-created PHBs in the
> device tree when 'nodefaults' is used.
> The last 2 are more cosmetic and moving code around where it makes
> more sense.
>
I'm aware of Phil's comments in patch 1 and the solution can probably be improved
on (as with any other solution and code).
Patch 1 is a requirement to the actual fix in patch 2 though, and Phil's comments
applies to more stuff in the current pnv-phb code. Since we can handle design changes
later on while still fixing the bug, I queued all these for 8.0.
Thanks,
Daniel
>
> Frederic Barrat (4):
> pnv_phb4_pec: Keep track of instantiated PHBs
> pnv_phb4_pec: Only export existing PHBs to the device tree
> pnv_phb4_pec: Move pnv_phb4_get_pec() to rightful file
> pnv_phb4_pec: Simplify/align code to parent user-created PHBs
>
> hw/pci-host/pnv_phb.c | 11 +++++-
> hw/pci-host/pnv_phb4_pec.c | 61 +++++++++++++++++++++++++----
> hw/ppc/pnv.c | 70 ++++------------------------------
> include/hw/pci-host/pnv_phb4.h | 3 ++
> include/hw/ppc/pnv.h | 2 +-
> 5 files changed, 76 insertions(+), 71 deletions(-)
>