[v1] block: switch to AIO_WAIT_WHILE_UNLOCKED() where possible

[PATCH 0/6] block: switch to AIO_WAIT_WHILE_UNLOCKED() where possible

Stefan Hajnoczi posted 6 patches 1 year, 1 month ago

Diff against v2
Download series mbox

Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/qemu tags/patchew/20230301205801.2453491-1-stefanha@redhat.com

Maintainers: Kevin Wolf <kwolf@redhat.com>, Hanna Reitz <hreitz@redhat.com>, Stefan Hajnoczi <stefanha@redhat.com>, Fam Zheng <fam@euphon.net>, "Dr. David Alan Gilbert" <dgilbert@redhat.com>, Markus Armbruster <armbru@redhat.com>

There is a newer version of this series

block/block-backend.c | 8 +-------
block/export/export.c | 2 +-
block/graph-lock.c    | 2 +-
block/io.c            | 2 +-
monitor/hmp.c         | 2 +-
monitor/monitor.c     | 4 ++--
6 files changed, 7 insertions(+), 13 deletions(-)

Expand all Fold all

[PATCH 0/6] block: switch to AIO_WAIT_WHILE_UNLOCKED() where possible

Posted by Stefan Hajnoczi 1 year, 1 month ago

AIO_WAIT_WHILE_UNLOCKED() is the future replacement for AIO_WAIT_WHILE(). Most
callers haven't been converted yet because they rely on the AioContext lock. I
looked through the code and found the easy cases that can be converted today.

Stefan Hajnoczi (6):
  block: don't acquire AioContext lock in bdrv_drain_all()
  block: convert blk_exp_close_all_type() to AIO_WAIT_WHILE_UNLOCKED()
  block: convert bdrv_graph_wrlock() to AIO_WAIT_WHILE_UNLOCKED()
  block: convert bdrv_drain_all_begin() to AIO_WAIT_WHILE_UNLOCKED()
  hmp: convert handle_hmp_command() to AIO_WAIT_WHILE_UNLOCKED()
  monitor: convert monitor_cleanup() to AIO_WAIT_WHILE_UNLOCKED()

 block/block-backend.c | 8 +-------
 block/export/export.c | 2 +-
 block/graph-lock.c    | 2 +-
 block/io.c            | 2 +-
 monitor/hmp.c         | 2 +-
 monitor/monitor.c     | 4 ++--
 6 files changed, 7 insertions(+), 13 deletions(-)

-- 
2.39.2

Re: [PATCH 0/6] block: switch to AIO_WAIT_WHILE_UNLOCKED() where possible

Posted by Kevin Wolf 1 year, 1 month ago

Am 01.03.2023 um 21:57 hat Stefan Hajnoczi geschrieben:
> AIO_WAIT_WHILE_UNLOCKED() is the future replacement for AIO_WAIT_WHILE(). Most
> callers haven't been converted yet because they rely on the AioContext lock. I
> looked through the code and found the easy cases that can be converted today.

Reviewed-by: Kevin Wolf <kwolf@redhat.com>