testing/next: docker, avocado, unit,

[PATCH 05/12] gitlab: reduce default verbosity of cirrus run

Posted by Alex Bennée 2 years, 11 months ago

We also truncate the echoing of the test log if we fail. Ideally we
would want the build aretefact to be available to gitlab but so far
how to do this eludes me.

Signed-off-by: Alex Bennée <alex.bennee@linaro.org>
Cc: Daniel P. Berrangé <berrange@redhat.com>
---
 .gitlab-ci.d/cirrus/build.yml | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/.gitlab-ci.d/cirrus/build.yml b/.gitlab-ci.d/cirrus/build.yml
index 7ef6af8d33..6563ff3c7a 100644
--- a/.gitlab-ci.d/cirrus/build.yml
+++ b/.gitlab-ci.d/cirrus/build.yml
@@ -32,6 +32,6 @@ build_task:
     - $MAKE -j$(sysctl -n hw.ncpu)
     - for TARGET in $TEST_TARGETS ;
       do
-        $MAKE -j$(sysctl -n hw.ncpu) $TARGET V=1
-        || { cat meson-logs/testlog.txt; exit 1; } ;
+        $MAKE -j$(sysctl -n hw.ncpu) $TARGET
+        || { tail -n 200 meson-logs/testlog.txt; exit 1; } ;
       done
-- 
2.39.1

Re: [PATCH 05/12] gitlab: reduce default verbosity of cirrus run

Posted by Thomas Huth 2 years, 11 months ago

On 15/02/2023 20.25, Alex Bennée wrote:
> We also truncate the echoing of the test log if we fail. Ideally we
> would want the build aretefact to be available to gitlab but so far
> how to do this eludes me.
> 
> Signed-off-by: Alex Bennée <alex.bennee@linaro.org>
> Cc: Daniel P. Berrangé <berrange@redhat.com>
> ---
>   .gitlab-ci.d/cirrus/build.yml | 4 ++--
>   1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/.gitlab-ci.d/cirrus/build.yml b/.gitlab-ci.d/cirrus/build.yml
> index 7ef6af8d33..6563ff3c7a 100644
> --- a/.gitlab-ci.d/cirrus/build.yml
> +++ b/.gitlab-ci.d/cirrus/build.yml
> @@ -32,6 +32,6 @@ build_task:
>       - $MAKE -j$(sysctl -n hw.ncpu)
>       - for TARGET in $TEST_TARGETS ;
>         do
> -        $MAKE -j$(sysctl -n hw.ncpu) $TARGET V=1
> -        || { cat meson-logs/testlog.txt; exit 1; } ;
> +        $MAKE -j$(sysctl -n hw.ncpu) $TARGET
> +        || { tail -n 200 meson-logs/testlog.txt; exit 1; } ;
>         done

I think it should be OK to publish the artifacts on cirrus-ci.com instead - 
you have to click a little bit more often, but you can still get the 
artifacts there, see:

  https://lore.kernel.org/qemu-devel/20230215142503.90660-1-thuth@redhat.com/

  Thomas

Re: [PATCH 05/12] gitlab: reduce default verbosity of cirrus run

Posted by Alex Bennée 2 years, 11 months ago

Thomas Huth <thuth@redhat.com> writes:

> On 15/02/2023 20.25, Alex Bennée wrote:
>> We also truncate the echoing of the test log if we fail. Ideally we
>> would want the build aretefact to be available to gitlab but so far
>> how to do this eludes me.
>> Signed-off-by: Alex Bennée <alex.bennee@linaro.org>
>> Cc: Daniel P. Berrangé <berrange@redhat.com>
>> ---
>>   .gitlab-ci.d/cirrus/build.yml | 4 ++--
>>   1 file changed, 2 insertions(+), 2 deletions(-)
>> diff --git a/.gitlab-ci.d/cirrus/build.yml
>> b/.gitlab-ci.d/cirrus/build.yml
>> index 7ef6af8d33..6563ff3c7a 100644
>> --- a/.gitlab-ci.d/cirrus/build.yml
>> +++ b/.gitlab-ci.d/cirrus/build.yml
>> @@ -32,6 +32,6 @@ build_task:
>>       - $MAKE -j$(sysctl -n hw.ncpu)
>>       - for TARGET in $TEST_TARGETS ;
>>         do
>> -        $MAKE -j$(sysctl -n hw.ncpu) $TARGET V=1
>> -        || { cat meson-logs/testlog.txt; exit 1; } ;
>> +        $MAKE -j$(sysctl -n hw.ncpu) $TARGET
>> +        || { tail -n 200 meson-logs/testlog.txt; exit 1; } ;
>>         done
>
> I think it should be OK to publish the artifacts on cirrus-ci.com
> instead - you have to click a little bit more often, but you can still
> get the artifacts there, see:
>
>  https://lore.kernel.org/qemu-devel/20230215142503.90660-1-thuth@redhat.com/

But dropping the V=1 also helps by reducing those chatty softfloat
tests. If we could merge that with yours. Are you sending a PR soon or
should I pull your patch into this series?

>
>  Thomas


-- 
Alex Bennée
Virtualisation Tech Lead @ Linaro

Re: [PATCH 05/12] gitlab: reduce default verbosity of cirrus run

Posted by Thomas Huth 2 years, 11 months ago

On 16/02/2023 09.02, Alex Bennée wrote:
> 
> Thomas Huth <thuth@redhat.com> writes:
> 
>> On 15/02/2023 20.25, Alex Bennée wrote:
>>> We also truncate the echoing of the test log if we fail. Ideally we
>>> would want the build aretefact to be available to gitlab but so far
>>> how to do this eludes me.
>>> Signed-off-by: Alex Bennée <alex.bennee@linaro.org>
>>> Cc: Daniel P. Berrangé <berrange@redhat.com>
>>> ---
>>>    .gitlab-ci.d/cirrus/build.yml | 4 ++--
>>>    1 file changed, 2 insertions(+), 2 deletions(-)
>>> diff --git a/.gitlab-ci.d/cirrus/build.yml
>>> b/.gitlab-ci.d/cirrus/build.yml
>>> index 7ef6af8d33..6563ff3c7a 100644
>>> --- a/.gitlab-ci.d/cirrus/build.yml
>>> +++ b/.gitlab-ci.d/cirrus/build.yml
>>> @@ -32,6 +32,6 @@ build_task:
>>>        - $MAKE -j$(sysctl -n hw.ncpu)
>>>        - for TARGET in $TEST_TARGETS ;
>>>          do
>>> -        $MAKE -j$(sysctl -n hw.ncpu) $TARGET V=1
>>> -        || { cat meson-logs/testlog.txt; exit 1; } ;
>>> +        $MAKE -j$(sysctl -n hw.ncpu) $TARGET
>>> +        || { tail -n 200 meson-logs/testlog.txt; exit 1; } ;
>>>          done
>>
>> I think it should be OK to publish the artifacts on cirrus-ci.com
>> instead - you have to click a little bit more often, but you can still
>> get the artifacts there, see:
>>
>>   https://lore.kernel.org/qemu-devel/20230215142503.90660-1-thuth@redhat.com/
> 
> But dropping the V=1 also helps by reducing those chatty softfloat
> tests. If we could merge that with yours. Are you sending a PR soon or
> should I pull your patch into this series?

I'm not planning a new pull request in the next few days, so feel free to 
pick my patch up or simply ignore it.

Anyway, the V=1 has just been added a little bit more than 2 years ago to 
address a different problem:

  https://gitlab.com/qemu-project/qemu/-/commit/2a5a79d1b57280edd

I'm fine with dropping the V=1 again, but it still feels like we're going 
around in circles here.

  Thomas