[v2] Dynamycally switch to vhost shadow virtqueues at vdpa net migration

[PATCH v2 13/13] vdpa: return VHOST_F_LOG_ALL in vhost-vdpa devices

Posted by Eugenio Pérez 3 years ago

vhost-vdpa devices can return this features now that blockers have been
set in case some features are not met.

Expose VHOST_F_LOG_ALL only in that case.

Signed-off-by: Eugenio Pérez <eperezma@redhat.com>
---
 hw/virtio/vhost-vdpa.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/hw/virtio/vhost-vdpa.c b/hw/virtio/vhost-vdpa.c
index 13a86a2bb1..5fddc77c5c 100644
--- a/hw/virtio/vhost-vdpa.c
+++ b/hw/virtio/vhost-vdpa.c
@@ -1319,10 +1319,9 @@ static int vhost_vdpa_set_vring_call(struct vhost_dev *dev,
 static int vhost_vdpa_get_features(struct vhost_dev *dev,
                                      uint64_t *features)
 {
-    struct vhost_vdpa *v = dev->opaque;
     int ret = vhost_vdpa_get_dev_features(dev, features);
 
-    if (ret == 0 && v->shadow_vqs_enabled) {
+    if (ret == 0) {
         /* Add SVQ logging capabilities */
         *features |= BIT_ULL(VHOST_F_LOG_ALL);
     }
-- 
2.31.1

Re: [PATCH v2 13/13] vdpa: return VHOST_F_LOG_ALL in vhost-vdpa devices

Posted by Jason Wang 2 years, 11 months ago

在 2023/2/8 17:42, Eugenio Pérez 写道:
> vhost-vdpa devices can return this features now that blockers have been
> set in case some features are not met.
>
> Expose VHOST_F_LOG_ALL only in that case.
>
> Signed-off-by: Eugenio Pérez <eperezma@redhat.com>
> ---


Acked-by: Jason Wang <jasowang@redhat.com>

Thanks


>   hw/virtio/vhost-vdpa.c | 3 +--
>   1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/hw/virtio/vhost-vdpa.c b/hw/virtio/vhost-vdpa.c
> index 13a86a2bb1..5fddc77c5c 100644
> --- a/hw/virtio/vhost-vdpa.c
> +++ b/hw/virtio/vhost-vdpa.c
> @@ -1319,10 +1319,9 @@ static int vhost_vdpa_set_vring_call(struct vhost_dev *dev,
>   static int vhost_vdpa_get_features(struct vhost_dev *dev,
>                                        uint64_t *features)
>   {
> -    struct vhost_vdpa *v = dev->opaque;
>       int ret = vhost_vdpa_get_dev_features(dev, features);
>   
> -    if (ret == 0 && v->shadow_vqs_enabled) {
> +    if (ret == 0) {
>           /* Add SVQ logging capabilities */
>           *features |= BIT_ULL(VHOST_F_LOG_ALL);
>       }