[v1] qtests vs. default devices

[PATCH 01/12] tests/qtest: Skip PXE tests for missing devices

Fabiano Rosas posted 12 patches 3 years ago

Diff against v2 v3
Download mbox

Maintainers: Kevin Wolf <kwolf@redhat.com>, Hanna Reitz <hreitz@redhat.com>, "Michael S. Tsirkin" <mst@redhat.com>, Igor Mammedov <imammedo@redhat.com>, Ani Sinha <ani@anisinha.ca>, Thomas Huth <thuth@redhat.com>, Laurent Vivier <lvivier@redhat.com>, Paolo Bonzini <pbonzini@redhat.com>, Alexander Bulekov <alxndr@bu.edu>, Bandan Das <bsd@redhat.com>, Stefan Hajnoczi <stefanha@redhat.com>, Darren Kenny <darren.kenny@oracle.com>, Qiuhao Li <Qiuhao.Li@outlook.com>, Fam Zheng <fam@euphon.net>, Su Hang <suhang16@mails.ucas.ac.cn>, Amit Shah <amit@kernel.org>

There is a newer version of this series

Expand all Fold all

[PATCH 01/12] tests/qtest: Skip PXE tests for missing devices

Posted by Fabiano Rosas 3 years ago

Check if the devices we're trying to add are present in the QEMU
binary. They could have been removed from the build via Kconfig or the
--without-default-devices option.

Signed-off-by: Fabiano Rosas <farosas@suse.de>
---
 tests/qtest/pxe-test.c | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/tests/qtest/pxe-test.c b/tests/qtest/pxe-test.c
index 52f0b5c67c..62b6eef464 100644
--- a/tests/qtest/pxe-test.c
+++ b/tests/qtest/pxe-test.c
@@ -108,6 +108,10 @@ static void test_batch(const testdef_t *tests, bool ipv6)
         const testdef_t *test = &tests[i];
         char *testname;
 
+        if (!qtest_has_device(test->model)) {
+            continue;
+        }
+
         testname = g_strdup_printf("pxe/ipv4/%s/%s",
                                    test->machine, test->model);
         qtest_add_data_func(testname, test, test_pxe_ipv4);
-- 
2.35.3

Re: [PATCH 01/12] tests/qtest: Skip PXE tests for missing devices

Posted by Thomas Huth 3 years ago

On 06/02/2023 16.04, Fabiano Rosas wrote:
> Check if the devices we're trying to add are present in the QEMU
> binary. They could have been removed from the build via Kconfig or the
> --without-default-devices option.
> 
> Signed-off-by: Fabiano Rosas <farosas@suse.de>
> ---
>   tests/qtest/pxe-test.c | 4 ++++
>   1 file changed, 4 insertions(+)
> 
> diff --git a/tests/qtest/pxe-test.c b/tests/qtest/pxe-test.c
> index 52f0b5c67c..62b6eef464 100644
> --- a/tests/qtest/pxe-test.c
> +++ b/tests/qtest/pxe-test.c
> @@ -108,6 +108,10 @@ static void test_batch(const testdef_t *tests, bool ipv6)
>           const testdef_t *test = &tests[i];
>           char *testname;
>   
> +        if (!qtest_has_device(test->model)) {
> +            continue;
> +        }

Reviewed-by: Thomas Huth <thuth@redhat.com>