[v1] Vhost-user: replace _SLAVE_ with _BACKEND_

[PATCH 0/3] Vhost-user: replace _SLAVE_ with _BACKEND_

Posted by Maxime Coquelin 1 year, 2 months ago

This series continues the work done to get rid of harmful
language in the Vhost-user specification.

While the spec texts were changed to replace slave with
backend, the protocol features and messages names hadn't
been changed. 

This series renames remaining occurences in the spec and
make use of the new names in both libvhost-user and the
Vhost-user frontend code.

Maxime Coquelin (3):
  docs: vhost-user: replace _SLAVE_ with _BACKEND_
  libvhost-user: Adopt new backend naming
  vhost-user: Adopt new backend naming

 docs/interop/vhost-user.rst               | 40 +++++++++++------------
 hw/virtio/vhost-user.c                    | 30 ++++++++---------
 hw/virtio/virtio-qmp.c                    | 12 +++----
 subprojects/libvhost-user/libvhost-user.c | 20 ++++++------
 subprojects/libvhost-user/libvhost-user.h | 20 ++++++------
 5 files changed, 61 insertions(+), 61 deletions(-)

-- 
2.39.1

Re: [PATCH 0/3] Vhost-user: replace _SLAVE_ with _BACKEND_

Posted by Stephen Hemminger via 1 year, 2 months ago

On Mon, 30 Jan 2023 11:45:45 +0100
Maxime Coquelin <maxime.coquelin@redhat.com> wrote:

> This series continues the work done to get rid of harmful
> language in the Vhost-user specification.
> 
> While the spec texts were changed to replace slave with
> backend, the protocol features and messages names hadn't
> been changed. 
> 
> This series renames remaining occurences in the spec and
> make use of the new names in both libvhost-user and the
> Vhost-user frontend code.
> 
> Maxime Coquelin (3):
>   docs: vhost-user: replace _SLAVE_ with _BACKEND_
>   libvhost-user: Adopt new backend naming
>   vhost-user: Adopt new backend naming
> 
>  docs/interop/vhost-user.rst               | 40 +++++++++++------------
>  hw/virtio/vhost-user.c                    | 30 ++++++++---------
>  hw/virtio/virtio-qmp.c                    | 12 +++----
>  subprojects/libvhost-user/libvhost-user.c | 20 ++++++------
>  subprojects/libvhost-user/libvhost-user.h | 20 ++++++------
>  5 files changed, 61 insertions(+), 61 deletions(-)
> 

Thanks for doing this. LGTM

Re: [PATCH 0/3] Vhost-user: replace _SLAVE_ with _BACKEND_

Posted by Michael S. Tsirkin 1 year, 2 months ago

On Mon, Jan 30, 2023 at 11:45:45AM +0100, Maxime Coquelin wrote:
> This series continues the work done to get rid of harmful
> language in the Vhost-user specification.

I prefer a positive "switch to a more inclusive terminology".
To consider if you keep doing this work.

> While the spec texts were changed to replace slave with
> backend, the protocol features and messages names hadn't
> been changed. 
> 
> This series renames remaining occurences in the spec and
> make use of the new names in both libvhost-user and the
> Vhost-user frontend code.
> 
> Maxime Coquelin (3):
>   docs: vhost-user: replace _SLAVE_ with _BACKEND_
>   libvhost-user: Adopt new backend naming
>   vhost-user: Adopt new backend naming
> 
>  docs/interop/vhost-user.rst               | 40 +++++++++++------------
>  hw/virtio/vhost-user.c                    | 30 ++++++++---------
>  hw/virtio/virtio-qmp.c                    | 12 +++----
>  subprojects/libvhost-user/libvhost-user.c | 20 ++++++------
>  subprojects/libvhost-user/libvhost-user.h | 20 ++++++------
>  5 files changed, 61 insertions(+), 61 deletions(-)
> 
> -- 
> 2.39.1

Re: [PATCH 0/3] Vhost-user: replace _SLAVE_ with _BACKEND_

Posted by Maxime Coquelin 1 year, 2 months ago


On 1/30/23 12:08, Michael S. Tsirkin wrote:
> On Mon, Jan 30, 2023 at 11:45:45AM +0100, Maxime Coquelin wrote:
>> This series continues the work done to get rid of harmful
>> language in the Vhost-user specification.
> 
> I prefer a positive "switch to a more inclusive terminology".
> To consider if you keep doing this work.

Right, it is indeed better. I will post a new revision using positive
wording.


Thanks for the review,
Maxime

>> While the spec texts were changed to replace slave with
>> backend, the protocol features and messages names hadn't
>> been changed.
>>
>> This series renames remaining occurences in the spec and
>> make use of the new names in both libvhost-user and the
>> Vhost-user frontend code.
>>
>> Maxime Coquelin (3):
>>    docs: vhost-user: replace _SLAVE_ with _BACKEND_
>>    libvhost-user: Adopt new backend naming
>>    vhost-user: Adopt new backend naming
>>
>>   docs/interop/vhost-user.rst               | 40 +++++++++++------------
>>   hw/virtio/vhost-user.c                    | 30 ++++++++---------
>>   hw/virtio/virtio-qmp.c                    | 12 +++----
>>   subprojects/libvhost-user/libvhost-user.c | 20 ++++++------
>>   subprojects/libvhost-user/libvhost-user.h | 20 ++++++------
>>   5 files changed, 61 insertions(+), 61 deletions(-)
>>
>> -- 
>> 2.39.1
>