[RFC PATCH v4 12/15] tests/tcg: Do not build/run TCG tests if TCG is disabled

Fabiano Rosas posted 15 patches 3 years ago
There is a newer version of this series
[RFC PATCH v4 12/15] tests/tcg: Do not build/run TCG tests if TCG is disabled
Posted by Fabiano Rosas 3 years ago
The tests under tests/tcg depend on the TCG accelerator. Do not build
them if --disable-tcg was given in the configure line.

Signed-off-by: Fabiano Rosas <farosas@suse.de>
---
 configure | 6 +++++-
 1 file changed, 5 insertions(+), 1 deletion(-)

diff --git a/configure b/configure
index 9e407ce2e3..64960c6000 100755
--- a/configure
+++ b/configure
@@ -2483,7 +2483,11 @@ for target in $target_list; do
       tcg_tests_targets="$tcg_tests_targets $target"
   fi
 done
-echo "TCG_TESTS_TARGETS=$tcg_tests_targets" >> config-host.mak)
+
+if test "$tcg" = "enabled"; then
+    echo "TCG_TESTS_TARGETS=$tcg_tests_targets" >> config-host.mak
+fi
+)
 
 if test "$skip_meson" = no; then
   cross="config-meson.cross.new"
-- 
2.35.3
Re: [RFC PATCH v4 12/15] tests/tcg: Do not build/run TCG tests if TCG is disabled
Posted by Philippe Mathieu-Daudé 3 years ago
On 19/1/23 14:54, Fabiano Rosas wrote:
> The tests under tests/tcg depend on the TCG accelerator. Do not build
> them if --disable-tcg was given in the configure line.
> 
> Signed-off-by: Fabiano Rosas <farosas@suse.de>
> ---
>   configure | 6 +++++-
>   1 file changed, 5 insertions(+), 1 deletion(-)

Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>


Re: [RFC PATCH v4 12/15] tests/tcg: Do not build/run TCG tests if TCG is disabled
Posted by Richard Henderson 3 years ago
On 1/19/23 03:54, Fabiano Rosas wrote:
> The tests under tests/tcg depend on the TCG accelerator. Do not build
> them if --disable-tcg was given in the configure line.
> 
> Signed-off-by: Fabiano Rosas <farosas@suse.de>
> ---
>   configure | 6 +++++-
>   1 file changed, 5 insertions(+), 1 deletion(-)

Amusing that this wasn't found earlier.  But it does in fact give nonsense results for 
--disable-tcg on x86_64 host as well.

Reviewed-by: Richard Henderson <richard.henderson@linaro.org>


r~