hw/arm: Move various objects to softmmu_ss to build them once (part 1)

[PATCH 03/18] target/arm/cpregs: Include missing 'target/arm/cpu.h' header

Philippe Mathieu-Daudé posted 18 patches 3 years ago

Download mbox

Maintainers: Beniamino Galvani <b.galvani@gmail.com>, Peter Maydell <peter.maydell@linaro.org>, Niek Linnenbank <nieklinnenbank@gmail.com>, Antony Pavlov <antonynpavlov@gmail.com>, Jean-Christophe Dubois <jcd@tribudubois.net>, Andrey Smirnov <andrew.smirnov@gmail.com>, "Philippe Mathieu-Daudé" <philmd@linaro.org>, Rob Herring <robh@kernel.org>, Jan Kiszka <jan.kiszka@web.de>

Expand all Fold all

[PATCH 03/18] target/arm/cpregs: Include missing 'target/arm/cpu.h' header

Posted by Philippe Mathieu-Daudé 3 years ago

CPReadFn type definitions use the CPUARMState type, itself
declared in "target/arm/cpu.h". Include this file in order
to avoid when refactoring headers:

  ../target/arm/cpregs.h:241:27: error: unknown type name 'CPUARMState'
  typedef uint64_t CPReadFn(CPUARMState *env, const ARMCPRegInfo *opaque);
                            ^

Signed-off-by: Philippe Mathieu-Daudé <philmd@linaro.org>
---
 target/arm/cpregs.h | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/target/arm/cpregs.h b/target/arm/cpregs.h
index 7e78c2c05c..63b645907e 100644
--- a/target/arm/cpregs.h
+++ b/target/arm/cpregs.h
@@ -21,6 +21,8 @@
 #ifndef TARGET_ARM_CPREGS_H
 #define TARGET_ARM_CPREGS_H
 
+#include "target/arm/cpu.h"
+
 /*
  * ARMCPRegInfo type field bits:
  */
-- 
2.38.1

Re: [PATCH 03/18] target/arm/cpregs: Include missing 'target/arm/cpu.h' header

Posted by Richard Henderson 3 years ago

On 1/10/23 08:43, Philippe Mathieu-Daudé wrote:
> +#include "target/arm/cpu.h"

Just "cpu.h" in this file.

Otherwise,
Reviewed-by: Richard Henderson <richard.henderson@linaro.org>

r~