hw/arm: Move various objects to softmmu_ss to build them once (part 1)

[PATCH 11/18] hw/arm/digic: Remove unnecessary target_long use

Posted by Philippe Mathieu-Daudé 3 years ago

load_image_targphys(), declared in "hw/loader.h", returns a ssize_t.

Remove the 'target_long' type which size changes per target.

Signed-off-by: Philippe Mathieu-Daudé <philmd@linaro.org>
---
 hw/arm/digic_boards.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/hw/arm/digic_boards.c b/hw/arm/digic_boards.c
index 4093af09cb..529d44e4e7 100644
--- a/hw/arm/digic_boards.c
+++ b/hw/arm/digic_boards.c
@@ -80,7 +80,7 @@ static void digic4_board_init(MachineState *machine, DigicBoard *board)
 static void digic_load_rom(DigicState *s, hwaddr addr,
                            hwaddr max_size, const char *filename)
 {
-    target_long rom_size;
+    ssize_t rom_size;
 
     if (qtest_enabled()) {
         /* qtest runs no code so don't attempt a ROM load which
-- 
2.38.1

Re: [PATCH 11/18] hw/arm/digic: Remove unnecessary target_long use

Posted by Richard Henderson 3 years ago

On 1/10/23 08:43, Philippe Mathieu-Daudé wrote:
> load_image_targphys(), declared in "hw/loader.h", returns a ssize_t.
> 
> Remove the 'target_long' type which size changes per target.
> 
> Signed-off-by: Philippe Mathieu-Daudé<philmd@linaro.org>
> ---
>   hw/arm/digic_boards.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)

Reviewed-by: Richard Henderson <richard.henderson@linaro.org>

r~