python/qemu/machine/machine.py | 6 +++--- tests/avocado/avocado_qemu/__init__.py | 2 +- 2 files changed, 4 insertions(+), 4 deletions(-)
v1: https://lore.kernel.org/qemu-devel/20220705214659.73369-1-peter@pjd.dev/ v2: https://lore.kernel.org/qemu-devel/20220716173434.17183-1-peter@pjd.dev/ v3: - Changed QEMUMachine._name to f"{id(self):x}". Suggestion was to do f"{id(self):02x}", but the id's look like they are probably just the object address (8-byte pointer), so the "02" had no effect. - Changed QMP socket name suffix from "-monitor.sock" to ".qmp". - Changed console socket name suffix from "-console.sock" to ".con". v4: - Just resending v3 after rebasing from a long time ago v5: - I forgot to disable the VPN on my laptop before sending the v4 series, and I always have very mysterious errors and/or delays when I send email through the VPN because our security team doesn't allow split tunneling. - I also forgot to include the reviewed-by tags. Daniel reviewed v3, Phil reviewed v4. I tried to run `make check-avocado` before sending again, but it looks like there is some other issue. Probably related to the python version I have (I have like 5 different Python versions installed on my work laptop). Thanks, Peter $ make check-avocado changing dir to build for /Library/Developer/CommandLineTools/usr/bin/make "check-avocado"... GIT ui/keycodemapdb tests/fp/berkeley-testfloat-3 tests/fp/berkeley-softfloat-3 dtc VENV /Users/pdel/qemu/build/tests/venv VENVPIP install -e /Users/pdel/qemu/python/ VENVPIP install -r /Users/pdel/qemu/tests/requirements.txt MKDIR /Users/pdel/qemu/build/tests/results AVOCADO Downloading avocado tests VM image for aarch64 The image was downloaded: Provider Version Architecture File fedora 31 aarch64 /Users/pdel/avocado/data/cache/by_location/4f156e531446a679cbfe13caef8b7c9f9f79aafa/Fedora-C loud-Base-31-1.9.aarch64.qcow2 AVOCADO tests/avocado Fetching asset from tests/avocado/boot_linux_console.py:BootLinuxConsole.test_aarch64_raspi3_atf Fetching asset from tests/avocado/boot_xen.py:BootXen.test_arm64_xen_411_and_dom0 Fetching asset from tests/avocado/boot_xen.py:BootXen.test_arm64_xen_414_and_dom0 Fetching asset from tests/avocado/boot_xen.py:BootXen.test_arm64_xen_415_and_dom0 Fetching asset from tests/avocado/machine_aarch64_virt.py:Aarch64VirtMachine.test_alpine_virt_tcg_gic_max Fetching asset from tests/avocado/machine_aarch64_virt.py:Aarch64VirtMachine.test_aarch64_virt Fetching asset from tests/avocado/replay_kernel.py:ReplayKernelNormal.test_aarch64_virt Fetching asset from tests/avocado/reverse_debugging.py:ReverseDebugging_AArch64.test_aarch64_virt JOB ID : 18a949ed9150e22d6ecea69b99ede1ded17233f4 JOB LOG : /Users/pdel/qemu/build/tests/results/job-2023-01-10T00.03-18a949e/job.log Avocado crashed: TypeError: cannot pickle '_thread.RLock' object Peter Delevoryas (1): python/machine: Fix AF_UNIX path too long on macOS python/qemu/machine/machine.py | 6 +++--- tests/avocado/avocado_qemu/__init__.py | 2 +- 2 files changed, 4 insertions(+), 4 deletions(-) -- 2.39.0
On 10/1/23 09:29, Peter Delevoryas wrote: > $ make check-avocado > Avocado crashed: TypeError: cannot pickle '_thread.RLock' object Yeah... you have to pick Cleber's patches from https://gitlab.com/cleber.gnu/qemu/-/commits/WIP/tests_fixes and run as: $ TMPDIR=/tmp avocado run --test-runner=nrunner ... This is tracked on the avocado project: https://github.com/avocado-framework/avocado/issues/5138#issuecomment-1314551148
On Tue, Jan 10, 2023 at 09:38:38AM +0100, Philippe Mathieu-Daudé wrote: > On 10/1/23 09:29, Peter Delevoryas wrote: > > > $ make check-avocado > > > Avocado crashed: TypeError: cannot pickle '_thread.RLock' object > > Yeah... you have to pick Cleber's patches from > https://gitlab.com/cleber.gnu/qemu/-/commits/WIP/tests_fixes > and run as: > > $ TMPDIR=/tmp avocado run --test-runner=nrunner ... I guess I still get this error from `make check-avocado` on Aarch64 tests: (17/35) tests/avocado/replay_linux.py:ReplayLinuxAarch64.test_virt_gicv2: ERROR: Failed to fetch Fedora-Cloud-Base-31-1.9 .aarch64.qcow2 (Can't pickle local object 'url_download.<locals>.download'). (0.89 s) But `./build/tests/venv/bin/avocado run tests/avocado` worked ok. > > This is tracked on the avocado project: > https://github.com/avocado-framework/avocado/issues/5138#issuecomment-1314551148 Thanks! - Peter >
© 2016 - 2024 Red Hat, Inc.