Various win32 fixes & new 'get-win32-socket' QMP command

[PATCH 10/10] qtest: enable vnc-display test on win32

marcandre.lureau@redhat.com posted 10 patches 3 years, 1 month ago

Download mbox

Maintainers: Gerd Hoffmann <kraxel@redhat.com>, "Daniel P. Berrangé" <berrange@redhat.com>, Markus Armbruster <armbru@redhat.com>, "Dr. David Alan Gilbert" <dgilbert@redhat.com>, Eric Blake <eblake@redhat.com>, "Alex Bennée" <alex.bennee@linaro.org>, "Philippe Mathieu-Daudé" <philmd@linaro.org>, Thomas Huth <thuth@redhat.com>, Wainer dos Santos Moschetta <wainersm@redhat.com>, Beraldo Leal <bleal@redhat.com>, Laurent Vivier <lvivier@redhat.com>, Paolo Bonzini <pbonzini@redhat.com>, Stefan Weil <sw@weilnetz.de>

Expand all Fold all

[PATCH 10/10] qtest: enable vnc-display test on win32

Posted by marcandre.lureau@redhat.com 3 years, 1 month ago

From: Marc-André Lureau <marcandre.lureau@redhat.com>

Now that qtest_qmp_add_client() works on win32, we can enable the VNC
test.

Signed-off-by: Marc-André Lureau <marcandre.lureau@redhat.com>
---
 tests/qtest/vnc-display-test.c | 5 -----
 1 file changed, 5 deletions(-)

diff --git a/tests/qtest/vnc-display-test.c b/tests/qtest/vnc-display-test.c
index e2a9d682bb..2997edc6ec 100644
--- a/tests/qtest/vnc-display-test.c
+++ b/tests/qtest/vnc-display-test.c
@@ -34,10 +34,6 @@ static void on_vnc_auth_failure(VncConnection *self,
 static bool
 test_setup(Test *test)
 {
-#ifdef WIN32
-    g_test_skip("Not supported on Windows yet");
-    return false;
-#else
     int pair[2];
 
     test->qts = qtest_init("-vnc none -name vnc-test");
@@ -56,7 +52,6 @@ test_setup(Test *test)
 
     test->loop = g_main_loop_new(NULL, FALSE);
     return true;
-#endif
 }
 
 static void
-- 
2.39.0

Re: [PATCH 10/10] qtest: enable vnc-display test on win32

Posted by Thomas Huth 3 years, 1 month ago

On 03/01/2023 12.08, marcandre.lureau@redhat.com wrote:
> From: Marc-André Lureau <marcandre.lureau@redhat.com>
> 
> Now that qtest_qmp_add_client() works on win32, we can enable the VNC
> test.
> 
> Signed-off-by: Marc-André Lureau <marcandre.lureau@redhat.com>
> ---
>   tests/qtest/vnc-display-test.c | 5 -----
>   1 file changed, 5 deletions(-)
> 
> diff --git a/tests/qtest/vnc-display-test.c b/tests/qtest/vnc-display-test.c
> index e2a9d682bb..2997edc6ec 100644
> --- a/tests/qtest/vnc-display-test.c
> +++ b/tests/qtest/vnc-display-test.c
> @@ -34,10 +34,6 @@ static void on_vnc_auth_failure(VncConnection *self,
>   static bool
>   test_setup(Test *test)
>   {
> -#ifdef WIN32
> -    g_test_skip("Not supported on Windows yet");
> -    return false;
> -#else
>       int pair[2];
>   
>       test->qts = qtest_init("-vnc none -name vnc-test");
> @@ -56,7 +52,6 @@ test_setup(Test *test)
>   
>       test->loop = g_main_loop_new(NULL, FALSE);
>       return true;
> -#endif
>   }
>   
>   static void

Acked-by: Thomas Huth <thuth@redhat.com>