net: Increase L2TPv3 buffer to fit jumboframes

[PATCH] net: Increase L2TPv3 buffer to fit jumboframes

Posted by Christian Svensson 2 years, 8 months ago

Increase the allocated buffer size to fit larger packets.
Given that jumboframes can commonly be up to 9000 bytes the closest suitable
value seems to be 16 KiB.

Tested by running qemu towards a Linux L2TPv3 endpoint and pushing
jumboframe traffic through the interfaces.

Signed-off-by: Christian Svensson <blue@cmd.nu>
---
 net/l2tpv3.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/net/l2tpv3.c b/net/l2tpv3.c
index 5852e42738..3d5c6d11d3 100644
--- a/net/l2tpv3.c
+++ b/net/l2tpv3.c
@@ -42,7 +42,7 @@
  */
 
 #define BUFFER_ALIGN sysconf(_SC_PAGESIZE)
-#define BUFFER_SIZE 2048
+#define BUFFER_SIZE 16384
 #define IOVSIZE 2
 #define MAX_L2TPV3_MSGCNT 64
 #define MAX_L2TPV3_IOVCNT (MAX_L2TPV3_MSGCNT * IOVSIZE)
-- 
2.36.2

Re: [PATCH] net: Increase L2TPv3 buffer to fit jumboframes

Posted by Jason Wang 2 years, 8 months ago

On Sat, Dec 31, 2022 at 4:27 AM Christian Svensson <blue@cmd.nu> wrote:
>
> Increase the allocated buffer size to fit larger packets.
> Given that jumboframes can commonly be up to 9000 bytes the closest suitable
> value seems to be 16 KiB.
>
> Tested by running qemu towards a Linux L2TPv3 endpoint and pushing
> jumboframe traffic through the interfaces.
>
> Signed-off-by: Christian Svensson <blue@cmd.nu>

Queued.

Thanks

> ---
>  net/l2tpv3.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/net/l2tpv3.c b/net/l2tpv3.c
> index 5852e42738..3d5c6d11d3 100644
> --- a/net/l2tpv3.c
> +++ b/net/l2tpv3.c
> @@ -42,7 +42,7 @@
>   */
>
>  #define BUFFER_ALIGN sysconf(_SC_PAGESIZE)
> -#define BUFFER_SIZE 2048
> +#define BUFFER_SIZE 16384
>  #define IOVSIZE 2
>  #define MAX_L2TPV3_MSGCNT 64
>  #define MAX_L2TPV3_IOVCNT (MAX_L2TPV3_MSGCNT * IOVSIZE)
> --
> 2.36.2
>

Re: [PATCH] net: Increase L2TPv3 buffer to fit jumboframes

Posted by Christian Svensson 2 years, 8 months ago

+qemu-trivial

On Fri, Dec 30, 2022, 21:27 Christian Svensson <blue@cmd.nu> wrote:

> Increase the allocated buffer size to fit larger packets.
> Given that jumboframes can commonly be up to 9000 bytes the closest
> suitable
> value seems to be 16 KiB.
>
> Tested by running qemu towards a Linux L2TPv3 endpoint and pushing
> jumboframe traffic through the interfaces.
>
> Signed-off-by: Christian Svensson <blue@cmd.nu>
> ---
>  net/l2tpv3.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/net/l2tpv3.c b/net/l2tpv3.c
> index 5852e42738..3d5c6d11d3 100644
> --- a/net/l2tpv3.c
> +++ b/net/l2tpv3.c
> @@ -42,7 +42,7 @@
>   */
>
>  #define BUFFER_ALIGN sysconf(_SC_PAGESIZE)
> -#define BUFFER_SIZE 2048
> +#define BUFFER_SIZE 16384
>  #define IOVSIZE 2
>  #define MAX_L2TPV3_MSGCNT 64
>  #define MAX_L2TPV3_IOVCNT (MAX_L2TPV3_MSGCNT * IOVSIZE)
> --
> 2.36.2
>
>