[PULL v2 0/6] QEMU Guest Agent misc patches

Konstantin Kostiuk posted 6 patches 1 year, 4 months ago
Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/qemu tags/patchew/20221217090740.522093-1-kkostiuk@redhat.com
Maintainers: Paolo Bonzini <pbonzini@redhat.com>, "Alex Bennée" <alex.bennee@linaro.org>, Thomas Huth <thuth@redhat.com>, "Marc-André Lureau" <marcandre.lureau@redhat.com>, "Daniel P. Berrangé" <berrange@redhat.com>, "Philippe Mathieu-Daudé" <philmd@linaro.org>, Michael Roth <michael.roth@amd.com>, Konstantin Kostiuk <kkostiuk@redhat.com>
There is a newer version of this series
configure                 |  3 +++
meson.build               |  2 +-
qga/commands-bsd.c        |  5 +++++
qga/commands-posix.c      |  9 ++++++--
qga/commands-win32.c      | 32 +++++++++++++++++----------
qga/installer/qemu-ga.wxs | 17 +++++++++++---
qga/main.c                | 56 +++++++++++++++++++++++++++++++++++++++++------
qga/meson.build           | 25 ++++++++++++++++++++-
qga/messages-win32.mc     |  9 ++++++++
9 files changed, 133 insertions(+), 25 deletions(-)
create mode 100644 qga/messages-win32.mc
[PULL v2 0/6] QEMU Guest Agent misc patches
Posted by Konstantin Kostiuk 1 year, 4 months ago
The following changes since commit d038d2645acabf6f52fd61baeaa021c3ebe97714:

  Merge tag 'for-upstream' of https://repo.or.cz/qemu/kevin into staging (2022-12-16 13:26:09 +0000)

are available in the Git repository at:

  git@github.com:kostyanf14/qemu.git tags/qga-pull-2022-12-17

for you to fetch changes up to ea5ea85c5894ac220cdb52b3f07c6ad6e4544900:

  qga-win: choose the right libpcre version to include in MSI package (2022-12-17 10:53:38 +0200)

----------------------------------------------------------------
qga-pull-2022-12-17

v1 -> v2:
  removed 'qga: Add ZFS TRIM support for FreeBSD' series
  that failed to merge

----------------------------------------------------------------
Andrey Drobyshev via (3):
      qga-win: add logging to Windows event log
      qga: map GLib log levels to system levels
      qga-win: choose the right libpcre version to include in MSI package

Brad Smith (1):
      qga: Add initial OpenBSD and NetBSD support

Kfir Manor (2):
      qga:/qga-win: adding a empty PCI address creation function
      qga:/qga-win: skip getting pci info for USB disks

 configure                 |  3 +++
 meson.build               |  2 +-
 qga/commands-bsd.c        |  5 +++++
 qga/commands-posix.c      |  9 ++++++--
 qga/commands-win32.c      | 32 +++++++++++++++++----------
 qga/installer/qemu-ga.wxs | 17 +++++++++++---
 qga/main.c                | 56 +++++++++++++++++++++++++++++++++++++++++------
 qga/meson.build           | 25 ++++++++++++++++++++-
 qga/messages-win32.mc     |  9 ++++++++
 9 files changed, 133 insertions(+), 25 deletions(-)
 create mode 100644 qga/messages-win32.mc


--
2.25.1
Re: [PULL v2 0/6] QEMU Guest Agent misc patches
Posted by Peter Maydell 1 year, 4 months ago
On Sat, 17 Dec 2022 at 09:07, Konstantin Kostiuk <kkostiuk@redhat.com> wrote:
>
> The following changes since commit d038d2645acabf6f52fd61baeaa021c3ebe97714:
>
>   Merge tag 'for-upstream' of https://repo.or.cz/qemu/kevin into staging (2022-12-16 13:26:09 +0000)
>
> are available in the Git repository at:
>
>   git@github.com:kostyanf14/qemu.git tags/qga-pull-2022-12-17
>
> for you to fetch changes up to ea5ea85c5894ac220cdb52b3f07c6ad6e4544900:
>
>   qga-win: choose the right libpcre version to include in MSI package (2022-12-17 10:53:38 +0200)
>
> ----------------------------------------------------------------
> qga-pull-2022-12-17
>
> v1 -> v2:
>   removed 'qga: Add ZFS TRIM support for FreeBSD' series
>   that failed to merge
>
> ----------------------------------------------------------------
> Andrey Drobyshev via (3):
>       qga-win: add logging to Windows event log
>       qga: map GLib log levels to system levels
>       qga-win: choose the right libpcre version to include in MSI package

These commits all have an author tag with an email 'qemu-devel@nongnu.org';
you need to fix those up and resend, please. (checkpatch catches this,
if you want to detect this locally.)

thanks
-- PMM
Re: [PULL v2 0/6] QEMU Guest Agent misc patches
Posted by Konstantin Kostiuk 1 year, 4 months ago
On Sat, Dec 17, 2022 at 11:20 PM Peter Maydell <peter.maydell@linaro.org>
wrote:

> On Sat, 17 Dec 2022 at 09:07, Konstantin Kostiuk <kkostiuk@redhat.com>
> wrote:
> >
> > The following changes since commit
> d038d2645acabf6f52fd61baeaa021c3ebe97714:
> >
> >   Merge tag 'for-upstream' of https://repo.or.cz/qemu/kevin into
> staging (2022-12-16 13:26:09 +0000)
> >
> > are available in the Git repository at:
> >
> >   git@github.com:kostyanf14/qemu.git tags/qga-pull-2022-12-17
> >
> > for you to fetch changes up to ea5ea85c5894ac220cdb52b3f07c6ad6e4544900:
> >
> >   qga-win: choose the right libpcre version to include in MSI package
> (2022-12-17 10:53:38 +0200)
> >
> > ----------------------------------------------------------------
> > qga-pull-2022-12-17
> >
> > v1 -> v2:
> >   removed 'qga: Add ZFS TRIM support for FreeBSD' series
> >   that failed to merge
> >
> > ----------------------------------------------------------------
> > Andrey Drobyshev via (3):
> >       qga-win: add logging to Windows event log
> >       qga: map GLib log levels to system levels
> >       qga-win: choose the right libpcre version to include in MSI package
>
> These commits all have an author tag with an email 'qemu-devel@nongnu.org
> ';
> you need to fix those up and resend, please. (checkpatch catches this,
> if you want to detect this locally.)
>
>
What is the proper way to fix this? Can I fix this by myself, push and
resend commits
or author should resend it?

Best Regards,
Konstantin Kostiuk.


> thanks
> -- PMM
>
>
Re: [PULL v2 0/6] QEMU Guest Agent misc patches
Posted by Peter Maydell 1 year, 4 months ago
On Mon, 19 Dec 2022 at 10:34, Konstantin Kostiuk <kkostiuk@redhat.com> wrote:
>
>
>
> On Sat, Dec 17, 2022 at 11:20 PM Peter Maydell <peter.maydell@linaro.org> wrote:
>>
>> On Sat, 17 Dec 2022 at 09:07, Konstantin Kostiuk <kkostiuk@redhat.com> wrote:
>> > Andrey Drobyshev via (3):
>> >       qga-win: add logging to Windows event log
>> >       qga: map GLib log levels to system levels
>> >       qga-win: choose the right libpcre version to include in MSI package
>>
>> These commits all have an author tag with an email 'qemu-devel@nongnu.org';
>> you need to fix those up and resend, please. (checkpatch catches this,
>> if you want to detect this locally.)
>>
>
> What is the proper way to fix this? Can I fix this by myself, push and resend commits
> or author should resend it?

You should fix up the commits locally and resend the pullreq.
Generally the author can't fix by resending, because the reason
the patches are attributed to the list is an unfortunate interaction
between the configuration of their mail system and the mailing list,
so any re-send would just have the same author as before.

-- PMM