exec/helper-head: Include missing "fpu/softfloat-types.h" header

[PATCH] exec/helper-head: Include missing "fpu/softfloat-types.h" header

Philippe Mathieu-Daudé posted 1 patch 1 year, 4 months ago

Download mbox

Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/qemu tags/patchew/20221216225202.25664-1-philmd@linaro.org

Maintainers: Richard Henderson <richard.henderson@linaro.org>, Paolo Bonzini <pbonzini@redhat.com>

include/exec/helper-head.h | 2 ++
1 file changed, 2 insertions(+)

Expand all Fold all

[PATCH] exec/helper-head: Include missing "fpu/softfloat-types.h" header

Posted by Philippe Mathieu-Daudé 1 year, 4 months ago

'dh_ctype_f32' is defined as 'float32', itself declared
in "fpu/softfloat-types.h". Include this header to avoid
when refactoring other headers:

  In file included from include/exec/helper-proto.h:7,
                   from include/tcg/tcg-op.h:29,
                   from ../../tcg/tcg-op-vec.c:22:
  include/exec/helper-head.h:44:22: error: unknown type name ‘float32’; did you mean ‘_Float32’?
     44 | #define dh_ctype_f32 float32
        |                      ^~~~~~~

Signed-off-by: Philippe Mathieu-Daudé <philmd@linaro.org>
---
 include/exec/helper-head.h | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/include/exec/helper-head.h b/include/exec/helper-head.h
index 584b120312..325a42b14e 100644
--- a/include/exec/helper-head.h
+++ b/include/exec/helper-head.h
@@ -18,6 +18,8 @@
 #ifndef EXEC_HELPER_HEAD_H
 #define EXEC_HELPER_HEAD_H
 
+#include "fpu/softfloat-types.h"
+
 #define HELPER(name) glue(helper_, name)
 
 /* Some types that make sense in C, but not for TCG.  */
-- 
2.38.1

Re: [PATCH] exec/helper-head: Include missing "fpu/softfloat-types.h" header

Posted by Richard Henderson 1 year, 2 months ago

On 12/16/22 12:52, Philippe Mathieu-Daudé wrote:
> 'dh_ctype_f32' is defined as 'float32', itself declared
> in "fpu/softfloat-types.h". Include this header to avoid
> when refactoring other headers:
> 
>    In file included from include/exec/helper-proto.h:7,
>                     from include/tcg/tcg-op.h:29,
>                     from ../../tcg/tcg-op-vec.c:22:
>    include/exec/helper-head.h:44:22: error: unknown type name ‘float32’; did you mean ‘_Float32’?
>       44 | #define dh_ctype_f32 float32
>          |                      ^~~~~~~
> 
> Signed-off-by: Philippe Mathieu-Daudé <philmd@linaro.org>

Queued to tcg-next.


r~

> ---
>   include/exec/helper-head.h | 2 ++
>   1 file changed, 2 insertions(+)
> 
> diff --git a/include/exec/helper-head.h b/include/exec/helper-head.h
> index 584b120312..325a42b14e 100644
> --- a/include/exec/helper-head.h
> +++ b/include/exec/helper-head.h
> @@ -18,6 +18,8 @@
>   #ifndef EXEC_HELPER_HEAD_H
>   #define EXEC_HELPER_HEAD_H
>   
> +#include "fpu/softfloat-types.h"
> +
>   #define HELPER(name) glue(helper_, name)
>   
>   /* Some types that make sense in C, but not for TCG.  */