[v1] target/misc: Header cleanups around "cpu.h"

[PATCH 06/10] target/ppc/helper: Include missing "cpu.h" header

Posted by Philippe Mathieu-Daudé 3 years, 1 month ago

'dh_ctype_*' are defined as 'ppc_avr_t/ppc_vsr_t/ppc_acc_t',
themselves declared in "cpu.h".

Signed-off-by: Philippe Mathieu-Daudé <philmd@linaro.org>
---
 target/ppc/helper.h | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/target/ppc/helper.h b/target/ppc/helper.h
index 8dd22a35e4..a02db8d893 100644
--- a/target/ppc/helper.h
+++ b/target/ppc/helper.h
@@ -1,3 +1,5 @@
+#include "cpu.h"
+
 DEF_HELPER_FLAGS_3(raise_exception_err, TCG_CALL_NO_WG, noreturn, env, i32, i32)
 DEF_HELPER_FLAGS_2(raise_exception, TCG_CALL_NO_WG, noreturn, env, i32)
 DEF_HELPER_FLAGS_4(tw, TCG_CALL_NO_WG, void, env, tl, tl, i32)
-- 
2.38.1

Re: [PATCH 06/10] target/ppc/helper: Include missing "cpu.h" header

Posted by Richard Henderson 3 years, 1 month ago

On 12/16/22 14:05, Philippe Mathieu-Daudé wrote:
> 'dh_ctype_*' are defined as 'ppc_avr_t/ppc_vsr_t/ppc_acc_t',
> themselves declared in "cpu.h".
> 
> Signed-off-by: Philippe Mathieu-Daudé <philmd@linaro.org>
> ---
>   target/ppc/helper.h | 2 ++
>   1 file changed, 2 insertions(+)
> 
> diff --git a/target/ppc/helper.h b/target/ppc/helper.h
> index 8dd22a35e4..a02db8d893 100644
> --- a/target/ppc/helper.h
> +++ b/target/ppc/helper.h
> @@ -1,3 +1,5 @@
> +#include "cpu.h"

No, see patch 1.


r~