[v1] target/misc: Header cleanups around "cpu.h"

[PATCH 10/10] target/xtensa/cpu: Include missing "memory.h" header

Posted by Philippe Mathieu-Daudé 3 years, 1 month ago

Under system emulation, xtensa_cpu_initfn() calls
memory_region_init_io(), itself declared in "exec/memory.h".

Signed-off-by: Philippe Mathieu-Daudé <philmd@linaro.org>
---
 target/xtensa/cpu.c | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/target/xtensa/cpu.c b/target/xtensa/cpu.c
index 09923301c4..879710f8d1 100644
--- a/target/xtensa/cpu.c
+++ b/target/xtensa/cpu.c
@@ -35,6 +35,9 @@
 #include "qemu/module.h"
 #include "migration/vmstate.h"
 #include "hw/qdev-clock.h"
+#ifndef CONFIG_USER_ONLY
+#include "exec/memory.h"
+#endif
 
 
 static void xtensa_cpu_set_pc(CPUState *cs, vaddr value)
-- 
2.38.1

Re: [PATCH 10/10] target/xtensa/cpu: Include missing "memory.h" header

Posted by Richard Henderson 3 years, 1 month ago

On 12/16/22 14:05, Philippe Mathieu-Daudé wrote:
> Under system emulation, xtensa_cpu_initfn() calls
> memory_region_init_io(), itself declared in "exec/memory.h".
> 
> Signed-off-by: Philippe Mathieu-Daudé <philmd@linaro.org>
> ---
>   target/xtensa/cpu.c | 3 +++
>   1 file changed, 3 insertions(+)

Reviewed-by: Richard Henderson <richard.henderson@linaro.org>


r~