[v2] Clean up dependencies of ACPI controllers

[PATCH v2 5/7] hw/isa/Kconfig: Add missing dependency to VT82C686

Posted by Bernhard Beschow 3 years, 1 month ago

The ACPIREGS are provided by TYPE_VIA_PM, so needs to select ACPI.

Signed-off-by: Bernhard Beschow <shentey@gmail.com>
---
 hw/isa/Kconfig | 1 +
 1 file changed, 1 insertion(+)

diff --git a/hw/isa/Kconfig b/hw/isa/Kconfig
index 0a6a04947c..0156a66889 100644
--- a/hw/isa/Kconfig
+++ b/hw/isa/Kconfig
@@ -52,6 +52,7 @@ config PIIX4
 config VT82C686
     bool
     select ISA_SUPERIO
+    select ACPI
     select ACPI_SMBUS
     select SERIAL_ISA
     select FDC_ISA
-- 
2.39.0

Re: [PATCH v2 5/7] hw/isa/Kconfig: Add missing dependency to VT82C686

Posted by Philippe Mathieu-Daudé 3 years, 1 month ago

On 16/12/22 14:03, Bernhard Beschow wrote:
> The ACPIREGS are provided by TYPE_VIA_PM, so needs to select ACPI.
> 
> Signed-off-by: Bernhard Beschow <shentey@gmail.com>
> ---
>   hw/isa/Kconfig | 1 +
>   1 file changed, 1 insertion(+)

Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>

Re: [PATCH v2 5/7] hw/isa/Kconfig: Add missing dependency to VT82C686

Posted by BALATON Zoltan 3 years, 1 month ago

On Fri, 16 Dec 2022, Bernhard Beschow wrote:
> The ACPIREGS are provided by TYPE_VIA_PM, so needs to select ACPI.
>
> Signed-off-by: Bernhard Beschow <shentey@gmail.com>

Reviewed-by: BALATON Zoltan <balaton@eik.bme.hu>

> ---
> hw/isa/Kconfig | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/hw/isa/Kconfig b/hw/isa/Kconfig
> index 0a6a04947c..0156a66889 100644
> --- a/hw/isa/Kconfig
> +++ b/hw/isa/Kconfig
> @@ -52,6 +52,7 @@ config PIIX4
> config VT82C686
>     bool
>     select ISA_SUPERIO
> +    select ACPI
>     select ACPI_SMBUS
>     select SERIAL_ISA
>     select FDC_ISA
>