split user and system code in gdbstub

[PATCH v1 07/10] includes: add new gdbstub include directory

Alex Bennée posted 10 patches 3 years, 1 month ago

Download mbox

Maintainers: Paolo Bonzini <pbonzini@redhat.com>, Richard Henderson <richard.henderson@linaro.org>, Warner Losh <imp@bsdimp.com>, Kyle Evans <kevans@freebsd.org>, Eduardo Habkost <eduardo@habkost.net>, Marcel Apfelbaum <marcel.apfelbaum@gmail.com>, "Philippe Mathieu-Daudé" <philmd@linaro.org>, Yanan Wang <wangyanan55@huawei.com>, "Alex Bennée" <alex.bennee@linaro.org>, Daniel Henrique Barboza <danielhb413@gmail.com>, "Cédric Le Goater" <clg@kaod.org>, David Gibson <david@gibson.dropbear.id.au>, Greg Kurz <groug@kaod.org>, Laurent Vivier <laurent@vivier.eu>, "Dr. David Alan Gilbert" <dgilbert@redhat.com>, Markus Armbruster <armbru@redhat.com>, Alexandre Iooss <erdnaxe@crans.org>, Mahmoud Mandour <ma.mandourr@gmail.com>, Peter Maydell <peter.maydell@linaro.org>, Michael Rolnik <mrolnik@gmail.com>, "Edgar E. Iglesias" <edgar.iglesias@gmail.com>, Taylor Simpson <tsimpson@quicinc.com>, Marcelo Tosatti <mtosatti@redhat.com>, Sunil Muthuswamy <sunilmut@microsoft.com>, Song Gao <gaosong@loongson.cn>, Xiaojuan Yang <yangxiaojuan@loongson.cn>, Aurelien Jarno <aurelien@aurel32.net>, Jiaxun Yang <jiaxun.yang@flygoat.com>, Aleksandar Rikalo <aleksandar.rikalo@syrmia.com>, Chris Wulff <crwulff@gmail.com>, Marek Vasut <marex@denx.de>, Stafford Horne <shorne@gmail.com>, Palmer Dabbelt <palmer@dabbelt.com>, Alistair Francis <alistair.francis@wdc.com>, Bin Meng <bin.meng@windriver.com>, Yoshinori Sato <ysato@users.sourceforge.jp>, David Hildenbrand <david@redhat.com>, Ilya Leoshkevich <iii@linux.ibm.com>, Thomas Huth <thuth@redhat.com>, Halil Pasic <pasic@linux.ibm.com>, Christian Borntraeger <borntraeger@linux.ibm.com>, Mark Cave-Ayland <mark.cave-ayland@ilande.co.uk>, Artyom Tarasenko <atar4qemu@gmail.com>, Bastian Koppelmann <kbastian@mail.uni-paderborn.de>, Max Filippov <jcmvbkbc@gmail.com>

Expand all Fold all

[PATCH v1 07/10] includes: add new gdbstub include directory

Posted by Alex Bennée 3 years, 1 month ago

To avoid having a messy set of include files containing system and
user APIs lets prepare for a cleaner layout.

Signed-off-by: Alex Bennée <alex.bennee@linaro.org>
---
 include/gdbstub/common.h | 14 ++++++++++++++
 include/gdbstub/user.h   | 14 ++++++++++++++
 MAINTAINERS              |  1 +
 3 files changed, 29 insertions(+)
 create mode 100644 include/gdbstub/common.h
 create mode 100644 include/gdbstub/user.h

diff --git a/include/gdbstub/common.h b/include/gdbstub/common.h
new file mode 100644
index 0000000000..f928dbc487
--- /dev/null
+++ b/include/gdbstub/common.h
@@ -0,0 +1,14 @@
+/*
+ * gdbstub common APIs
+ *
+ * Copyright (c) 2022 Linaro Ltd
+ *
+ * SPDX-License-Identifier: LGPL-2.0+
+ */
+
+#ifndef GDBSTUB_COMMON_H
+#define GDBSTUB_COMMON_H
+
+
+
+#endif /* GDBSTUB_COMMON_H */
diff --git a/include/gdbstub/user.h b/include/gdbstub/user.h
new file mode 100644
index 0000000000..53baba65ff
--- /dev/null
+++ b/include/gdbstub/user.h
@@ -0,0 +1,14 @@
+/*
+ * gdbstub user-mode only APIs
+ *
+ * Copyright (c) 2022 Linaro Ltd
+ *
+ * SPDX-License-Identifier: LGPL-2.0+
+ */
+
+#ifndef GDBSTUB_USER_H
+#define GDBSTUB_USER_H
+
+
+
+#endif /* GDBSTUB_USER_H */
diff --git a/MAINTAINERS b/MAINTAINERS
index 6966490c94..c84d9299c3 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -2698,6 +2698,7 @@ R: Philippe Mathieu-Daudé <philmd@linaro.org>
 S: Maintained
 F: gdbstub/*
 F: include/exec/gdbstub.h
+F: include/gdbstub/*
 F: gdb-xml/
 F: tests/tcg/multiarch/gdbstub/
 F: scripts/feature_to_c.sh
-- 
2.34.1

Re: [PATCH v1 07/10] includes: add new gdbstub include directory

Posted by Richard Henderson 3 years, 1 month ago

On 12/16/22 03:22, Alex Bennée wrote:
> To avoid having a messy set of include files containing system and
> user APIs lets prepare for a cleaner layout.
> 
> Signed-off-by: Alex Bennée <alex.bennee@linaro.org>
> ---
>   include/gdbstub/common.h | 14 ++++++++++++++
>   include/gdbstub/user.h   | 14 ++++++++++++++
>   MAINTAINERS              |  1 +
>   3 files changed, 29 insertions(+)
>   create mode 100644 include/gdbstub/common.h
>   create mode 100644 include/gdbstub/user.h
> 
> diff --git a/include/gdbstub/common.h b/include/gdbstub/common.h
> new file mode 100644
> index 0000000000..f928dbc487
> --- /dev/null
> +++ b/include/gdbstub/common.h
> @@ -0,0 +1,14 @@
> +/*
> + * gdbstub common APIs
> + *
> + * Copyright (c) 2022 Linaro Ltd
> + *
> + * SPDX-License-Identifier: LGPL-2.0+
> + */
> +
> +#ifndef GDBSTUB_COMMON_H
> +#define GDBSTUB_COMMON_H
> +
> +
> +
> +#endif /* GDBSTUB_COMMON_H */

I don't see any point in creating these headers separately from the patch that populates them.

Not keen on the name "common".  From the later patch, I think it may be at least 3 
separate headers: gdb syscalls, start/stop, xml.


r~