[v3] hw/usb: add configuration flags for emulated and passthru usb smartcard

[PATCH v3 0/2] hw/usb: add configuration flags for emulated and passthru usb smartcard

Posted by Jon Maloy 1 year, 4 months ago

We add three new configuration flags, LIBCACARD, USB_SMARTCARD_PASSTHRU
and USB_SMARTCARD_EMULATED in order to improve configurability of these
functionalities.

Signed-off-by: Jon Maloy <jmaloy@redhat.com>

---
v2: Added a LIBACARD flag, plus reversed 'select' clauses, as suggested
    by Paolo Bonzini and Marc-André Lureau.

v3: Split in two commits, so that LIBCACARD is added separately, as suggested
    by Philippe Mathieu-Daudé.


Jon Maloy (2):
  hw/usb: add configuration flags for emulated and passthru usb
    smartcard
  hw/usb: add configuration flag for Common Access Card library code

 Kconfig.host       |  3 +++
 hw/usb/Kconfig     | 14 ++++++++++++++
 hw/usb/meson.build | 11 ++++-------
 meson.build        |  1 +
 4 files changed, 22 insertions(+), 7 deletions(-)

-- 
2.35.3

Re: [PATCH v3 0/2] hw/usb: add configuration flags for emulated and passthru usb smartcard

Posted by Stefan Hajnoczi 1 year, 4 months ago

On Mon, Dec 12, 2022 at 05:09:47PM -0500, Jon Maloy wrote:
> We add three new configuration flags, LIBCACARD, USB_SMARTCARD_PASSTHRU
> and USB_SMARTCARD_EMULATED in order to improve configurability of these
> functionalities.
> 
> Signed-off-by: Jon Maloy <jmaloy@redhat.com>
> 
> ---
> v2: Added a LIBACARD flag, plus reversed 'select' clauses, as suggested
>     by Paolo Bonzini and Marc-André Lureau.
> 
> v3: Split in two commits, so that LIBCACARD is added separately, as suggested
>     by Philippe Mathieu-Daudé.
> 
> 
> Jon Maloy (2):
>   hw/usb: add configuration flags for emulated and passthru usb
>     smartcard
>   hw/usb: add configuration flag for Common Access Card library code
> 
>  Kconfig.host       |  3 +++
>  hw/usb/Kconfig     | 14 ++++++++++++++
>  hw/usb/meson.build | 11 ++++-------
>  meson.build        |  1 +
>  4 files changed, 22 insertions(+), 7 deletions(-)
> 
> -- 
> 2.35.3
> 

I have CCed Gerd Hoffmann since he is the hw/usb/ maintainer.

Reviewed-by: Stefan Hajnoczi <stefanha@redhat.com>

Re: [PATCH v3 0/2] hw/usb: add configuration flags for emulated and passthru usb smartcard

Posted by Jon Maloy 1 year, 3 months ago


On 2022-12-13 16:02, Stefan Hajnoczi wrote:
> On Mon, Dec 12, 2022 at 05:09:47PM -0500, Jon Maloy wrote:
>> We add three new configuration flags, LIBCACARD, USB_SMARTCARD_PASSTHRU
>> and USB_SMARTCARD_EMULATED in order to improve configurability of these
>> functionalities.
>>
>> Signed-off-by: Jon Maloy <jmaloy@redhat.com>
>>
>> ---
>> v2: Added a LIBACARD flag, plus reversed 'select' clauses, as suggested
>>      by Paolo Bonzini and Marc-André Lureau.
>>
>> v3: Split in two commits, so that LIBCACARD is added separately, as suggested
>>      by Philippe Mathieu-Daudé.
>>
>>
>> Jon Maloy (2):
>>    hw/usb: add configuration flags for emulated and passthru usb
>>      smartcard
>>    hw/usb: add configuration flag for Common Access Card library code
>>
>>   Kconfig.host       |  3 +++
>>   hw/usb/Kconfig     | 14 ++++++++++++++
>>   hw/usb/meson.build | 11 ++++-------
>>   meson.build        |  1 +
>>   4 files changed, 22 insertions(+), 7 deletions(-)
>>
>> -- 
>> 2.35.3
>>
> I have CCed Gerd Hoffmann since he is the hw/usb/ maintainer.
>
> Reviewed-by: Stefan Hajnoczi <stefanha@redhat.com>

Hi Gerd,
It seems this one was forgotten, and never applied.
Could you have a look?

Thanks
///jon

Re: [PATCH v3 0/2] hw/usb: add configuration flags for emulated and passthru usb smartcard

Posted by Philippe Mathieu-Daudé 1 year, 4 months ago

On 12/12/22 23:09, Jon Maloy wrote:
> We add three new configuration flags, LIBCACARD, USB_SMARTCARD_PASSTHRU
> and USB_SMARTCARD_EMULATED in order to improve configurability of these
> functionalities.

> Jon Maloy (2):
>    hw/usb: add configuration flags for emulated and passthru usb
>      smartcard
>    hw/usb: add configuration flag for Common Access Card library code

Series:
Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>