[PATCH 05/30] configure: remove backwards-compatibility and obsolete options

Paolo Bonzini posted 30 patches 3 years ago
Maintainers: Kevin Wolf <kwolf@redhat.com>, Hanna Reitz <hreitz@redhat.com>, Paolo Bonzini <pbonzini@redhat.com>, "Alex Bennée" <alex.bennee@linaro.org>, Thomas Huth <thuth@redhat.com>, Alexandre Iooss <erdnaxe@crans.org>, Mahmoud Mandour <ma.mandourr@gmail.com>, "Daniel P. Berrangé" <berrange@redhat.com>, "Marc-André Lureau" <marcandre.lureau@redhat.com>, "Philippe Mathieu-Daudé" <philmd@linaro.org>, Michael Roth <michael.roth@amd.com>, Konstantin Kostiuk <kkostiuk@redhat.com>, John Snow <jsnow@redhat.com>, Cleber Rosa <crosa@redhat.com>, Richard Henderson <richard.henderson@linaro.org>
[PATCH 05/30] configure: remove backwards-compatibility and obsolete options
Posted by Paolo Bonzini 3 years ago
Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
---
 configure | 20 --------------------
 1 file changed, 20 deletions(-)

diff --git a/configure b/configure
index 4d14ff9c319c..adfff30a6204 100755
--- a/configure
+++ b/configure
@@ -838,17 +838,6 @@ for opt do
   ;;
   --with-coroutine=*) coroutine="$optarg"
   ;;
-  --disable-zlib-test)
-  ;;
-  --disable-virtio-blk-data-plane|--enable-virtio-blk-data-plane)
-      echo "$0: $opt is obsolete, virtio-blk data-plane is always on" >&2
-  ;;
-  --enable-vhdx|--disable-vhdx)
-      echo "$0: $opt is obsolete, VHDX driver is always built" >&2
-  ;;
-  --enable-uuid|--disable-uuid)
-      echo "$0: $opt is obsolete, UUID support is always built" >&2
-  ;;
   --with-git=*) git="$optarg"
   ;;
   --with-git-submodules=*)
@@ -868,19 +857,10 @@ for opt do
   ;;
   --gdb=*) gdb_bin="$optarg"
   ;;
-  # backwards compatibility options
-  --enable-trace-backend=*) meson_option_parse "--enable-trace-backends=$optarg" "$optarg"
-  ;;
-  --disable-blobs) meson_option_parse --disable-install-blobs ""
-  ;;
   --enable-vfio-user-server) vfio_user_server="enabled"
   ;;
   --disable-vfio-user-server) vfio_user_server="disabled"
   ;;
-  --enable-tcmalloc) meson_option_parse --enable-malloc=tcmalloc tcmalloc
-  ;;
-  --enable-jemalloc) meson_option_parse --enable-malloc=jemalloc jemalloc
-  ;;
   # everything else has the same name in configure and meson
   --*) meson_option_parse "$opt" "$optarg"
   ;;
-- 
2.38.1
Re: [PATCH 05/30] configure: remove backwards-compatibility and obsolete options
Posted by Daniel P. Berrangé 3 years ago
On Fri, Dec 09, 2022 at 12:23:44PM +0100, Paolo Bonzini wrote:
> Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
> ---
>  configure | 20 --------------------
>  1 file changed, 20 deletions(-)

Reviewed-by: Daniel P. Berrangé <berrange@redhat.com>


With regards,
Daniel
-- 
|: https://berrange.com      -o-    https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org         -o-            https://fstop138.berrange.com :|
|: https://entangle-photo.org    -o-    https://www.instagram.com/dberrange :|


Re: [PATCH 05/30] configure: remove backwards-compatibility and obsolete options
Posted by Marc-André Lureau 3 years ago
On Fri, Dec 9, 2022 at 3:43 PM Paolo Bonzini <pbonzini@redhat.com> wrote:
>
> Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>

Reviewed-by: Marc-André Lureau <marcandre.lureau@redhat.com>


> ---
>  configure | 20 --------------------
>  1 file changed, 20 deletions(-)
>
> diff --git a/configure b/configure
> index 4d14ff9c319c..adfff30a6204 100755
> --- a/configure
> +++ b/configure
> @@ -838,17 +838,6 @@ for opt do
>    ;;
>    --with-coroutine=*) coroutine="$optarg"
>    ;;
> -  --disable-zlib-test)
> -  ;;
> -  --disable-virtio-blk-data-plane|--enable-virtio-blk-data-plane)
> -      echo "$0: $opt is obsolete, virtio-blk data-plane is always on" >&2
> -  ;;
> -  --enable-vhdx|--disable-vhdx)
> -      echo "$0: $opt is obsolete, VHDX driver is always built" >&2
> -  ;;
> -  --enable-uuid|--disable-uuid)
> -      echo "$0: $opt is obsolete, UUID support is always built" >&2
> -  ;;
>    --with-git=*) git="$optarg"
>    ;;
>    --with-git-submodules=*)
> @@ -868,19 +857,10 @@ for opt do
>    ;;
>    --gdb=*) gdb_bin="$optarg"
>    ;;
> -  # backwards compatibility options
> -  --enable-trace-backend=*) meson_option_parse "--enable-trace-backends=$optarg" "$optarg"
> -  ;;
> -  --disable-blobs) meson_option_parse --disable-install-blobs ""
> -  ;;
>    --enable-vfio-user-server) vfio_user_server="enabled"
>    ;;
>    --disable-vfio-user-server) vfio_user_server="disabled"
>    ;;
> -  --enable-tcmalloc) meson_option_parse --enable-malloc=tcmalloc tcmalloc
> -  ;;
> -  --enable-jemalloc) meson_option_parse --enable-malloc=jemalloc jemalloc
> -  ;;
>    # everything else has the same name in configure and meson
>    --*) meson_option_parse "$opt" "$optarg"
>    ;;
> --
> 2.38.1
>
>


-- 
Marc-André Lureau