[PATCH 3/5] hw/acpi/Kconfig: Add missing dependencies to ACPI_ICH9

Bernhard Beschow posted 5 patches 3 years, 2 months ago
Maintainers: "Philippe Mathieu-Daudé" <philmd@linaro.org>, "Michael S. Tsirkin" <mst@redhat.com>, Igor Mammedov <imammedo@redhat.com>, Ani Sinha <ani@anisinha.ca>, Marcel Apfelbaum <marcel.apfelbaum@gmail.com>, Paolo Bonzini <pbonzini@redhat.com>, Richard Henderson <richard.henderson@linaro.org>, Eduardo Habkost <eduardo@habkost.net>
There is a newer version of this series
[PATCH 3/5] hw/acpi/Kconfig: Add missing dependencies to ACPI_ICH9
Posted by Bernhard Beschow 3 years, 2 months ago
ich9_lpc_realize() uses apm_init() and ich9_smbus_realize() uses
pm_smbus_init(), so both APM and ACPI_SMBUS are provided by the device
models managed by ACPI_ICH9.

Signed-off-by: Bernhard Beschow <shentey@gmail.com>
---
 hw/acpi/Kconfig | 2 ++
 hw/i386/Kconfig | 1 -
 hw/isa/Kconfig  | 1 -
 3 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/hw/acpi/Kconfig b/hw/acpi/Kconfig
index ec16dd20e6..5a678b07c7 100644
--- a/hw/acpi/Kconfig
+++ b/hw/acpi/Kconfig
@@ -15,7 +15,9 @@ config ACPI_X86
 
 config ACPI_ICH9
     bool
+    select ACPI_SMBUS
     select ACPI_X86
+    select APM
 
 config ACPI_CPU_HOTPLUG
     bool
diff --git a/hw/i386/Kconfig b/hw/i386/Kconfig
index 2fdefd7458..4b4b5265bb 100644
--- a/hw/i386/Kconfig
+++ b/hw/i386/Kconfig
@@ -51,7 +51,6 @@ config PC_PCI
     bool
     select APIC
     select IOAPIC
-    select APM
     select PC
 
 config PC_ACPI
diff --git a/hw/isa/Kconfig b/hw/isa/Kconfig
index 01f330d941..0a6a04947c 100644
--- a/hw/isa/Kconfig
+++ b/hw/isa/Kconfig
@@ -77,5 +77,4 @@ config LPC_ICH9
     # for ICH9.
     select I8257
     select ISA_BUS
-    select ACPI_SMBUS
     select ACPI_ICH9
-- 
2.38.1
Re: [PATCH 3/5] hw/acpi/Kconfig: Add missing dependencies to ACPI_ICH9
Posted by Philippe Mathieu-Daudé 3 years, 1 month ago
On 8/12/22 00:12, Bernhard Beschow wrote:
> ich9_lpc_realize() uses apm_init() and ich9_smbus_realize() uses
> pm_smbus_init(), so both APM and ACPI_SMBUS are provided by the device
> models managed by ACPI_ICH9.
> 
> Signed-off-by: Bernhard Beschow <shentey@gmail.com>
> ---
>   hw/acpi/Kconfig | 2 ++
>   hw/i386/Kconfig | 1 -
>   hw/isa/Kconfig  | 1 -
>   3 files changed, 2 insertions(+), 2 deletions(-)

Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>