acpi/tests/avocado/bits: add mformat as one of the dependencies

[PATCH] acpi/tests/avocado/bits: add mformat as one of the dependencies

Ani Sinha posted 1 patch 1 year, 4 months ago

Download mbox

Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/qemu tags/patchew/20221203132407.34539-1-ani@anisinha.ca

Maintainers: Ani Sinha <ani@anisinha.ca>, "Michael S. Tsirkin" <mst@redhat.com>, Cleber Rosa <crosa@redhat.com>, "Philippe Mathieu-Daudé" <philmd@linaro.org>, Wainer dos Santos Moschetta <wainersm@redhat.com>, Beraldo Leal <bleal@redhat.com>

tests/avocado/acpi-bits.py | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

Expand all Fold all

[PATCH] acpi/tests/avocado/bits: add mformat as one of the dependencies

Posted by Ani Sinha 1 year, 4 months ago

mformat is needed by grub-mkrescue and hence, add this as one of the
dependencies to run bits tests. This avoids errors such as the following:

/var/tmp/acpi-bits-wju6tqoa.tmp/grub-inst-x86_64-efi/bin/grub-mkrescue: 360: mformat: not found

Signed-off-by: Ani Sinha <ani@anisinha.ca>
---
 tests/avocado/acpi-bits.py | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/tests/avocado/acpi-bits.py b/tests/avocado/acpi-bits.py
index 898c837f26..14038fa3c4 100644
--- a/tests/avocado/acpi-bits.py
+++ b/tests/avocado/acpi-bits.py
@@ -50,7 +50,7 @@
 from avocado import skipIf
 from avocado_qemu import QemuBaseTest
 
-deps = ["xorriso"] # dependent tools needed in the test setup/box.
+deps = ["xorriso", "mformat"] # dependent tools needed in the test setup/box.
 supported_platforms = ['x86_64'] # supported test platforms.
 
 
-- 
2.25.1

Re: [PATCH] acpi/tests/avocado/bits: add mformat as one of the dependencies

Posted by Ani Sinha 1 year, 4 months ago

On Sat, Dec 3, 2022 at 6:54 PM Ani Sinha <ani@anisinha.ca> wrote:
>
> mformat is needed by grub-mkrescue and hence, add this as one of the
> dependencies to run bits tests. This avoids errors such as the following:
>
> /var/tmp/acpi-bits-wju6tqoa.tmp/grub-inst-x86_64-efi/bin/grub-mkrescue: 360: mformat: not found
>
> Signed-off-by: Ani Sinha <ani@anisinha.ca>

Michael, please queue this for your next PR.

> ---
>  tests/avocado/acpi-bits.py | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/tests/avocado/acpi-bits.py b/tests/avocado/acpi-bits.py
> index 898c837f26..14038fa3c4 100644
> --- a/tests/avocado/acpi-bits.py
> +++ b/tests/avocado/acpi-bits.py
> @@ -50,7 +50,7 @@
>  from avocado import skipIf
>  from avocado_qemu import QemuBaseTest
>
> -deps = ["xorriso"] # dependent tools needed in the test setup/box.
> +deps = ["xorriso", "mformat"] # dependent tools needed in the test setup/box.
>  supported_platforms = ['x86_64'] # supported test platforms.
>
>
> --
> 2.25.1
>