loongarch for 7.2-rc4 patch

[PULL for 7.2-rc4 0/1] loongarch for 7.2-rc4 patch

Posted by Song Gao 1 year, 4 months ago

The following changes since commit c4ffd91aba1c3d878e99a3e7ba8aad4826728ece:

  Update VERSION for v7.2.0-rc3 (2022-11-29 18:15:26 -0500)

are available in the Git repository at:

  https://gitlab.com/gaosong/qemu.git tags/pull-loongarch-20221202

for you to fetch changes up to 14dccc8ea6ece7ee63273144fb55e4770a05e0fd:

  hw/loongarch/virt: Add cfi01 pflash device (2022-12-02 18:03:05 +0800)

----------------------------------------------------------------
pull for 7.2-rc4

We need this patch.

----------------------------------------------------------------
Xiaojuan Yang (1):
      hw/loongarch/virt: Add cfi01 pflash device

 hw/loongarch/Kconfig        |  1 +
 hw/loongarch/acpi-build.c   | 18 +++++++++++++
 hw/loongarch/virt.c         | 62 +++++++++++++++++++++++++++++++++++++++++++++
 include/hw/loongarch/virt.h |  5 ++++
 4 files changed, 86 insertions(+)

Re: [PULL for 7.2-rc4 0/1] loongarch for 7.2-rc4 patch

Posted by Philippe Mathieu-Daudé 1 year, 4 months ago

Hi,

On 2/12/22 11:25, Song Gao wrote:
> The following changes since commit c4ffd91aba1c3d878e99a3e7ba8aad4826728ece:
> 
>    Update VERSION for v7.2.0-rc3 (2022-11-29 18:15:26 -0500)
> 
> are available in the Git repository at:
> 
>    https://gitlab.com/gaosong/qemu.git tags/pull-loongarch-20221202
> 
> for you to fetch changes up to 14dccc8ea6ece7ee63273144fb55e4770a05e0fd:
> 
>    hw/loongarch/virt: Add cfi01 pflash device (2022-12-02 18:03:05 +0800)
> 
> ----------------------------------------------------------------

Now than the 8.0 cycle started, can you respin this pull request
(preferably rebased on v7.2.0 or later)?

Regards,

Phil.

Re: [PULL for 7.2-rc4 0/1] loongarch for 7.2-rc4 patch

Posted by gaosong 1 year, 4 months ago

在 2022/12/15 下午3:29, Philippe Mathieu-Daudé 写道:
> Hi,
>
> On 2/12/22 11:25, Song Gao wrote:
>> The following changes since commit 
>> c4ffd91aba1c3d878e99a3e7ba8aad4826728ece:
>>
>>    Update VERSION for v7.2.0-rc3 (2022-11-29 18:15:26 -0500)
>>
>> are available in the Git repository at:
>>
>>    https://gitlab.com/gaosong/qemu.git tags/pull-loongarch-20221202
>>
>> for you to fetch changes up to 14dccc8ea6ece7ee63273144fb55e4770a05e0fd:
>>
>>    hw/loongarch/virt: Add cfi01 pflash device (2022-12-02 18:03:05 
>> +0800)
>>
>> ----------------------------------------------------------------
>
> Now than the 8.0 cycle started, can you respin this pull request
> (preferably rebased on v7.2.0 or later)?
>
Done.

Thanks.
Song Gao

Re: [PULL for 7.2-rc4 0/1] loongarch for 7.2-rc4 patch

Posted by Philippe Mathieu-Daudé 1 year, 4 months ago

On 2/12/22 11:25, Song Gao wrote:
> The following changes since commit c4ffd91aba1c3d878e99a3e7ba8aad4826728ece:
> 
>    Update VERSION for v7.2.0-rc3 (2022-11-29 18:15:26 -0500)
> 
> are available in the Git repository at:
> 
>    https://gitlab.com/gaosong/qemu.git tags/pull-loongarch-20221202
> 
> for you to fetch changes up to 14dccc8ea6ece7ee63273144fb55e4770a05e0fd:
> 
>    hw/loongarch/virt: Add cfi01 pflash device (2022-12-02 18:03:05 +0800)
> 
> ----------------------------------------------------------------
> pull for 7.2-rc4
> 
> We need this patch.

FTR this is not a security/regression fix, but a mere feature.

Certainly not justified for a rc4 IMO.

> ----------------------------------------------------------------
> Xiaojuan Yang (1):
>        hw/loongarch/virt: Add cfi01 pflash device
> 
>   hw/loongarch/Kconfig        |  1 +
>   hw/loongarch/acpi-build.c   | 18 +++++++++++++
>   hw/loongarch/virt.c         | 62 +++++++++++++++++++++++++++++++++++++++++++++
>   include/hw/loongarch/virt.h |  5 ++++
>   4 files changed, 86 insertions(+)
> 
>

Re: [PULL for 7.2-rc4 0/1] loongarch for 7.2-rc4 patch

Posted by gaosong@loongson.cn 1 year, 4 months ago

在 2022/12/5 15:24, Philippe Mathieu-Daudé 写道:
> On 2/12/22 11:25, Song Gao wrote:
>> The following changes since commit 
>> c4ffd91aba1c3d878e99a3e7ba8aad4826728ece:
>>
>>    Update VERSION for v7.2.0-rc3 (2022-11-29 18:15:26 -0500)
>>
>> are available in the Git repository at:
>>
>>    https://gitlab.com/gaosong/qemu.git tags/pull-loongarch-20221202
>>
>> for you to fetch changes up to 14dccc8ea6ece7ee63273144fb55e4770a05e0fd:
>>
>>    hw/loongarch/virt: Add cfi01 pflash device (2022-12-02 18:03:05 
>> +0800)
>>
>> ----------------------------------------------------------------
>> pull for 7.2-rc4
>>
>> We need this patch.
>
> FTR this is not a security/regression fix, but a mere feature.
>
> Certainly not justified for a rc4 IMO.
>
We hope LoongArch 7.2 version support pflash,
otherwise the subsequent BIOS support pflash may qemu 7.2 does not support.

Thanks.
Song Gao
>> ----------------------------------------------------------------
>> Xiaojuan Yang (1):
>>        hw/loongarch/virt: Add cfi01 pflash device
>>
>>   hw/loongarch/Kconfig        |  1 +
>>   hw/loongarch/acpi-build.c   | 18 +++++++++++++
>>   hw/loongarch/virt.c         | 62 
>> +++++++++++++++++++++++++++++++++++++++++++++
>>   include/hw/loongarch/virt.h |  5 ++++
>>   4 files changed, 86 insertions(+)
>>
>>

Re: [PULL for 7.2-rc4 0/1] loongarch for 7.2-rc4 patch

Posted by Peter Maydell 1 year, 4 months ago

On Mon, 5 Dec 2022 at 09:20, gaosong@loongson.cn <gaosong@loongson.cn> wrote:
>
>
> 在 2022/12/5 15:24, Philippe Mathieu-Daudé 写道:
> > On 2/12/22 11:25, Song Gao wrote:
> >> The following changes since commit
> >> c4ffd91aba1c3d878e99a3e7ba8aad4826728ece:
> >>
> >>    Update VERSION for v7.2.0-rc3 (2022-11-29 18:15:26 -0500)
> >>
> >> are available in the Git repository at:
> >>
> >>    https://gitlab.com/gaosong/qemu.git tags/pull-loongarch-20221202
> >>
> >> for you to fetch changes up to 14dccc8ea6ece7ee63273144fb55e4770a05e0fd:
> >>
> >>    hw/loongarch/virt: Add cfi01 pflash device (2022-12-02 18:03:05
> >> +0800)
> >>
> >> ----------------------------------------------------------------
> >> pull for 7.2-rc4
> >>
> >> We need this patch.
> >
> > FTR this is not a security/regression fix, but a mere feature.
> >
> > Certainly not justified for a rc4 IMO.
> >
> We hope LoongArch 7.2 version support pflash,
> otherwise the subsequent BIOS support pflash may qemu 7.2 does not support.

Regardless of how much it might be nice to have a new feature
supported, new features cannot go in after softfreeze, only
fixes for bugs. At rc4, changes should really be release
critical bugs and regression fixes only. Further, any pull
request  that should be going in for rc4 should have a clear
statement of what the changes do and why they are release
critical. "We need this patch" is much too vague.

QEMU's release schedule is regular, so there will always be
another release in 4 months time. There is generally no need
to be in a huge hurry to get a feature in.

I would favour reverting this change.

thanks
-- PMM

Re: [PULL for 7.2-rc4 0/1] loongarch for 7.2-rc4 patch

Posted by gaosong@loongson.cn 1 year, 4 months ago

在 2022/12/5 18:48, Peter Maydell 写道:
> On Mon, 5 Dec 2022 at 09:20, gaosong@loongson.cn <gaosong@loongson.cn> wrote:
>>
>> 在 2022/12/5 15:24, Philippe Mathieu-Daudé 写道:
>>> On 2/12/22 11:25, Song Gao wrote:
>>>> The following changes since commit
>>>> c4ffd91aba1c3d878e99a3e7ba8aad4826728ece:
>>>>
>>>>     Update VERSION for v7.2.0-rc3 (2022-11-29 18:15:26 -0500)
>>>>
>>>> are available in the Git repository at:
>>>>
>>>>     https://gitlab.com/gaosong/qemu.git tags/pull-loongarch-20221202
>>>>
>>>> for you to fetch changes up to 14dccc8ea6ece7ee63273144fb55e4770a05e0fd:
>>>>
>>>>     hw/loongarch/virt: Add cfi01 pflash device (2022-12-02 18:03:05
>>>> +0800)
>>>>
>>>> ----------------------------------------------------------------
>>>> pull for 7.2-rc4
>>>>
>>>> We need this patch.
>>> FTR this is not a security/regression fix, but a mere feature.
>>>
>>> Certainly not justified for a rc4 IMO.
>>>
>> We hope LoongArch 7.2 version support pflash,
>> otherwise the subsequent BIOS support pflash may qemu 7.2 does not support.
> Regardless of how much it might be nice to have a new feature
> supported, new features cannot go in after softfreeze, only
> fixes for bugs. At rc4, changes should really be release
> critical bugs and regression fixes only. Further, any pull
> request  that should be going in for rc4 should have a clear
> statement of what the changes do and why they are release
> critical. "We need this patch" is much too vague.
>
> QEMU's release schedule is regular, so there will always be
> another release in 4 months time. There is generally no need
> to be in a huge hurry to get a feature in.
>
> I would favour reverting this change.
Got it .
I had send a patch to revert this.

Thanks.
Song Gao

Re: [PULL for 7.2-rc4 0/1] loongarch for 7.2-rc4 patch

Posted by Stefan Hajnoczi 1 year, 4 months ago

On Mon, 5 Dec 2022 at 06:38, gaosong@loongson.cn <gaosong@loongson.cn> wrote:
>
>
> 在 2022/12/5 18:48, Peter Maydell 写道:
> > On Mon, 5 Dec 2022 at 09:20, gaosong@loongson.cn <gaosong@loongson.cn> wrote:
> >>
> >> 在 2022/12/5 15:24, Philippe Mathieu-Daudé 写道:
> >>> On 2/12/22 11:25, Song Gao wrote:
> >>>> The following changes since commit
> >>>> c4ffd91aba1c3d878e99a3e7ba8aad4826728ece:
> >>>>
> >>>>     Update VERSION for v7.2.0-rc3 (2022-11-29 18:15:26 -0500)
> >>>>
> >>>> are available in the Git repository at:
> >>>>
> >>>>     https://gitlab.com/gaosong/qemu.git tags/pull-loongarch-20221202
> >>>>
> >>>> for you to fetch changes up to 14dccc8ea6ece7ee63273144fb55e4770a05e0fd:
> >>>>
> >>>>     hw/loongarch/virt: Add cfi01 pflash device (2022-12-02 18:03:05
> >>>> +0800)
> >>>>
> >>>> ----------------------------------------------------------------
> >>>> pull for 7.2-rc4
> >>>>
> >>>> We need this patch.
> >>> FTR this is not a security/regression fix, but a mere feature.
> >>>
> >>> Certainly not justified for a rc4 IMO.
> >>>
> >> We hope LoongArch 7.2 version support pflash,
> >> otherwise the subsequent BIOS support pflash may qemu 7.2 does not support.
> > Regardless of how much it might be nice to have a new feature
> > supported, new features cannot go in after softfreeze, only
> > fixes for bugs. At rc4, changes should really be release
> > critical bugs and regression fixes only. Further, any pull
> > request  that should be going in for rc4 should have a clear
> > statement of what the changes do and why they are release
> > critical. "We need this patch" is much too vague.
> >
> > QEMU's release schedule is regular, so there will always be
> > another release in 4 months time. There is generally no need
> > to be in a huge hurry to get a feature in.
> >
> > I would favour reverting this change.
> Got it .
> I had send a patch to revert this.

I gave it the benefit of the doubt because it's isolated and only
affects LoongArch, but Philippe and Peter are right.

Thanks for sending the revert patch.

Stefan

Re: [PULL for 7.2-rc4 0/1] loongarch for 7.2-rc4 patch

Posted by Stefan Hajnoczi 1 year, 4 months ago

Applied, thanks.

Please update the changelog at https://wiki.qemu.org/ChangeLog/7.2 for any user-visible changes.