[PATCH v2 00/14] ui: Move and clean up monitor command code

Markus Armbruster posted 14 patches 1 year, 4 months ago
Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/qemu tags/patchew/20221202100512.4161901-1-armbru@redhat.com
Maintainers: "Marc-André Lureau" <marcandre.lureau@redhat.com>, Paolo Bonzini <pbonzini@redhat.com>, Gerd Hoffmann <kraxel@redhat.com>, "Daniel P. Berrangé" <berrange@redhat.com>, Thomas Huth <thuth@redhat.com>, "Philippe Mathieu-Daudé" <philmd@linaro.org>, "Dr. David Alan Gilbert" <dgilbert@redhat.com>, Markus Armbruster <armbru@redhat.com>
There is a newer version of this series
meson.build                   |   4 +-
hw/display/qxl.h              |   2 -
include/monitor/hmp.h         |   5 +
include/monitor/qmp-helpers.h |  26 +++
include/ui/qemu-spice.h       |   8 +-
include/ui/spice-display.h    |   2 -
chardev/spice.c               |   2 -
hw/display/qxl.c              |  26 +--
monitor/hmp-cmds.c            | 370 +-------------------------------
monitor/qmp-cmds.c            | 176 +++------------
ui/spice-display.c            |  10 -
ui/ui-hmp-cmds.c              | 391 ++++++++++++++++++++++++++++++++++
ui/ui-qmp-cmds.c              | 177 +++++++++++++++
ui/vdagent.c                  |   4 -
hw/display/trace-events       |   1 -
ui/meson.build                |   2 +
16 files changed, 638 insertions(+), 568 deletions(-)
create mode 100644 include/monitor/qmp-helpers.h
create mode 100644 ui/ui-hmp-cmds.c
create mode 100644 ui/ui-qmp-cmds.c
[PATCH v2 00/14] ui: Move and clean up monitor command code
Posted by Markus Armbruster 1 year, 4 months ago
This is mainly about splitting off monitor-related code.  There's also
a minimum Spice version bump, and a few UI improvements to HMP
commands sendkey, change vnc, and info spice.

v2:
* PATCH 03,05-06: New [Daniel]
* PATCH 04: Enable instead of drop channel type "webdav" [Daniel]
* PATCH 07: New [Philippe]
* PATCH 09: Don't move add_client() to ui/
* PATCH 10: New, move ui parts of add_client() to ui/
* PATCH 12+13: Fix incorrect patch split [Daniel]

Markus Armbruster (14):
  ui: Check numeric part of expire_password argument @time properly
  ui: Fix silent truncation of numeric keys in HMP sendkey
  ui/spice: Require spice-protocol >= 0.14.0
  Revert "hmp: info spice: take out webdav"
  ui/spice: Require spice-server >= 0.14.0
  ui/spice: QXLInterface method set_mm_time() is now dead, drop
  ui/spice: Give hmp_info_spice()'s channel_names[] static linkage
  ui: Clean up a few things checkpatch.pl would flag later on
  ui: Move QMP commands from monitor to new ui/ui-qmp-cmds.c
  ui: Factor out qmp_add_client() parts and move to ui/ui-qmp-cmds.c
  ui: Move HMP commands from monitor to new ui/ui-hmp-cmds.c
  ui: Improve "change vnc" error reporting
  ui: Factor out hmp_change_vnc(), and move to ui/ui-hmp-cmds.c
  ui: Reduce nesting in hmp_change_vnc() slightly

 meson.build                   |   4 +-
 hw/display/qxl.h              |   2 -
 include/monitor/hmp.h         |   5 +
 include/monitor/qmp-helpers.h |  26 +++
 include/ui/qemu-spice.h       |   8 +-
 include/ui/spice-display.h    |   2 -
 chardev/spice.c               |   2 -
 hw/display/qxl.c              |  26 +--
 monitor/hmp-cmds.c            | 370 +-------------------------------
 monitor/qmp-cmds.c            | 176 +++------------
 ui/spice-display.c            |  10 -
 ui/ui-hmp-cmds.c              | 391 ++++++++++++++++++++++++++++++++++
 ui/ui-qmp-cmds.c              | 177 +++++++++++++++
 ui/vdagent.c                  |   4 -
 hw/display/trace-events       |   1 -
 ui/meson.build                |   2 +
 16 files changed, 638 insertions(+), 568 deletions(-)
 create mode 100644 include/monitor/qmp-helpers.h
 create mode 100644 ui/ui-hmp-cmds.c
 create mode 100644 ui/ui-qmp-cmds.c

-- 
2.37.3