[PATCH v2 for-8.0 0/2] pci: drop redundant PCIDeviceClass::is_bridge field

Igor Mammedov posted 2 patches 1 year, 4 months ago
Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/qemu tags/patchew/20221129101341.185621-1-imammedo@redhat.com
Maintainers: "Michael S. Tsirkin" <mst@redhat.com>, Igor Mammedov <imammedo@redhat.com>, Ani Sinha <ani@anisinha.ca>, Marcel Apfelbaum <marcel.apfelbaum@gmail.com>, Paolo Bonzini <pbonzini@redhat.com>, Richard Henderson <richard.henderson@linaro.org>, Eduardo Habkost <eduardo@habkost.net>, Mark Cave-Ayland <mark.cave-ayland@ilande.co.uk>, Peter Maydell <peter.maydell@linaro.org>, Andrey Smirnov <andrew.smirnov@gmail.com>, Paul Burton <paulburton@kernel.org>, Aleksandar Rikalo <aleksandar.rikalo@syrmia.com>, Daniel Henrique Barboza <danielhb413@gmail.com>, "Cédric Le Goater" <clg@kaod.org>, David Gibson <david@gibson.dropbear.id.au>, Greg Kurz <groug@kaod.org>
hw/pci-bridge/dec.h                |   9 --
include/hw/pci/pci.h               |  11 +-
include/hw/pci/pci_bridge.h        |   1 +
include/hw/pci/pci_ids.h           |   1 -
hw/acpi/pcihp.c                    |   3 +-
hw/i386/acpi-build.c               |   5 +-
hw/pci-bridge/cxl_downstream.c     |   1 -
hw/pci-bridge/cxl_upstream.c       |   1 -
hw/pci-bridge/dec.c                | 164 -----------------------------
hw/pci-bridge/i82801b11.c          |   1 -
hw/pci-bridge/meson.build          |   2 -
hw/pci-bridge/pci_bridge_dev.c     |   1 -
hw/pci-bridge/pcie_pci_bridge.c    |   1 -
hw/pci-bridge/pcie_root_port.c     |   1 -
hw/pci-bridge/simba.c              |   1 -
hw/pci-bridge/xio3130_downstream.c |   1 -
hw/pci-bridge/xio3130_upstream.c   |   1 -
hw/pci-host/designware.c           |   1 -
hw/pci-host/uninorth.c             |   9 +-
hw/pci-host/xilinx-pcie.c          |   1 -
hw/pci/pci.c                       |  20 ++--
hw/ppc/spapr_pci.c                 |  15 +--
22 files changed, 23 insertions(+), 228 deletions(-)
delete mode 100644 hw/pci-bridge/dec.h
delete mode 100644 hw/pci-bridge/dec.c
[PATCH v2 for-8.0 0/2] pci: drop redundant PCIDeviceClass::is_bridge field
Posted by Igor Mammedov 1 year, 4 months ago
Changelog:
   - keep comment reminding that there was a bridge, so it would be easy to find
     removed code if someone wishes to bring it back
   - s/IS_PCI_BRIDGE/is_bridge/ in one instance where local is_bridge already exists

Igor Mammedov (2):
  remove DEC 21154 PCI bridge
  pci: drop redundant PCIDeviceClass::is_bridge field

 hw/pci-bridge/dec.h                |   9 --
 include/hw/pci/pci.h               |  11 +-
 include/hw/pci/pci_bridge.h        |   1 +
 include/hw/pci/pci_ids.h           |   1 -
 hw/acpi/pcihp.c                    |   3 +-
 hw/i386/acpi-build.c               |   5 +-
 hw/pci-bridge/cxl_downstream.c     |   1 -
 hw/pci-bridge/cxl_upstream.c       |   1 -
 hw/pci-bridge/dec.c                | 164 -----------------------------
 hw/pci-bridge/i82801b11.c          |   1 -
 hw/pci-bridge/meson.build          |   2 -
 hw/pci-bridge/pci_bridge_dev.c     |   1 -
 hw/pci-bridge/pcie_pci_bridge.c    |   1 -
 hw/pci-bridge/pcie_root_port.c     |   1 -
 hw/pci-bridge/simba.c              |   1 -
 hw/pci-bridge/xio3130_downstream.c |   1 -
 hw/pci-bridge/xio3130_upstream.c   |   1 -
 hw/pci-host/designware.c           |   1 -
 hw/pci-host/uninorth.c             |   9 +-
 hw/pci-host/xilinx-pcie.c          |   1 -
 hw/pci/pci.c                       |  20 ++--
 hw/ppc/spapr_pci.c                 |  15 +--
 22 files changed, 23 insertions(+), 228 deletions(-)
 delete mode 100644 hw/pci-bridge/dec.h
 delete mode 100644 hw/pci-bridge/dec.c

-- 
2.31.1
Re: [PATCH v2 for-8.0 0/2] pci: drop redundant PCIDeviceClass::is_bridge field
Posted by Igor Mammedov 1 year, 4 months ago
On Tue, 29 Nov 2022 11:13:39 +0100
Igor Mammedov <imammedo@redhat.com> wrote:

> Changelog:
>    - keep comment reminding that there was a bridge, so it would be easy to find
>      removed code if someone wishes to bring it back
>    - s/IS_PCI_BRIDGE/is_bridge/ in one instance where local is_bridge already exists

Michael,

can you merge this via PCI tree?

> 
> Igor Mammedov (2):
>   remove DEC 21154 PCI bridge
>   pci: drop redundant PCIDeviceClass::is_bridge field
> 
>  hw/pci-bridge/dec.h                |   9 --
>  include/hw/pci/pci.h               |  11 +-
>  include/hw/pci/pci_bridge.h        |   1 +
>  include/hw/pci/pci_ids.h           |   1 -
>  hw/acpi/pcihp.c                    |   3 +-
>  hw/i386/acpi-build.c               |   5 +-
>  hw/pci-bridge/cxl_downstream.c     |   1 -
>  hw/pci-bridge/cxl_upstream.c       |   1 -
>  hw/pci-bridge/dec.c                | 164 -----------------------------
>  hw/pci-bridge/i82801b11.c          |   1 -
>  hw/pci-bridge/meson.build          |   2 -
>  hw/pci-bridge/pci_bridge_dev.c     |   1 -
>  hw/pci-bridge/pcie_pci_bridge.c    |   1 -
>  hw/pci-bridge/pcie_root_port.c     |   1 -
>  hw/pci-bridge/simba.c              |   1 -
>  hw/pci-bridge/xio3130_downstream.c |   1 -
>  hw/pci-bridge/xio3130_upstream.c   |   1 -
>  hw/pci-host/designware.c           |   1 -
>  hw/pci-host/uninorth.c             |   9 +-
>  hw/pci-host/xilinx-pcie.c          |   1 -
>  hw/pci/pci.c                       |  20 ++--
>  hw/ppc/spapr_pci.c                 |  15 +--
>  22 files changed, 23 insertions(+), 228 deletions(-)
>  delete mode 100644 hw/pci-bridge/dec.h
>  delete mode 100644 hw/pci-bridge/dec.c
>
Re: [PATCH v2 for-8.0 0/2] pci: drop redundant PCIDeviceClass::is_bridge field
Posted by Michael S. Tsirkin 1 year, 4 months ago
On Wed, Dec 14, 2022 at 10:09:43AM +0100, Igor Mammedov wrote:
> On Tue, 29 Nov 2022 11:13:39 +0100
> Igor Mammedov <imammedo@redhat.com> wrote:
> 
> > Changelog:
> >    - keep comment reminding that there was a bridge, so it would be easy to find
> >      removed code if someone wishes to bring it back
> >    - s/IS_PCI_BRIDGE/is_bridge/ in one instance where local is_bridge already exists
> 
> Michael,
> 
> can you merge this via PCI tree?

Yes it's tagged. Busy with the linux pull req, qemu pull req next.
Thanks for the reminder!


> > 
> > Igor Mammedov (2):
> >   remove DEC 21154 PCI bridge
> >   pci: drop redundant PCIDeviceClass::is_bridge field
> > 
> >  hw/pci-bridge/dec.h                |   9 --
> >  include/hw/pci/pci.h               |  11 +-
> >  include/hw/pci/pci_bridge.h        |   1 +
> >  include/hw/pci/pci_ids.h           |   1 -
> >  hw/acpi/pcihp.c                    |   3 +-
> >  hw/i386/acpi-build.c               |   5 +-
> >  hw/pci-bridge/cxl_downstream.c     |   1 -
> >  hw/pci-bridge/cxl_upstream.c       |   1 -
> >  hw/pci-bridge/dec.c                | 164 -----------------------------
> >  hw/pci-bridge/i82801b11.c          |   1 -
> >  hw/pci-bridge/meson.build          |   2 -
> >  hw/pci-bridge/pci_bridge_dev.c     |   1 -
> >  hw/pci-bridge/pcie_pci_bridge.c    |   1 -
> >  hw/pci-bridge/pcie_root_port.c     |   1 -
> >  hw/pci-bridge/simba.c              |   1 -
> >  hw/pci-bridge/xio3130_downstream.c |   1 -
> >  hw/pci-bridge/xio3130_upstream.c   |   1 -
> >  hw/pci-host/designware.c           |   1 -
> >  hw/pci-host/uninorth.c             |   9 +-
> >  hw/pci-host/xilinx-pcie.c          |   1 -
> >  hw/pci/pci.c                       |  20 ++--
> >  hw/ppc/spapr_pci.c                 |  15 +--
> >  22 files changed, 23 insertions(+), 228 deletions(-)
> >  delete mode 100644 hw/pci-bridge/dec.h
> >  delete mode 100644 hw/pci-bridge/dec.c
> >