Add format attributes and fix format strings

[PATCH v3 for-7.2 0/6] Add format attributes and fix format strings

Posted by Stefan Weil via 1 year, 5 months ago

v3:
- Fix description for patch 3
- Add patches 5 and 6

The patches 3 and 5 still need reviews!

[PATCH v3 for-7.2 1/6] libvhost-user: Fix wrong type of argument to
[PATCH v3 for-7.2 2/6] libvhost-user: Fix format strings
[PATCH v3 for-7.2 3/6] libvhost-user: Fix two more format strings
[PATCH v3 for-7.2 4/6] libvhost-user: Add format attribute to local
[PATCH v3 for-7.2 5/6] MAINTAINERS: Add subprojects/libvhost-user to
[PATCH v3 for-7.2 6/6] Add G_GNUC_PRINTF to function

Re: [PATCH v3 for-7.2 0/6] Add format attributes and fix format strings

Posted by Michael S. Tsirkin 1 year, 4 months ago

On Sat, Nov 26, 2022 at 04:25:01PM +0100, Stefan Weil wrote:
> v3:
> - Fix description for patch 3
> - Add patches 5 and 6
> 
> The patches 3 and 5 still need reviews!

Series:
Reviewed-by: Michael S. Tsirkin <mst@redhat.com>

Stefan you said you want to merge this?

> [PATCH v3 for-7.2 1/6] libvhost-user: Fix wrong type of argument to
> [PATCH v3 for-7.2 2/6] libvhost-user: Fix format strings
> [PATCH v3 for-7.2 3/6] libvhost-user: Fix two more format strings
> [PATCH v3 for-7.2 4/6] libvhost-user: Add format attribute to local
> [PATCH v3 for-7.2 5/6] MAINTAINERS: Add subprojects/libvhost-user to
> [PATCH v3 for-7.2 6/6] Add G_GNUC_PRINTF to function

Re: [PATCH v3 for-7.2 0/6] Add format attributes and fix format strings

Posted by Stefan Hajnoczi 1 year, 4 months ago

On Mon, Nov 28, 2022, 05:29 Michael S. Tsirkin <mst@redhat.com> wrote:

> On Sat, Nov 26, 2022 at 04:25:01PM +0100, Stefan Weil wrote:
> > v3:
> > - Fix description for patch 3
> > - Add patches 5 and 6
> >
> > The patches 3 and 5 still need reviews!
>
> Series:
> Reviewed-by: Michael S. Tsirkin <mst@redhat.com>
>
> Stefan you said you want to merge this?
>

Yes.

Stefan

>

Re: [PATCH v3 for-7.2 0/6] Add format attributes and fix format strings

Posted by Stefan Hajnoczi 1 year, 4 months ago

Applied, thanks.

Please update the changelog at https://wiki.qemu.org/ChangeLog/7.2 for any user-visible changes.

Re: [PATCH v3 for-7.2 0/6] Add format attributes and fix format strings

Posted by Stefan Hajnoczi 1 year, 4 months ago

We need to wait for Michael to agree to maintainership in patch 5. If
we run out of time I suggest splitting out patch 5.

Reviewed-by: Stefan Hajnoczi <stefanha@redhat.com>

Re: [PATCH v3 for-7.2 0/6] Add format attributes and fix format strings

Posted by Stefan Weil via 1 year, 4 months ago

Am 27.11.22 um 19:23 schrieb Stefan Hajnoczi:

> We need to wait for Michael to agree to maintainership in patch 5. If
> we run out of time I suggest splitting out patch 5.
>
> Reviewed-by: Stefan Hajnoczi<stefanha@redhat.com>


Citing Michael from a v2 email: "pls do".

Stefan


>     Hello Michael,
>
>     I just noticed that MAINTAINERS has no entry for the files in
>     subprojects/libvhost-user, so I did not cc you in my previous e-mails.
>     Should that directory be added to the "vhost" section"?
>
>     Stefan

    pls do

Re: [PATCH v3 for-7.2 0/6] Add format attributes and fix format strings

Posted by Stefan Hajnoczi 1 year, 4 months ago

On Sun, 27 Nov 2022 at 13:31, Stefan Weil <sw@weilnetz.de> wrote:
>
> Am 27.11.22 um 19:23 schrieb Stefan Hajnoczi:
>
> We need to wait for Michael to agree to maintainership in patch 5. If
> we run out of time I suggest splitting out patch 5.
>
> Reviewed-by: Stefan Hajnoczi <stefanha@redhat.com>
>
>
> Citing Michael from a v2 email: "pls do".
>
> Stefan
>
>
> Hello Michael,
>
> I just noticed that MAINTAINERS has no entry for the files in
> subprojects/libvhost-user, so I did not cc you in my previous e-mails.
> Should that directory be added to the "vhost" section"?
>
> Stefan
>
> pls do

Perfect, thank you! I have added a reference to that email in the
commit description.

This series is running through CI now and will be merged upon success
later today.

Thanks,
Stefan