[v2] Two -Wclobbered fixes, plus other cleanup

[PATCH v2 0/6] Two -Wclobbered fixes, plus other cleanup

Richard Henderson posted 6 patches 1 year, 5 months ago

Diff against v1 v1
Download series mbox

Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/qemu tags/patchew/20221106212852.152384-1-richard.henderson@linaro.org

Maintainers: Richard Henderson <richard.henderson@linaro.org>, Paolo Bonzini <pbonzini@redhat.com>, Stefan Pejic <stefan.pejic@syrmia.com>, "Philippe Mathieu-Daudé" <philmd@linaro.org>, Jiaxun Yang <jiaxun.yang@flygoat.com>

accel/tcg/translate-all.c |  68 ++++++++++++-----------
disas/nanomips.c          | 110 ++++++++++++++++----------------------
tcg/tcg.c                 |  12 +++++
3 files changed, 90 insertions(+), 100 deletions(-)

Expand all Fold all

[PATCH v2 0/6] Two -Wclobbered fixes, plus other cleanup

Posted by Richard Henderson 1 year, 5 months ago

Stefan reported for accel/tcg, and I reproduced on Ubuntu 22.04.

Changes for v2:
  * Incorporate suggested changes to nanomips.c (phil, balaton).


r~


Richard Henderson (6):
  disas/nanomips: Move setjmp into nanomips_dis
  disas/nanomips: Merge insn{1,2,3} into words[3]
  disas/nanomips: Split out read_u16
  disas/nanomips: Tidy read for 48-bit opcodes
  tcg: Move TCG_TARGET_HAS_direct_jump init to tb_gen_code
  accel/tcg: Split out setjmp_gen_code

 accel/tcg/translate-all.c |  68 ++++++++++++-----------
 disas/nanomips.c          | 110 ++++++++++++++++----------------------
 tcg/tcg.c                 |  12 +++++
 3 files changed, 90 insertions(+), 100 deletions(-)

-- 
2.34.1

Re: [PATCH v2 0/6] Two -Wclobbered fixes, plus other cleanup

Posted by Philippe Mathieu-Daudé 1 year, 5 months ago

On 6/11/22 22:28, Richard Henderson wrote:
> Stefan reported for accel/tcg, and I reproduced on Ubuntu 22.04.
> 
> Changes for v2:
>    * Incorporate suggested changes to nanomips.c (phil, balaton).

Thanks for v2, it was an optional review change request from my
side, but I appreciate the change, the result is cleaner.

> Richard Henderson (6):
>    disas/nanomips: Move setjmp into nanomips_dis
>    disas/nanomips: Merge insn{1,2,3} into words[3]
>    disas/nanomips: Split out read_u16
>    disas/nanomips: Tidy read for 48-bit opcodes

I'm queuing the nanomips patches via mips-fixes.

Regards,

Phil.