[v1] pci,pc,virtio: features, tests, fixes, cleanups

[PULL 01/86] bios-tables-test: do not ignore allowed diff list

Michael S. Tsirkin posted 86 patches 3 years, 3 months ago

Diff against v2 v3 v4
Download mbox

Maintainers: "Gonglei (Arei)" <arei.gonglei@huawei.com>, "Daniel P. Berrangé" <berrange@redhat.com>, Ani Sinha <ani@anisinha.ca>, "Michael S. Tsirkin" <mst@redhat.com>, Igor Mammedov <imammedo@redhat.com>, Peter Maydell <peter.maydell@linaro.org>, Shannon Zhao <shannon.zhaosl@gmail.com>, Raphael Norwitz <raphael.norwitz@nutanix.com>, Kevin Wolf <kwolf@redhat.com>, Hanna Reitz <hreitz@redhat.com>, Eduardo Habkost <eduardo@habkost.net>, Marcel Apfelbaum <marcel.apfelbaum@gmail.com>, "Philippe Mathieu-Daudé" <philmd@linaro.org>, Yanan Wang <wangyanan55@huawei.com>, Ben Widawsky <ben.widawsky@intel.com>, Jonathan Cameron <jonathan.cameron@huawei.com>, Gerd Hoffmann <kraxel@redhat.com>, Paolo Bonzini <pbonzini@redhat.com>, Richard Henderson <richard.henderson@linaro.org>, Peter Xu <peterx@redhat.com>, Jason Wang <jasowang@redhat.com>, Sergio Lopez <slp@redhat.com>, John Snow <jsnow@redhat.com>, Dmitry Fleytman <dmitry.fleytman@gmail.com>, Jiri Pirko <jiri@resnulli.us>, Keith Busch <kbusch@kernel.org>, Klaus Jensen <its@irrelevant.dk>, Huai-Cheng Kuo <hchkuo@avery-design.com.tw>, Chris Browy <cbrowy@avery-design.com>, Yuval Shaia <yuval.shaia.ml@gmail.com>, Elena Ufimtseva <elena.ufimtseva@oracle.com>, Jagannathan Raman <jag.raman@oracle.com>, John G Johnson <john.g.johnson@oracle.com>, Alex Williamson <alex.williamson@redhat.com>, Eric Auger <eric.auger@redhat.com>, David Hildenbrand <david@redhat.com>, Eric Blake <eblake@redhat.com>, Markus Armbruster <armbru@redhat.com>, Cleber Rosa <crosa@redhat.com>, Wainer dos Santos Moschetta <wainersm@redhat.com>, Beraldo Leal <bleal@redhat.com>, Thomas Huth <thuth@redhat.com>, Laurent Vivier <lvivier@redhat.com>

There is a newer version of this series

Expand all Fold all

[PULL 01/86] bios-tables-test: do not ignore allowed diff list

Posted by Michael S. Tsirkin 3 years, 3 months ago

we had such a beautiful structure for updating
expected files, designed to keep bisect working.
It turns out that we ignored the result of
the allow list checks unless all tables matched
anyway.

Sigh.

Let's at least make it work going forward.

Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
---
 tests/qtest/bios-tables-test.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/tests/qtest/bios-tables-test.c b/tests/qtest/bios-tables-test.c
index e6096e7f73..a72f6ca326 100644
--- a/tests/qtest/bios-tables-test.c
+++ b/tests/qtest/bios-tables-test.c
@@ -458,7 +458,7 @@ static void test_acpi_asl(test_data *data)
                 "for instructions on how to update expected files.\n",
                 exp_sdt->aml, sdt->aml_file, exp_sdt->aml_file);
 
-        all_tables_match = all_tables_match &&
+        all_tables_match = all_tables_match ||
             test_acpi_find_diff_allowed(exp_sdt);
 
         /*
-- 
MST

Re: [PULL 01/86] bios-tables-test: do not ignore allowed diff list

Posted by Ani Sinha 3 years, 3 months ago

On Mon, Oct 31, 2022 at 6:20 PM Michael S. Tsirkin <mst@redhat.com> wrote:

> we had such a beautiful structure for updating
> expected files, designed to keep bisect working.
> It turns out that we ignored the result of
> the allow list checks unless all tables matched
> anyway.
>
> Sigh.
>
> Let's at least make it work going forward.


Don't forget to drop this.


>
> Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
> ---
>  tests/qtest/bios-tables-test.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/tests/qtest/bios-tables-test.c
> b/tests/qtest/bios-tables-test.c
> index e6096e7f73..a72f6ca326 100644
> --- a/tests/qtest/bios-tables-test.c
> +++ b/tests/qtest/bios-tables-test.c
> @@ -458,7 +458,7 @@ static void test_acpi_asl(test_data *data)
>                  "for instructions on how to update expected files.\n",
>                  exp_sdt->aml, sdt->aml_file, exp_sdt->aml_file);
>
> -        all_tables_match = all_tables_match &&
> +        all_tables_match = all_tables_match ||
>              test_acpi_find_diff_allowed(exp_sdt);
>
>          /*
> --
> MST
>
>

Re: [PULL 01/86] bios-tables-test: do not ignore allowed diff list

Posted by Michael S. Tsirkin 3 years, 3 months ago

On Mon, Oct 31, 2022 at 06:55:04PM +0530, Ani Sinha wrote:
> 
> 
> On Mon, Oct 31, 2022 at 6:20 PM Michael S. Tsirkin <mst@redhat.com> wrote:
> 
>     we had such a beautiful structure for updating
>     expected files, designed to keep bisect working.
>     It turns out that we ignored the result of
>     the allow list checks unless all tables matched
>     anyway.
> 
>     Sigh.
> 
>     Let's at least make it work going forward.
> 
> 
> Don't forget to drop this. 


Ugh. ENOCOFFE. I will re-push without this.

> 
> 
> 
>     Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
>     ---
>      tests/qtest/bios-tables-test.c | 2 +-
>      1 file changed, 1 insertion(+), 1 deletion(-)
> 
>     diff --git a/tests/qtest/bios-tables-test.c b/tests/qtest/
>     bios-tables-test.c
>     index e6096e7f73..a72f6ca326 100644
>     --- a/tests/qtest/bios-tables-test.c
>     +++ b/tests/qtest/bios-tables-test.c
>     @@ -458,7 +458,7 @@ static void test_acpi_asl(test_data *data)
>                      "for instructions on how to update expected files.\n",
>                      exp_sdt->aml, sdt->aml_file, exp_sdt->aml_file);
> 
>     -        all_tables_match = all_tables_match &&
>     +        all_tables_match = all_tables_match ||
>                  test_acpi_find_diff_allowed(exp_sdt);
> 
>              /*
>     --
>     MST
> 
>