Add nsis.py to W32/W64 section in MAINTAINERS

[PATCH] Add nsis.py to W32/W64 section in MAINTAINERS

Posted by Stefan Weil via 1 year, 6 months ago

Signed-off-by: Stefan Weil <sw@weilnetz.de>
---
 MAINTAINERS | 1 +
 1 file changed, 1 insertion(+)

diff --git a/MAINTAINERS b/MAINTAINERS
index 64893e36bc..534b1b8a63 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -548,6 +548,7 @@ F: */*win32*
 F: include/*/*win32*
 X: qga/*win32*
 F: qemu.nsi
+F: scripts/nsis.py
 
 Darwin (macOS, iOS)
 M: Philippe Mathieu-Daudé <philmd@linaro.org>
-- 
2.30.2

Re: [PATCH] Add nsis.py to W32/W64 section in MAINTAINERS

Posted by Philippe Mathieu-Daudé 1 year, 6 months ago

On 31/10/22 10:57, Stefan Weil via wrote:
> Signed-off-by: Stefan Weil <sw@weilnetz.de>
> ---
>   MAINTAINERS | 1 +
>   1 file changed, 1 insertion(+)

Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>

Re: [PATCH] Add nsis.py to W32/W64 section in MAINTAINERS

Posted by Stefan Weil via 1 year, 6 months ago

Am 31.10.22 um 11:28 schrieb Philippe Mathieu-Daudé:

> On 31/10/22 10:57, Stefan Weil via wrote:
>> Signed-off-by: Stefan Weil <sw@weilnetz.de>
>> ---
>>   MAINTAINERS | 1 +
>>   1 file changed, 1 insertion(+)
>
> Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>


Cc qemu-trivial

Re: [PATCH] Add nsis.py to W32/W64 section in MAINTAINERS

Posted by Laurent Vivier 1 year, 6 months ago

Le 31/10/2022 à 14:17, Stefan Weil via a écrit :
> Am 31.10.22 um 11:28 schrieb Philippe Mathieu-Daudé:
> 
>> On 31/10/22 10:57, Stefan Weil via wrote:
>>> Signed-off-by: Stefan Weil <sw@weilnetz.de>
>>> ---
>>>   MAINTAINERS | 1 +
>>>   1 file changed, 1 insertion(+)
>>
>> Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>
> 
> 
> Cc qemu-trivial
> 
> 
> 

If I'm right, this change has already been merged by:

commit 48fad83ff49bd47368223cf1121351f51cf3565f
Author: Alex Bennée <alex.bennee@linaro.org>
Date:   Thu Oct 27 19:36:21 2022 +0100

     MAINTAINERS: add entries for the key build bits

     Changes to the build files are a bit special in that they usually go
     through other maintainer trees. However considering the build system
     is the root of everything a developer is likely to do we should at
     least set it out in MAINTAINERS.

     I'm going to nominate Paolo for meson stuff given the conversion was
     his passion project. I'm happy to cast an eye over configure stuff
     considering a lot of the cross compile logic is in there anyway.

     Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>
     Signed-off-by: Alex Bennée <alex.bennee@linaro.org>
     Acked-by: Thomas Huth <thuth@redhat.com>
     Cc: Paolo Bonzini <pbonzini@redhat.com>
     Message-Id: <20221027183637.2772968-16-alex.bennee@linaro.org>

Thanks,
Laurent

Re: [PATCH] Add nsis.py to W32/W64 section in MAINTAINERS

Posted by Marc-André Lureau 1 year, 6 months ago

On Mon, Oct 31, 2022 at 1:57 PM Stefan Weil <sw@weilnetz.de> wrote:
>
> Signed-off-by: Stefan Weil <sw@weilnetz.de>

thanks
Reviewed-by: Marc-André Lureau <marcandre.lureau@redhat.com>


> ---
>  MAINTAINERS | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/MAINTAINERS b/MAINTAINERS
> index 64893e36bc..534b1b8a63 100644
> --- a/MAINTAINERS
> +++ b/MAINTAINERS
> @@ -548,6 +548,7 @@ F: */*win32*
>  F: include/*/*win32*
>  X: qga/*win32*
>  F: qemu.nsi
> +F: scripts/nsis.py
>
>  Darwin (macOS, iOS)
>  M: Philippe Mathieu-Daudé <philmd@linaro.org>
> --
> 2.30.2
>


-- 
Marc-André Lureau