On Wed, 26 Oct 2022 at 14:44, Markus Armbruster <armbru@redhat.com> wrote:
>
> The following changes since commit e750a7ace492f0b450653d4ad368a77d6f660fb8:
>
> Merge tag 'pull-9p-20221024' of https://github.com/cschoenebeck/qemu into staging (2022-10-24 14:27:12 -0400)
>
> are available in the Git repository at:
>
> https://repo.or.cz/qemu/armbru.git tags/pull-qapi-2022-10-25-v2
>
> for you to fetch changes up to c0f24f8f31ca82e34ef037bfe34ef71eeecb401d:
>
> qapi: Drop temporary logic to support conversion step by step (2022-10-26 20:08:52 +0200)
>
> ----------------------------------------------------------------
> QAPI patches patches for 2022-10-25
>
> ----------------------------------------------------------------
> Markus Armbruster (28):
> docs/devel/qapi-code-gen: Update example to match current code
> qapi: Tidy up whitespace in generated code
> docs/devel/qapi-code-gen: Extend example for next commit's change
> qapi: Start to elide redundant has_FOO in generated C
> qapi tests: Elide redundant has_FOO in generated C
> qapi acpi: Elide redundant has_FOO in generated C
> qapi audio: Elide redundant has_FOO in generated C
> qapi block: Elide redundant has_FOO in generated C
This commit breaks qemu-iotests 056 in CI. I have included
instructions for reproducing it locally below. I will drop this pull
request for now. Please note that the QEMU 7.2 soft freeze is on
Tuesday.
$ ./configure --target-list=x86_64-softmmu --disable-tcg
--audio-drv-list="" --with-coroutine=ucontext && make
$ (cd build && tests/qemu-iotests/check -qcow2 056)
$ coredumpctl debug
(gdb) bt
#0 __pthread_kill_implementation (threadid=<optimized out>,
signo=signo@entry=6, no_tid=no_tid@entry=0) at pthread_kill.c:44
#1 0x00007f23b81f3c73 in __pthread_kill_internal (signo=6,
threadid=<optimized out>) at pthread_kill.c:78
#2 0x00007f23b81a3986 in __GI_raise (sig=sig@entry=6) at
../sysdeps/posix/raise.c:26
#3 0x00007f23b818d7f4 in __GI_abort () at abort.c:79
#4 0x00007f23b81e7d5e in __libc_message
(action=action@entry=do_abort, fmt=fmt@entry=0x7f23b831f87c "%s\n") at
../sysdeps/posix/libc_fatal.c:155
#5 0x00007f23b81fd95c in malloc_printerr
(str=str@entry=0x7f23b8321ed0 "munmap_chunk(): invalid pointer") at
malloc.c:5659
#6 0x00007f23b81fdbdc in munmap_chunk (p=<optimized out>) at malloc.c:3055
#7 0x00007f23b820214a in __GI___libc_free
(mem=mem@entry=0x560ca9395354) at malloc.c:3376
#8 0x00007f23b9794b8d in g_free (mem=0x560ca9395354) at ../glib/gmem.c:218
#9 0x0000560ca920bf81 in qapi_dealloc_type_str (v=<optimized out>,
name=<optimized out>, obj=<optimized out>, errp=<optimized out>) at
../qapi/qapi-dealloc-visitor.c:68
#10 0x0000560ca920f1ac in visit_type_str (v=v@entry=0x560cacb85000,
name=name@entry=0x560ca93bde6c "format", obj=obj@entry=0x7ffe123a1480,
errp=errp@entry=0x0)
at ../qapi/qapi-visit-core.c:349
#11 0x0000560ca919ae8a in visit_type_DriveBackup_members
(v=v@entry=0x560cacb85000, obj=obj@entry=0x7ffe123a1420,
errp=errp@entry=0x0) at qapi/qapi-visit-block-core.c:2401
#12 0x0000560ca91acee1 in qmp_marshal_drive_backup (args=<optimized
out>, ret=<optimized out>, errp=<optimized out>) at
qapi/qapi-commands-block-core.c:464
#13 0x0000560ca9213299 in do_qmp_dispatch_bh (opaque=0x7f23b2bc3ea0)
at ../qapi/qmp-dispatch.c:128
#14 0x0000560ca922efa5 in aio_bh_call (bh=0x560cabee1dd0) at ../util/async.c:150
#15 aio_bh_poll (ctx=ctx@entry=0x560cabc83300) at ../util/async.c:178
#16 0x0000560ca921c9be in aio_dispatch (ctx=0x560cabc83300) at
../util/aio-posix.c:421
#17 0x0000560ca922ec0e in aio_ctx_dispatch (source=<optimized out>,
callback=<optimized out>, user_data=<optimized out>) at
../util/async.c:320
#18 0x00007f23b9792faf in g_main_dispatch (context=0x560cabc83c60) at
../glib/gmain.c:3417
#19 g_main_context_dispatch (context=0x560cabc83c60) at ../glib/gmain.c:4135
#20 0x0000560ca923b028 in glib_pollfds_poll () at ../util/main-loop.c:297
#21 os_host_main_loop_wait (timeout=0) at ../util/main-loop.c:320
#22 main_loop_wait (nonblocking=nonblocking@entry=0) at ../util/main-loop.c:596
#23 0x0000560ca8f0ce07 in qemu_main_loop () at ../softmmu/runstate.c:734
#24 0x0000560ca8d45c96 in qemu_default_main () at ../softmmu/main.c:37
#25 0x00007f23b818e510 in __libc_start_call_main
(main=main@entry=0x560ca8d41050 <main>, argc=argc@entry=20,
argv=argv@entry=0x7ffe123a1808) at
../sysdeps/nptl/libc_start_call_main.h:58
#26 0x00007f23b818e5c9 in __libc_start_main_impl
(main=0x560ca8d41050 <main>, argc=20, argv=0x7ffe123a1808,
init=<optimized out>, fini=<optimized out>, rtld_fini=<optimized out>,
stack_end=0x7ffe123a17f8) at ../csu/libc-start.c:389
#27 0x0000560ca8d45bc5 in _start ()
(gdb) up
#1 0x00007f23b81f3c73 in __pthread_kill_internal (signo=6,
threadid=<optimized out>) at pthread_kill.c:78
78 return __pthread_kill_implementation (threadid, signo, 0);
(gdb) up
#2 0x00007f23b81a3986 in __GI_raise (sig=sig@entry=6) at
../sysdeps/posix/raise.c:26
Downloading 0.00 MB source file
/usr/src/debug/glibc-2.35-20.fc36.x86_64/signal/../sysdeps/posix/raise.c
26 int ret = __pthread_kill (__pthread_self (), sig);
(gdb) up
#3 0x00007f23b818d7f4 in __GI_abort () at abort.c:79
Downloading 0.00 MB source file
/usr/src/debug/glibc-2.35-20.fc36.x86_64/stdlib/abort.c
79 raise (SIGABRT);
(gdb) up
#4 0x00007f23b81e7d5e in __libc_message
(action=action@entry=do_abort, fmt=fmt@entry=0x7f23b831f87c "%s\n") at
../sysdeps/posix/libc_fatal.c:155
Downloading 0.00 MB source file
/usr/src/debug/glibc-2.35-20.fc36.x86_64/libio/../sysdeps/posix/libc_fatal.c
155 abort ();
(gdb) up
#5 0x00007f23b81fd95c in malloc_printerr
(str=str@entry=0x7f23b8321ed0 "munmap_chunk(): invalid pointer") at
malloc.c:5659
Downloading 0.05 MB source file
/usr/src/debug/glibc-2.35-20.fc36.x86_64/malloc/malloc.c
5659 __libc_message (do_abort, "%s\n", str);
(gdb) up
#6 0x00007f23b81fdbdc in munmap_chunk (p=<optimized out>) at malloc.c:3055
3055 malloc_printerr ("munmap_chunk(): invalid pointer");
(gdb) up
#7 0x00007f23b820214a in __GI___libc_free
(mem=mem@entry=0x560ca9395354) at malloc.c:3376
3376 munmap_chunk (p);
(gdb) up
#8 0x00007f23b9794b8d in g_free (mem=0x560ca9395354) at ../glib/gmem.c:218
Downloading 0.00 MB source file
/usr/src/debug/glib2-2.72.3-1.fc36.x86_64/redhat-linux-build/../glib/gmem.c
218 free (mem);
(gdb) up
#9 0x0000560ca920bf81 in qapi_dealloc_type_str (v=<optimized out>,
name=<optimized out>, obj=<optimized out>, errp=<optimized out>) at
../qapi/qapi-dealloc-visitor.c:68
68 g_free(*obj);
(gdb) up
#10 0x0000560ca920f1ac in visit_type_str (v=v@entry=0x560cacb85000,
name=name@entry=0x560ca93bde6c "format", obj=obj@entry=0x7ffe123a1480,
errp=errp@entry=0x0)
at ../qapi/qapi-visit-core.c:349
349 ok = v->type_str(v, name, obj, errp);
(gdb) up
#11 0x0000560ca919ae8a in visit_type_DriveBackup_members
(v=v@entry=0x560cacb85000, obj=obj@entry=0x7ffe123a1420,
errp=errp@entry=0x0) at qapi/qapi-visit-block-core.c:2401
2401 if (!visit_type_str(v, "format", &obj->format, errp)) {
(gdb) p *obj
$1 = {job_id = 0x0, device = 0x560cacb99c10 "\031\365&\313\tV", sync =
MIRROR_SYNC_MODE_NONE, has_speed = false, speed = 0, bitmap = 0x0,
has_bitmap_mode = false,
bitmap_mode = BITMAP_SYNC_MODE_ON_SUCCESS, has_compress = false,
compress = false, has_on_source_error = false, on_source_error =
BLOCKDEV_ON_ERROR_REPORT, has_on_target_error = false,
on_target_error = BLOCKDEV_ON_ERROR_REPORT, has_auto_finalize =
false, auto_finalize = true, has_auto_dismiss = false, auto_dismiss =
true, filter_node_name = 0x0, x_perf = 0x0,
target = 0x560cabf01930 "\301\070r\314\tV", format = 0x560ca9395354
"qcow2", has_mode = false, mode = NEW_IMAGE_MODE_ABSOLUTE_PATHS}