Signed-off-by: Laurent Vivier <lvivier@redhat.com>
Acked-by: Michael S. Tsirkin <mst@redhat.com>
---
tests/qtest/meson.build | 1 +
tests/qtest/netdev-socket.c | 420 ++++++++++++++++++++++++++++++++++++
2 files changed, 421 insertions(+)
create mode 100644 tests/qtest/netdev-socket.c
diff --git a/tests/qtest/meson.build b/tests/qtest/meson.build
index c07a5b1a5f43..6953797e4e3e 100644
--- a/tests/qtest/meson.build
+++ b/tests/qtest/meson.build
@@ -27,6 +27,7 @@ qtests_generic = [
'test-hmp',
'qos-test',
'readconfig-test',
+ 'netdev-socket',
]
if config_host.has_key('CONFIG_MODULES')
qtests_generic += [ 'modules-test' ]
diff --git a/tests/qtest/netdev-socket.c b/tests/qtest/netdev-socket.c
new file mode 100644
index 000000000000..b24c0819b9ac
--- /dev/null
+++ b/tests/qtest/netdev-socket.c
@@ -0,0 +1,420 @@
+/*
+ * QTest testcase for netdev stream and dgram
+ *
+ * Copyright (c) 2022 Red Hat, Inc.
+ *
+ * SPDX-License-Identifier: GPL-2.0-or-later
+ */
+
+#include "qemu/osdep.h"
+#include "libqtest.h"
+
+#define CONNECTION_TIMEOUT 5
+
+#define EXPECT_STATE(q, e, t) \
+do { \
+ char *resp = qtest_hmp(q, "info network"); \
+ if (t) { \
+ strrchr(resp, t)[0] = 0; \
+ } \
+ g_test_timer_start(); \
+ while (g_test_timer_elapsed() < CONNECTION_TIMEOUT) { \
+ if (strcmp(resp, e) == 0) { \
+ break; \
+ } \
+ g_free(resp); \
+ resp = qtest_hmp(q, "info network"); \
+ if (t) { \
+ strrchr(resp, t)[0] = 0; \
+ } \
+ } \
+ g_assert_cmpstr(resp, ==, e); \
+ g_free(resp); \
+} while (0)
+
+static int inet_get_free_port_socket(int sock)
+{
+ struct sockaddr_in addr;
+ socklen_t len;
+
+ memset(&addr, 0, sizeof(addr));
+ addr.sin_family = AF_INET;
+ addr.sin_addr.s_addr = INADDR_ANY;
+ addr.sin_port = 0;
+ if (bind(sock, (struct sockaddr *)&addr, sizeof(addr)) < 0) {
+ return -1;
+ }
+
+ len = sizeof(addr);
+ if (getsockname(sock, (struct sockaddr *)&addr, &len) < 0) {
+ return -1;
+ }
+
+ return ntohs(addr.sin_port);
+}
+
+static int inet_get_free_port_multiple(int nb, int *port)
+{
+ int sock[nb];
+ int i;
+
+ for (i = 0; i < nb; i++) {
+ sock[i] = socket(AF_INET, SOCK_STREAM, 0);
+ if (sock[i] < 0) {
+ break;
+ }
+ port[i] = inet_get_free_port_socket(sock[i]);
+ }
+
+ nb = i;
+ for (i = 0; i < nb; i++) {
+ closesocket(sock[i]);
+ }
+
+ return nb;
+}
+
+static int inet_get_free_port(void)
+{
+ int nb, port;
+
+ nb = inet_get_free_port_multiple(1, &port);
+ g_assert_cmpint(nb, ==, 1);
+
+ return port;
+}
+
+static void test_stream_inet_ipv4(void)
+{
+ QTestState *qts0, *qts1;
+ char *expect;
+ int port;
+
+ port = inet_get_free_port();
+ qts0 = qtest_initf("-nodefaults "
+ "-netdev stream,id=st0,server=true,addr.type=inet,"
+ "addr.ipv4=on,addr.ipv6=off,"
+ "addr.host=localhost,addr.port=%d", port);
+
+ EXPECT_STATE(qts0, "st0: index=0,type=stream,\r\n", 0);
+
+ qts1 = qtest_initf("-nodefaults "
+ "-netdev stream,server=false,id=st0,addr.type=inet,"
+ "addr.ipv4=on,addr.ipv6=off,"
+ "addr.host=localhost,addr.port=%d", port);
+
+ expect = g_strdup_printf("st0: index=0,type=stream,tcp:127.0.0.1:%d\r\n",
+ port);
+ EXPECT_STATE(qts1, expect, 0);
+ g_free(expect);
+
+ /* the port is unknown, check only the address */
+ EXPECT_STATE(qts0, "st0: index=0,type=stream,tcp:127.0.0.1", ':');
+
+ qtest_quit(qts1);
+ qtest_quit(qts0);
+}
+
+static void test_stream_inet_ipv6(void)
+{
+ QTestState *qts0, *qts1;
+ char *expect;
+ int port;
+
+ port = inet_get_free_port();
+ qts0 = qtest_initf("-nodefaults "
+ "-netdev stream,id=st0,server=true,addr.type=inet,"
+ "addr.ipv4=off,addr.ipv6=on,"
+ "addr.host=localhost,addr.port=%d", port);
+
+ EXPECT_STATE(qts0, "st0: index=0,type=stream,\r\n", 0);
+
+ qts1 = qtest_initf("-nodefaults "
+ "-netdev stream,server=false,id=st0,addr.type=inet,"
+ "addr.ipv4=off,addr.ipv6=on,"
+ "addr.host=localhost,addr.port=%d", port);
+
+ expect = g_strdup_printf("st0: index=0,type=stream,tcp:::1:%d\r\n",
+ port);
+ EXPECT_STATE(qts1, expect, 0);
+ g_free(expect);
+
+ /* the port is unknown, check only the address */
+ EXPECT_STATE(qts0, "st0: index=0,type=stream,tcp:::1", ':');
+
+ qtest_quit(qts1);
+ qtest_quit(qts0);
+}
+
+static void test_stream_unix(void)
+{
+ QTestState *qts0, *qts1;
+ char *expect;
+ gchar *path;
+ int ret;
+
+ ret = g_file_open_tmp("netdev-XXXXXX", &path, NULL);
+ g_assert_true(ret >= 0);
+ close(ret);
+
+ qts0 = qtest_initf("-nodefaults "
+ "-netdev stream,id=st0,server=true,"
+ "addr.type=unix,addr.path=%s,",
+ path);
+
+ EXPECT_STATE(qts0, "st0: index=0,type=stream,\r\n", 0);
+
+ qts1 = qtest_initf("-nodefaults "
+ "-netdev stream,id=st0,server=false,"
+ "addr.type=unix,addr.path=%s",
+ path);
+
+ expect = g_strdup_printf("st0: index=0,type=stream,unix:%s\r\n", path);
+ EXPECT_STATE(qts1, expect, 0);
+ EXPECT_STATE(qts0, expect, 0);
+ g_free(expect);
+ unlink(path);
+ g_free(path);
+
+ qtest_quit(qts1);
+ qtest_quit(qts0);
+}
+
+static void test_stream_unix_abstract(void)
+{
+ QTestState *qts0, *qts1;
+ char *expect;
+ gchar *path;
+ int ret;
+
+ ret = g_file_open_tmp("netdev-XXXXXX", &path, NULL);
+ g_assert_true(ret >= 0);
+ close(ret);
+
+ qts0 = qtest_initf("-nodefaults "
+ "-netdev stream,id=st0,server=true,"
+ "addr.type=unix,addr.path=%s,"
+ "addr.abstract=on",
+ path);
+
+ EXPECT_STATE(qts0, "st0: index=0,type=stream,\r\n", 0);
+
+ qts1 = qtest_initf("-nodefaults "
+ "-netdev stream,id=st0,server=false,"
+ "addr.type=unix,addr.path=%s,addr.abstract=on",
+ path);
+
+ expect = g_strdup_printf("st0: index=0,type=stream,unix:%s\r\n", path);
+ EXPECT_STATE(qts1, expect, 0);
+ EXPECT_STATE(qts0, expect, 0);
+ g_free(expect);
+ unlink(path);
+ g_free(path);
+
+ qtest_quit(qts1);
+ qtest_quit(qts0);
+}
+
+static void test_stream_fd(void)
+{
+ QTestState *qts0, *qts1;
+ char *expect;
+ int ret, sock0, sock1;
+ struct sockaddr_un addr;
+ gchar *path;
+
+ ret = g_file_open_tmp("netdev-XXXXXX", &path, NULL);
+ g_assert_true(ret >= 0);
+ close(ret);
+ addr.sun_family = AF_UNIX;
+ strcpy(addr.sun_path, path);
+
+ unlink(addr.sun_path);
+ sock0 = socket(AF_LOCAL, SOCK_STREAM, 0);
+ g_assert_cmpint(sock0, !=, -1);
+
+ ret = bind(sock0, (struct sockaddr *)&addr, sizeof(addr));
+ g_assert_cmpint(ret, !=, -1);
+
+ qts0 = qtest_initf("-nodefaults "
+ "-netdev stream,id=st0,server=true,"
+ "addr.type=fd,addr.str=%d",
+ sock0);
+
+ EXPECT_STATE(qts0, "st0: index=0,type=stream,\r\n", 0);
+
+ sock1 = socket(AF_LOCAL, SOCK_STREAM, 0);
+ g_assert_cmpint(sock1, !=, -1);
+
+ ret = connect(sock1, (struct sockaddr *)&addr, sizeof(addr));
+ g_assert_cmpint(ret, !=, -1);
+
+ qts1 = qtest_initf("-nodefaults "
+ "-netdev stream,id=st0,server=false,addr.type=fd,addr.str=%d",
+ sock1);
+
+
+ expect = g_strdup_printf("st0: index=0,type=stream,unix:%s\r\n", path);
+ EXPECT_STATE(qts1, expect, 0);
+ EXPECT_STATE(qts0, expect, 0);
+ g_free(expect);
+
+ qtest_quit(qts1);
+ qtest_quit(qts0);
+
+ closesocket(sock0);
+ closesocket(sock1);
+
+ g_free(path);
+}
+
+static void test_dgram_inet(void)
+{
+ QTestState *qts0, *qts1;
+ char *expect;
+ int port[2];
+ int nb;
+
+ nb = inet_get_free_port_multiple(2, port);
+ g_assert_cmpint(nb, ==, 2);
+
+ qts0 = qtest_initf("-nodefaults "
+ "-netdev dgram,id=st0,"
+ "local.type=inet,local.host=localhost,local.port=%d,"
+ "remote.type=inet,remote.host=localhost,remote.port=%d",
+ port[0], port[1]);
+
+ expect = g_strdup_printf("st0: index=0,type=dgram,"
+ "udp=127.0.0.1:%d/127.0.0.1:%d\r\n",
+ port[0], port[1]);
+ EXPECT_STATE(qts0, expect, 0);
+ g_free(expect);
+
+ qts1 = qtest_initf("-nodefaults "
+ "-netdev dgram,id=st0,"
+ "local.type=inet,local.host=localhost,local.port=%d,"
+ "remote.type=inet,remote.host=localhost,remote.port=%d",
+ port[1], port[0]);
+
+ expect = g_strdup_printf("st0: index=0,type=dgram,"
+ "udp=127.0.0.1:%d/127.0.0.1:%d\r\n",
+ port[1], port[0]);
+ EXPECT_STATE(qts1, expect, 0);
+ g_free(expect);
+
+ qtest_quit(qts1);
+ qtest_quit(qts0);
+}
+
+static void test_dgram_mcast(void)
+{
+ QTestState *qts;
+
+ qts = qtest_initf("-nodefaults "
+ "-netdev dgram,id=st0,"
+ "remote.type=inet,remote.host=230.0.0.1,remote.port=1234");
+
+ EXPECT_STATE(qts, "st0: index=0,type=dgram,mcast=230.0.0.1:1234\r\n", 0);
+
+ qtest_quit(qts);
+}
+
+static void test_dgram_unix(void)
+{
+ QTestState *qts0, *qts1;
+ char *expect;
+ gchar *path0, *path1;
+ int ret;
+
+ ret = g_file_open_tmp("netdev-XXXXXX", &path0, NULL);
+ g_assert_true(ret >= 0);
+ close(ret);
+
+ ret = g_file_open_tmp("netdev-XXXXXX", &path1, NULL);
+ g_assert_true(ret >= 0);
+ close(ret);
+
+ qts0 = qtest_initf("-nodefaults "
+ "-netdev dgram,id=st0,local.type=unix,local.path=%s,"
+ "remote.type=unix,remote.path=%s",
+ path0, path1);
+
+ expect = g_strdup_printf("st0: index=0,type=dgram,udp=%s:%s\r\n",
+ path0, path1);
+ EXPECT_STATE(qts0, expect, 0);
+ g_free(expect);
+
+ qts1 = qtest_initf("-nodefaults "
+ "-netdev dgram,id=st0,local.type=unix,local.path=%s,"
+ "remote.type=unix,remote.path=%s",
+ path1, path0);
+
+
+ expect = g_strdup_printf("st0: index=0,type=dgram,udp=%s:%s\r\n",
+ path1, path0);
+ EXPECT_STATE(qts1, expect, 0);
+ g_free(expect);
+
+ unlink(path0);
+ g_free(path0);
+ unlink(path1);
+ g_free(path1);
+
+ qtest_quit(qts1);
+ qtest_quit(qts0);
+}
+
+static void test_dgram_fd(void)
+{
+ QTestState *qts0, *qts1;
+ char *expect;
+ int ret;
+ int sv[2];
+
+ ret = socketpair(PF_UNIX, SOCK_DGRAM, 0, sv);
+ g_assert_cmpint(ret, !=, -1);
+
+ qts0 = qtest_initf("-nodefaults "
+ "-netdev dgram,id=st0,local.type=fd,local.str=%d",
+ sv[0]);
+
+ expect = g_strdup_printf("st0: index=0,type=dgram,fd=%d unix\r\n", sv[0]);
+ EXPECT_STATE(qts0, expect, 0);
+ g_free(expect);
+
+ qts1 = qtest_initf("-nodefaults "
+ "-netdev dgram,id=st0,local.type=fd,local.str=%d",
+ sv[1]);
+
+
+ expect = g_strdup_printf("st0: index=0,type=dgram,fd=%d unix\r\n", sv[1]);
+ EXPECT_STATE(qts1, expect, 0);
+ g_free(expect);
+
+ qtest_quit(qts1);
+ qtest_quit(qts0);
+
+ closesocket(sv[0]);
+ closesocket(sv[1]);
+}
+
+int main(int argc, char **argv)
+{
+ int ret;
+
+ g_test_init(&argc, &argv, NULL);
+
+ qtest_add_func("/netdev/stream/inet/ipv4", test_stream_inet_ipv4);
+ qtest_add_func("/netdev/stream/inet/ipv6", test_stream_inet_ipv6);
+ qtest_add_func("/netdev/stream/unix", test_stream_unix);
+ qtest_add_func("/netdev/stream/unix/abstract", test_stream_unix_abstract);
+ qtest_add_func("/netdev/stream/fd", test_stream_fd);
+ qtest_add_func("/netdev/dgram/inet", test_dgram_inet);
+ qtest_add_func("/netdev/dgram/mcast", test_dgram_mcast);
+ qtest_add_func("/netdev/dgram/unix", test_dgram_unix);
+ qtest_add_func("/netdev/dgram/fd", test_dgram_fd);
+
+ ret = g_test_run();
+
+ return ret;
+}
--
2.37.3
在 2022/10/21 17:09, Laurent Vivier 写道:
> Signed-off-by: Laurent Vivier <lvivier@redhat.com>
> Acked-by: Michael S. Tsirkin <mst@redhat.com>
> ---
I got this:
63/63 ERROR:../tests/qtest/netdev-socket.c:139:test_stream_inet_ipv6:
assertion failed (resp == expect): ("st0: index=0,type=stream,connection
error\r\n" == "st0: index=0,type=stream,tcp:::1:40389\r\n") ERROR
63/63 qemu:qtest+qtest-x86_64 /
qtest-x86_64/netdev-socket ERROR 5.29s killed by
signal 6 SIGABRT
>>> QTEST_QEMU_IMG=./qemu-img QTEST_QEMU_BINARY=./qemu-system-x86_64
MALLOC_PERTURB_=96
QTEST_QEMU_STORAGE_DAEMON_BINARY=./storage-daemon/qemu-storage-daemon
G_TEST_DBUS_DAEMON=/home/devel/git/qemu/tests/dbus-vmstate-daemon.sh
/home/devel/git/qemu/build/tests/qtest/netdev-socket --tap -k
―――――――――――――――――――――――――――――――――――――――――――――――――――――――――――――――――――――――――――――――――――
✀
―――――――――――――――――――――――――――――――――――――――――――――――――――――――――――――――――――――――――――――――――――
stderr:
**
ERROR:../tests/qtest/netdev-socket.c:139:test_stream_inet_ipv6:
assertion failed (resp == expect): ("st0: index=0,type=stream,connection
error\r\n" == "st0: index=0,type=stream,tcp:::1:40389\r\n")
(test program exited with status code -6)
――――――――――――――――――――――――――――――――――――――――――――――――――――――――――――――――――――――――――――――――――――――――――――――――――――――――――――――――――――――――――――――――――――――――――――――――――――――――――――――――――――――――――
The base is:
commit 344744e148e6e865f5a57e745b02a87e5ea534ad (HEAD -> master,
origin/master, origin/HEAD)
Merge: 08a5d04606 e38c24cb58
Author: Stefan Hajnoczi <stefanha@redhat.com>
Date: Wed Oct 26 10:53:48 2022 -0400
Merge tag 'dump-pull-request' of
https://gitlab.com/marcandre.lureau/qemu into staging
So I dropped this patch from the queue and we can add it back after
soft-freeze.
Thanks
> tests/qtest/meson.build | 1 +
> tests/qtest/netdev-socket.c | 420 ++++++++++++++++++++++++++++++++++++
> 2 files changed, 421 insertions(+)
> create mode 100644 tests/qtest/netdev-socket.c
>
> diff --git a/tests/qtest/meson.build b/tests/qtest/meson.build
> index c07a5b1a5f43..6953797e4e3e 100644
> --- a/tests/qtest/meson.build
> +++ b/tests/qtest/meson.build
> @@ -27,6 +27,7 @@ qtests_generic = [
> 'test-hmp',
> 'qos-test',
> 'readconfig-test',
> + 'netdev-socket',
> ]
> if config_host.has_key('CONFIG_MODULES')
> qtests_generic += [ 'modules-test' ]
> diff --git a/tests/qtest/netdev-socket.c b/tests/qtest/netdev-socket.c
> new file mode 100644
> index 000000000000..b24c0819b9ac
> --- /dev/null
> +++ b/tests/qtest/netdev-socket.c
> @@ -0,0 +1,420 @@
> +/*
> + * QTest testcase for netdev stream and dgram
> + *
> + * Copyright (c) 2022 Red Hat, Inc.
> + *
> + * SPDX-License-Identifier: GPL-2.0-or-later
> + */
> +
> +#include "qemu/osdep.h"
> +#include "libqtest.h"
> +
> +#define CONNECTION_TIMEOUT 5
> +
> +#define EXPECT_STATE(q, e, t) \
> +do { \
> + char *resp = qtest_hmp(q, "info network"); \
> + if (t) { \
> + strrchr(resp, t)[0] = 0; \
> + } \
> + g_test_timer_start(); \
> + while (g_test_timer_elapsed() < CONNECTION_TIMEOUT) { \
> + if (strcmp(resp, e) == 0) { \
> + break; \
> + } \
> + g_free(resp); \
> + resp = qtest_hmp(q, "info network"); \
> + if (t) { \
> + strrchr(resp, t)[0] = 0; \
> + } \
> + } \
> + g_assert_cmpstr(resp, ==, e); \
> + g_free(resp); \
> +} while (0)
> +
> +static int inet_get_free_port_socket(int sock)
> +{
> + struct sockaddr_in addr;
> + socklen_t len;
> +
> + memset(&addr, 0, sizeof(addr));
> + addr.sin_family = AF_INET;
> + addr.sin_addr.s_addr = INADDR_ANY;
> + addr.sin_port = 0;
> + if (bind(sock, (struct sockaddr *)&addr, sizeof(addr)) < 0) {
> + return -1;
> + }
> +
> + len = sizeof(addr);
> + if (getsockname(sock, (struct sockaddr *)&addr, &len) < 0) {
> + return -1;
> + }
> +
> + return ntohs(addr.sin_port);
> +}
> +
> +static int inet_get_free_port_multiple(int nb, int *port)
> +{
> + int sock[nb];
> + int i;
> +
> + for (i = 0; i < nb; i++) {
> + sock[i] = socket(AF_INET, SOCK_STREAM, 0);
> + if (sock[i] < 0) {
> + break;
> + }
> + port[i] = inet_get_free_port_socket(sock[i]);
> + }
> +
> + nb = i;
> + for (i = 0; i < nb; i++) {
> + closesocket(sock[i]);
> + }
> +
> + return nb;
> +}
> +
> +static int inet_get_free_port(void)
> +{
> + int nb, port;
> +
> + nb = inet_get_free_port_multiple(1, &port);
> + g_assert_cmpint(nb, ==, 1);
> +
> + return port;
> +}
> +
> +static void test_stream_inet_ipv4(void)
> +{
> + QTestState *qts0, *qts1;
> + char *expect;
> + int port;
> +
> + port = inet_get_free_port();
> + qts0 = qtest_initf("-nodefaults "
> + "-netdev stream,id=st0,server=true,addr.type=inet,"
> + "addr.ipv4=on,addr.ipv6=off,"
> + "addr.host=localhost,addr.port=%d", port);
> +
> + EXPECT_STATE(qts0, "st0: index=0,type=stream,\r\n", 0);
> +
> + qts1 = qtest_initf("-nodefaults "
> + "-netdev stream,server=false,id=st0,addr.type=inet,"
> + "addr.ipv4=on,addr.ipv6=off,"
> + "addr.host=localhost,addr.port=%d", port);
> +
> + expect = g_strdup_printf("st0: index=0,type=stream,tcp:127.0.0.1:%d\r\n",
> + port);
> + EXPECT_STATE(qts1, expect, 0);
> + g_free(expect);
> +
> + /* the port is unknown, check only the address */
> + EXPECT_STATE(qts0, "st0: index=0,type=stream,tcp:127.0.0.1", ':');
> +
> + qtest_quit(qts1);
> + qtest_quit(qts0);
> +}
> +
> +static void test_stream_inet_ipv6(void)
> +{
> + QTestState *qts0, *qts1;
> + char *expect;
> + int port;
> +
> + port = inet_get_free_port();
> + qts0 = qtest_initf("-nodefaults "
> + "-netdev stream,id=st0,server=true,addr.type=inet,"
> + "addr.ipv4=off,addr.ipv6=on,"
> + "addr.host=localhost,addr.port=%d", port);
> +
> + EXPECT_STATE(qts0, "st0: index=0,type=stream,\r\n", 0);
> +
> + qts1 = qtest_initf("-nodefaults "
> + "-netdev stream,server=false,id=st0,addr.type=inet,"
> + "addr.ipv4=off,addr.ipv6=on,"
> + "addr.host=localhost,addr.port=%d", port);
> +
> + expect = g_strdup_printf("st0: index=0,type=stream,tcp:::1:%d\r\n",
> + port);
> + EXPECT_STATE(qts1, expect, 0);
> + g_free(expect);
> +
> + /* the port is unknown, check only the address */
> + EXPECT_STATE(qts0, "st0: index=0,type=stream,tcp:::1", ':');
> +
> + qtest_quit(qts1);
> + qtest_quit(qts0);
> +}
> +
> +static void test_stream_unix(void)
> +{
> + QTestState *qts0, *qts1;
> + char *expect;
> + gchar *path;
> + int ret;
> +
> + ret = g_file_open_tmp("netdev-XXXXXX", &path, NULL);
> + g_assert_true(ret >= 0);
> + close(ret);
> +
> + qts0 = qtest_initf("-nodefaults "
> + "-netdev stream,id=st0,server=true,"
> + "addr.type=unix,addr.path=%s,",
> + path);
> +
> + EXPECT_STATE(qts0, "st0: index=0,type=stream,\r\n", 0);
> +
> + qts1 = qtest_initf("-nodefaults "
> + "-netdev stream,id=st0,server=false,"
> + "addr.type=unix,addr.path=%s",
> + path);
> +
> + expect = g_strdup_printf("st0: index=0,type=stream,unix:%s\r\n", path);
> + EXPECT_STATE(qts1, expect, 0);
> + EXPECT_STATE(qts0, expect, 0);
> + g_free(expect);
> + unlink(path);
> + g_free(path);
> +
> + qtest_quit(qts1);
> + qtest_quit(qts0);
> +}
> +
> +static void test_stream_unix_abstract(void)
> +{
> + QTestState *qts0, *qts1;
> + char *expect;
> + gchar *path;
> + int ret;
> +
> + ret = g_file_open_tmp("netdev-XXXXXX", &path, NULL);
> + g_assert_true(ret >= 0);
> + close(ret);
> +
> + qts0 = qtest_initf("-nodefaults "
> + "-netdev stream,id=st0,server=true,"
> + "addr.type=unix,addr.path=%s,"
> + "addr.abstract=on",
> + path);
> +
> + EXPECT_STATE(qts0, "st0: index=0,type=stream,\r\n", 0);
> +
> + qts1 = qtest_initf("-nodefaults "
> + "-netdev stream,id=st0,server=false,"
> + "addr.type=unix,addr.path=%s,addr.abstract=on",
> + path);
> +
> + expect = g_strdup_printf("st0: index=0,type=stream,unix:%s\r\n", path);
> + EXPECT_STATE(qts1, expect, 0);
> + EXPECT_STATE(qts0, expect, 0);
> + g_free(expect);
> + unlink(path);
> + g_free(path);
> +
> + qtest_quit(qts1);
> + qtest_quit(qts0);
> +}
> +
> +static void test_stream_fd(void)
> +{
> + QTestState *qts0, *qts1;
> + char *expect;
> + int ret, sock0, sock1;
> + struct sockaddr_un addr;
> + gchar *path;
> +
> + ret = g_file_open_tmp("netdev-XXXXXX", &path, NULL);
> + g_assert_true(ret >= 0);
> + close(ret);
> + addr.sun_family = AF_UNIX;
> + strcpy(addr.sun_path, path);
> +
> + unlink(addr.sun_path);
> + sock0 = socket(AF_LOCAL, SOCK_STREAM, 0);
> + g_assert_cmpint(sock0, !=, -1);
> +
> + ret = bind(sock0, (struct sockaddr *)&addr, sizeof(addr));
> + g_assert_cmpint(ret, !=, -1);
> +
> + qts0 = qtest_initf("-nodefaults "
> + "-netdev stream,id=st0,server=true,"
> + "addr.type=fd,addr.str=%d",
> + sock0);
> +
> + EXPECT_STATE(qts0, "st0: index=0,type=stream,\r\n", 0);
> +
> + sock1 = socket(AF_LOCAL, SOCK_STREAM, 0);
> + g_assert_cmpint(sock1, !=, -1);
> +
> + ret = connect(sock1, (struct sockaddr *)&addr, sizeof(addr));
> + g_assert_cmpint(ret, !=, -1);
> +
> + qts1 = qtest_initf("-nodefaults "
> + "-netdev stream,id=st0,server=false,addr.type=fd,addr.str=%d",
> + sock1);
> +
> +
> + expect = g_strdup_printf("st0: index=0,type=stream,unix:%s\r\n", path);
> + EXPECT_STATE(qts1, expect, 0);
> + EXPECT_STATE(qts0, expect, 0);
> + g_free(expect);
> +
> + qtest_quit(qts1);
> + qtest_quit(qts0);
> +
> + closesocket(sock0);
> + closesocket(sock1);
> +
> + g_free(path);
> +}
> +
> +static void test_dgram_inet(void)
> +{
> + QTestState *qts0, *qts1;
> + char *expect;
> + int port[2];
> + int nb;
> +
> + nb = inet_get_free_port_multiple(2, port);
> + g_assert_cmpint(nb, ==, 2);
> +
> + qts0 = qtest_initf("-nodefaults "
> + "-netdev dgram,id=st0,"
> + "local.type=inet,local.host=localhost,local.port=%d,"
> + "remote.type=inet,remote.host=localhost,remote.port=%d",
> + port[0], port[1]);
> +
> + expect = g_strdup_printf("st0: index=0,type=dgram,"
> + "udp=127.0.0.1:%d/127.0.0.1:%d\r\n",
> + port[0], port[1]);
> + EXPECT_STATE(qts0, expect, 0);
> + g_free(expect);
> +
> + qts1 = qtest_initf("-nodefaults "
> + "-netdev dgram,id=st0,"
> + "local.type=inet,local.host=localhost,local.port=%d,"
> + "remote.type=inet,remote.host=localhost,remote.port=%d",
> + port[1], port[0]);
> +
> + expect = g_strdup_printf("st0: index=0,type=dgram,"
> + "udp=127.0.0.1:%d/127.0.0.1:%d\r\n",
> + port[1], port[0]);
> + EXPECT_STATE(qts1, expect, 0);
> + g_free(expect);
> +
> + qtest_quit(qts1);
> + qtest_quit(qts0);
> +}
> +
> +static void test_dgram_mcast(void)
> +{
> + QTestState *qts;
> +
> + qts = qtest_initf("-nodefaults "
> + "-netdev dgram,id=st0,"
> + "remote.type=inet,remote.host=230.0.0.1,remote.port=1234");
> +
> + EXPECT_STATE(qts, "st0: index=0,type=dgram,mcast=230.0.0.1:1234\r\n", 0);
> +
> + qtest_quit(qts);
> +}
> +
> +static void test_dgram_unix(void)
> +{
> + QTestState *qts0, *qts1;
> + char *expect;
> + gchar *path0, *path1;
> + int ret;
> +
> + ret = g_file_open_tmp("netdev-XXXXXX", &path0, NULL);
> + g_assert_true(ret >= 0);
> + close(ret);
> +
> + ret = g_file_open_tmp("netdev-XXXXXX", &path1, NULL);
> + g_assert_true(ret >= 0);
> + close(ret);
> +
> + qts0 = qtest_initf("-nodefaults "
> + "-netdev dgram,id=st0,local.type=unix,local.path=%s,"
> + "remote.type=unix,remote.path=%s",
> + path0, path1);
> +
> + expect = g_strdup_printf("st0: index=0,type=dgram,udp=%s:%s\r\n",
> + path0, path1);
> + EXPECT_STATE(qts0, expect, 0);
> + g_free(expect);
> +
> + qts1 = qtest_initf("-nodefaults "
> + "-netdev dgram,id=st0,local.type=unix,local.path=%s,"
> + "remote.type=unix,remote.path=%s",
> + path1, path0);
> +
> +
> + expect = g_strdup_printf("st0: index=0,type=dgram,udp=%s:%s\r\n",
> + path1, path0);
> + EXPECT_STATE(qts1, expect, 0);
> + g_free(expect);
> +
> + unlink(path0);
> + g_free(path0);
> + unlink(path1);
> + g_free(path1);
> +
> + qtest_quit(qts1);
> + qtest_quit(qts0);
> +}
> +
> +static void test_dgram_fd(void)
> +{
> + QTestState *qts0, *qts1;
> + char *expect;
> + int ret;
> + int sv[2];
> +
> + ret = socketpair(PF_UNIX, SOCK_DGRAM, 0, sv);
> + g_assert_cmpint(ret, !=, -1);
> +
> + qts0 = qtest_initf("-nodefaults "
> + "-netdev dgram,id=st0,local.type=fd,local.str=%d",
> + sv[0]);
> +
> + expect = g_strdup_printf("st0: index=0,type=dgram,fd=%d unix\r\n", sv[0]);
> + EXPECT_STATE(qts0, expect, 0);
> + g_free(expect);
> +
> + qts1 = qtest_initf("-nodefaults "
> + "-netdev dgram,id=st0,local.type=fd,local.str=%d",
> + sv[1]);
> +
> +
> + expect = g_strdup_printf("st0: index=0,type=dgram,fd=%d unix\r\n", sv[1]);
> + EXPECT_STATE(qts1, expect, 0);
> + g_free(expect);
> +
> + qtest_quit(qts1);
> + qtest_quit(qts0);
> +
> + closesocket(sv[0]);
> + closesocket(sv[1]);
> +}
> +
> +int main(int argc, char **argv)
> +{
> + int ret;
> +
> + g_test_init(&argc, &argv, NULL);
> +
> + qtest_add_func("/netdev/stream/inet/ipv4", test_stream_inet_ipv4);
> + qtest_add_func("/netdev/stream/inet/ipv6", test_stream_inet_ipv6);
> + qtest_add_func("/netdev/stream/unix", test_stream_unix);
> + qtest_add_func("/netdev/stream/unix/abstract", test_stream_unix_abstract);
> + qtest_add_func("/netdev/stream/fd", test_stream_fd);
> + qtest_add_func("/netdev/dgram/inet", test_dgram_inet);
> + qtest_add_func("/netdev/dgram/mcast", test_dgram_mcast);
> + qtest_add_func("/netdev/dgram/unix", test_dgram_unix);
> + qtest_add_func("/netdev/dgram/fd", test_dgram_fd);
> +
> + ret = g_test_run();
> +
> + return ret;
> +}
On 10/28/22 07:04, Jason Wang wrote:
>
> 在 2022/10/21 17:09, Laurent Vivier 写道:
>> Signed-off-by: Laurent Vivier <lvivier@redhat.com>
>> Acked-by: Michael S. Tsirkin <mst@redhat.com>
>> ---
>
>
> I got this:
>
> 63/63 ERROR:../tests/qtest/netdev-socket.c:139:test_stream_inet_ipv6: assertion failed
> (resp == expect): ("st0: index=0,type=stream,connection error\r\n" == "st0:
> index=0,type=stream,tcp:::1:40389\r\n") ERROR
> 63/63 qemu:qtest+qtest-x86_64 / qtest-x86_64/netdev-socket ERROR 5.29s
> killed by signal 6 SIGABRT
> >>> QTEST_QEMU_IMG=./qemu-img QTEST_QEMU_BINARY=./qemu-system-x86_64 MALLOC_PERTURB_=96
> QTEST_QEMU_STORAGE_DAEMON_BINARY=./storage-daemon/qemu-storage-daemon
> G_TEST_DBUS_DAEMON=/home/devel/git/qemu/tests/dbus-vmstate-daemon.sh
> /home/devel/git/qemu/build/tests/qtest/netdev-socket --tap -k
> ――――――――――――――――――――――――――――――――――――――――――――――――――――――――――――――――――――――――――――――――――― ✀
> ―――――――――――――――――――――――――――――――――――――――――――――――――――――――――――――――――――――――――――――――――――
> stderr:
> **
> ERROR:../tests/qtest/netdev-socket.c:139:test_stream_inet_ipv6: assertion failed (resp ==
> expect): ("st0: index=0,type=stream,connection error\r\n" == "st0:
> index=0,type=stream,tcp:::1:40389\r\n")
>
> (test program exited with status code -6)
I'm not able to reproduce the problem.
Is this 100% reproducible?
Is IPv6 enabled on your test machine?
Thanks,
Laurent
在 2022/11/3 17:33, Laurent Vivier 写道:
> On 10/28/22 07:04, Jason Wang wrote:
>>
>> 在 2022/10/21 17:09, Laurent Vivier 写道:
>>> Signed-off-by: Laurent Vivier <lvivier@redhat.com>
>>> Acked-by: Michael S. Tsirkin <mst@redhat.com>
>>> ---
>>
>>
>> I got this:
>>
>> 63/63 ERROR:../tests/qtest/netdev-socket.c:139:test_stream_inet_ipv6:
>> assertion failed (resp == expect): ("st0:
>> index=0,type=stream,connection error\r\n" == "st0:
>> index=0,type=stream,tcp:::1:40389\r\n") ERROR
>> 63/63 qemu:qtest+qtest-x86_64 /
>> qtest-x86_64/netdev-socket ERROR 5.29s killed by
>> signal 6 SIGABRT
>> >>> QTEST_QEMU_IMG=./qemu-img QTEST_QEMU_BINARY=./qemu-system-x86_64
>> MALLOC_PERTURB_=96
>> QTEST_QEMU_STORAGE_DAEMON_BINARY=./storage-daemon/qemu-storage-daemon
>> G_TEST_DBUS_DAEMON=/home/devel/git/qemu/tests/dbus-vmstate-daemon.sh
>> /home/devel/git/qemu/build/tests/qtest/netdev-socket --tap -k
>> ―――――――――――――――――――――――――――――――――――――――――――――――――――――――――――――――――――――――――――――――――――
>> ✀
>> ―――――――――――――――――――――――――――――――――――――――――――――――――――――――――――――――――――――――――――――――――――
>> stderr:
>> **
>> ERROR:../tests/qtest/netdev-socket.c:139:test_stream_inet_ipv6:
>> assertion failed (resp == expect): ("st0:
>> index=0,type=stream,connection error\r\n" == "st0:
>> index=0,type=stream,tcp:::1:40389\r\n")
>>
>> (test program exited with status code -6)
>
> I'm not able to reproduce the problem.
>
> Is this 100% reproducible?
Yes.
> Is IPv6 enabled on your test machine?
Yes.
Try to investigate it more, it looks like the reason is hostname. I'm
testing in ubunut which has the following things in /etc/hosts
127.0.0.1 localhost
127.0.1.1 jason-ThinkPad-X1-Carbon-6th
192.168.100.2 guest
# The following lines are desirable for IPv6 capable hosts
::1 ip6-localhost ip6-loopback
fe00::0 ip6-localnet
ff00::0 ip6-mcastprefix
ff02::1 ip6-allnodes
ff02::2 ip6-allrouters
So localhost is mapped to ipv4 and there's no ipv6 mappings here. Using
"::1" for the address seems to fix the issue.
Thanks
>
> Thanks,
> Laurent
>
On 3/11/22 10:33, Laurent Vivier wrote:
> On 10/28/22 07:04, Jason Wang wrote:
>>
>> 在 2022/10/21 17:09, Laurent Vivier 写道:
>>> Signed-off-by: Laurent Vivier <lvivier@redhat.com>
>>> Acked-by: Michael S. Tsirkin <mst@redhat.com>
>>> ---
>>
>>
>> I got this:
>>
>> 63/63 ERROR:../tests/qtest/netdev-socket.c:139:test_stream_inet_ipv6:
>> assertion failed (resp == expect): ("st0:
>> index=0,type=stream,connection error\r\n" == "st0:
>> index=0,type=stream,tcp:::1:40389\r\n") ERROR
>> 63/63 qemu:qtest+qtest-x86_64 /
>> qtest-x86_64/netdev-socket ERROR 5.29s killed by
>> signal 6 SIGABRT
>> >>> QTEST_QEMU_IMG=./qemu-img QTEST_QEMU_BINARY=./qemu-system-x86_64
>> MALLOC_PERTURB_=96
>> QTEST_QEMU_STORAGE_DAEMON_BINARY=./storage-daemon/qemu-storage-daemon
>> G_TEST_DBUS_DAEMON=/home/devel/git/qemu/tests/dbus-vmstate-daemon.sh
>> /home/devel/git/qemu/build/tests/qtest/netdev-socket --tap -k
>> ――――――――――――――――――――――――――――――――――――――――――――――――――――――――――――――――――――――――――――――――――― ✀ ―――――――――――――――――――――――――――――――――――――――――――――――――――――――――――――――――――――――――――――――――――
>> stderr:
>> **
>> ERROR:../tests/qtest/netdev-socket.c:139:test_stream_inet_ipv6:
>> assertion failed (resp == expect): ("st0:
>> index=0,type=stream,connection error\r\n" == "st0:
>> index=0,type=stream,tcp:::1:40389\r\n")
>>
>> (test program exited with status code -6)
>
> I'm not able to reproduce the problem.
>
> Is this 100% reproducible?
> Is IPv6 enabled on your test machine?
If IPv6 is not available, this test should be skipped, not failing.
On 11/3/22 12:07, Philippe Mathieu-Daudé wrote:
> On 3/11/22 10:33, Laurent Vivier wrote:
>> On 10/28/22 07:04, Jason Wang wrote:
>>>
>>> 在 2022/10/21 17:09, Laurent Vivier 写道:
>>>> Signed-off-by: Laurent Vivier <lvivier@redhat.com>
>>>> Acked-by: Michael S. Tsirkin <mst@redhat.com>
>>>> ---
>>>
>>>
>>> I got this:
>>>
>>> 63/63 ERROR:../tests/qtest/netdev-socket.c:139:test_stream_inet_ipv6: assertion failed
>>> (resp == expect): ("st0: index=0,type=stream,connection error\r\n" == "st0:
>>> index=0,type=stream,tcp:::1:40389\r\n") ERROR
>>> 63/63 qemu:qtest+qtest-x86_64 / qtest-x86_64/netdev-socket ERROR 5.29s
>>> killed by signal 6 SIGABRT
>>> >>> QTEST_QEMU_IMG=./qemu-img QTEST_QEMU_BINARY=./qemu-system-x86_64
>>> MALLOC_PERTURB_=96
>>> QTEST_QEMU_STORAGE_DAEMON_BINARY=./storage-daemon/qemu-storage-daemon
>>> G_TEST_DBUS_DAEMON=/home/devel/git/qemu/tests/dbus-vmstate-daemon.sh
>>> /home/devel/git/qemu/build/tests/qtest/netdev-socket --tap -k
>>> ――――――――――――――――――――――――――――――――――――――――――――――――――――――――――――――――――――――――――――――――――― ✀
>>> ―――――――――――――――――――――――――――――――――――――――――――――――――――――――――――――――――――――――――――――――――――
>>> stderr:
>>> **
>>> ERROR:../tests/qtest/netdev-socket.c:139:test_stream_inet_ipv6: assertion failed (resp
>>> == expect): ("st0: index=0,type=stream,connection error\r\n" == "st0:
>>> index=0,type=stream,tcp:::1:40389\r\n")
>>>
>>> (test program exited with status code -6)
>>
>> I'm not able to reproduce the problem.
>>
>> Is this 100% reproducible?
>> Is IPv6 enabled on your test machine?
>
> If IPv6 is not available, this test should be skipped, not failing.
I agree.
But I'm not sure it's the real cause of the problem (perhaps a firewall problem?).
I think I should update my inet_get_free_port_socket() to get a free port from AF_INET6
and not only from AF_INET.
Thanks,
Laurent
© 2016 - 2024 Red Hat, Inc.