Changes since v7: Details in individual patches:
Thanks to Gregory Price for reviewing!
- Fix heap corruption.
- Check allocations succeed.
- Substantial refactor of type 3 cdat table build to make it
simpler and easier to add volatile entry support.
V7 Cover letter - lightly edited.
Whilst I have carried on Huai-Cheng Kuo's series version numbering and
naming, there have been very substantial changes since v6 so I would
suggest fresh review makes sense for anyone who has looked at this before.
In particularly if the Avery design folks could check I haven't broken
anything that would be great.
For reference v6: QEMU PCIe DOE for PCIe 4.0/5.0 and CXL 2.0
https://lore.kernel.org/qemu-devel/1623330943-18290-1-git-send-email-cbrowy@avery-design.com/
Summary of changes:
1) Linux headers definitions for DOE are now upstream so drop that patch.
2) Add CDAT for switch upstream port.
3) Generate 'plausible' default CDAT tables when a file is not provided.
4) General refactoring to calculate the correct table sizes and allocate
based on that rather than copying from a local static array.
5) Changes from earlier reviews such as matching QEMU type naming style.
6) Moved compliance and SPDM usecases to future patch sets.
Sign-offs on these are complex because the patches were originally developed
by Huai-Cheng Kuo, but posted by Chris Browy and then picked up by Jonathan
Cameron who made substantial changes.
Huai-Cheng Kuo confirmed they are happy to maintain this updated code.
What's here?
This series brings generic PCI Express Data Object Exchange support (DOE)
DOE is defined in the PCIe Base Spec r6.0. It consists of a mailbox in PCI
config space via a PCIe Extended Capability Structure.
The PCIe spec defines several protocols (including one to discover what
protocols a given DOE instance supports) and other specification such as
CXL define additional protocols using their own vendor IDs.
In this series we make use of the DOE to support the CXL spec defined
Table Access Protocol, specifically to provide access to CDAT - a
table specified in a specification that is hosted by the UEFI forum
and is used to provide runtime discoverability of the sort of information
that would otherwise be available in firmware tables (memory types,
latency and bandwidth information etc).
The Linux kernel gained support for DOE / CDAT on CXL type 3 EPs in 6.0.
The version merged did not support interrupts (earlier versions did
so that support in the emulation was tested a while back).
This series provides CDAT emulation for CXL switch upstream ports
and CXL type 3 memory devices. Note that to exercise the switch support
additional Linux kernel patches are needed.
https://lore.kernel.org/linux-cxl/20220503153449.4088-1-Jonathan.Cameron@huawei.com/
(I'll post a new version of that support shortly)
Additional protocols will be supported by follow on patch sets:
* CXL compliance protocol.
* CMA / SPDM device attestation.
(Old version at https://gitlab.com/jic23/qemu/-/commits/cxl-next - will refresh
that tree next week)
Huai-Cheng Kuo (3):
hw/pci: PCIe Data Object Exchange emulation
hw/cxl/cdat: CXL CDAT Data Object Exchange implementation
hw/mem/cxl-type3: Add CXL CDAT Data Object Exchange
Jonathan Cameron (2):
hw/mem/cxl-type3: Add MSIX support
hw/pci-bridge/cxl-upstream: Add a CDAT table access DOE
MAINTAINERS | 7 +
hw/cxl/cxl-cdat.c | 224 ++++++++++++++++++++
hw/cxl/meson.build | 1 +
hw/mem/cxl_type3.c | 276 +++++++++++++++++++++++++
hw/pci-bridge/cxl_upstream.c | 194 ++++++++++++++++-
hw/pci/meson.build | 1 +
hw/pci/pcie_doe.c | 367 +++++++++++++++++++++++++++++++++
include/hw/cxl/cxl_cdat.h | 166 +++++++++++++++
include/hw/cxl/cxl_component.h | 7 +
include/hw/cxl/cxl_device.h | 3 +
include/hw/cxl/cxl_pci.h | 1 +
include/hw/pci/pci_ids.h | 3 +
include/hw/pci/pcie.h | 1 +
include/hw/pci/pcie_doe.h | 123 +++++++++++
include/hw/pci/pcie_regs.h | 4 +
15 files changed, 1377 insertions(+), 1 deletion(-)
create mode 100644 hw/cxl/cxl-cdat.c
create mode 100644 hw/pci/pcie_doe.c
create mode 100644 include/hw/cxl/cxl_cdat.h
create mode 100644 include/hw/pci/pcie_doe.h
--
2.37.2