[PATCH] tests/qtest/cxl-test: Remove temporary directories after testing

Thomas Huth posted 1 patch 3 years, 3 months ago
Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/qemu tags/patchew/20221012091435.893570-1-thuth@redhat.com
Maintainers: Thomas Huth <thuth@redhat.com>, Laurent Vivier <lvivier@redhat.com>, Paolo Bonzini <pbonzini@redhat.com>
tests/qtest/cxl-test.c | 3 +++
1 file changed, 3 insertions(+)
[PATCH] tests/qtest/cxl-test: Remove temporary directories after testing
Posted by Thomas Huth 3 years, 3 months ago
The cxl-test leaves some temporary directories behind. Let's
clean them up now!

Signed-off-by: Thomas Huth <thuth@redhat.com>
---
 tests/qtest/cxl-test.c | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/tests/qtest/cxl-test.c b/tests/qtest/cxl-test.c
index cbe0fb549b..61f25a72b6 100644
--- a/tests/qtest/cxl-test.c
+++ b/tests/qtest/cxl-test.c
@@ -101,6 +101,7 @@ static void cxl_t3d(void)
 
     qtest_start(cmdline->str);
     qtest_end();
+    rmdir(tmpfs);
 }
 
 static void cxl_1pxb_2rp_2t3d(void)
@@ -115,6 +116,7 @@ static void cxl_1pxb_2rp_2t3d(void)
 
     qtest_start(cmdline->str);
     qtest_end();
+    rmdir(tmpfs);
 }
 
 static void cxl_2pxb_4rp_4t3d(void)
@@ -130,6 +132,7 @@ static void cxl_2pxb_4rp_4t3d(void)
 
     qtest_start(cmdline->str);
     qtest_end();
+    rmdir(tmpfs);
 }
 #endif /* CONFIG_POSIX */
 
-- 
2.31.1
RE: [PATCH] tests/qtest/cxl-test: Remove temporary directories after testing
Posted by Zhang, Chen 3 years, 3 months ago

> -----Original Message-----
> From: Qemu-devel <qemu-devel-bounces+chen.zhang=intel.com@nongnu.org>
> On Behalf Of Thomas Huth
> Sent: Wednesday, October 12, 2022 5:15 PM
> To: qemu-devel@nongnu.org; Jonathan Cameron
> <Jonathan.Cameron@huawei.com>
> Cc: Laurent Vivier <lvivier@redhat.com>; Michael S . Tsirkin <mst@redhat.com>
> Subject: [PATCH] tests/qtest/cxl-test: Remove temporary directories after
> testing
> 
> The cxl-test leaves some temporary directories behind. Let's clean them up
> now!
> 
> Signed-off-by: Thomas Huth <thuth@redhat.com>

LGTM.
Reviewed-by: Zhang Chen <chen.zhang@intel.com>

Thanks
Chen

> ---
>  tests/qtest/cxl-test.c | 3 +++
>  1 file changed, 3 insertions(+)
> 
> diff --git a/tests/qtest/cxl-test.c b/tests/qtest/cxl-test.c index
> cbe0fb549b..61f25a72b6 100644
> --- a/tests/qtest/cxl-test.c
> +++ b/tests/qtest/cxl-test.c
> @@ -101,6 +101,7 @@ static void cxl_t3d(void)
> 
>      qtest_start(cmdline->str);
>      qtest_end();
> +    rmdir(tmpfs);
>  }
> 
>  static void cxl_1pxb_2rp_2t3d(void)
> @@ -115,6 +116,7 @@ static void cxl_1pxb_2rp_2t3d(void)
> 
>      qtest_start(cmdline->str);
>      qtest_end();
> +    rmdir(tmpfs);
>  }
> 
>  static void cxl_2pxb_4rp_4t3d(void)
> @@ -130,6 +132,7 @@ static void cxl_2pxb_4rp_4t3d(void)
> 
>      qtest_start(cmdline->str);
>      qtest_end();
> +    rmdir(tmpfs);
>  }
>  #endif /* CONFIG_POSIX */
> 
> --
> 2.31.1
> 
Re: [PATCH] tests/qtest/cxl-test: Remove temporary directories after testing
Posted by Jonathan Cameron via 3 years, 3 months ago
On Mon, 17 Oct 2022 09:28:49 +0000
"Zhang, Chen" <chen.zhang@intel.com> wrote:

> > -----Original Message-----
> > From: Qemu-devel <qemu-devel-bounces+chen.zhang=intel.com@nongnu.org>
> > On Behalf Of Thomas Huth
> > Sent: Wednesday, October 12, 2022 5:15 PM
> > To: qemu-devel@nongnu.org; Jonathan Cameron
> > <Jonathan.Cameron@huawei.com>
> > Cc: Laurent Vivier <lvivier@redhat.com>; Michael S . Tsirkin <mst@redhat.com>
> > Subject: [PATCH] tests/qtest/cxl-test: Remove temporary directories after
> > testing
> > 
> > The cxl-test leaves some temporary directories behind. Let's clean them up
> > now!
> > 
> > Signed-off-by: Thomas Huth <thuth@redhat.com>  
> 
> LGTM.
> Reviewed-by: Zhang Chen <chen.zhang@intel.com>
> 
> Thanks
> Chen

Oops.

Acked-by: Jonathan Cameron <Jonathan.Cameron@huawei.com>

> 
> > ---
> >  tests/qtest/cxl-test.c | 3 +++
> >  1 file changed, 3 insertions(+)
> > 
> > diff --git a/tests/qtest/cxl-test.c b/tests/qtest/cxl-test.c index
> > cbe0fb549b..61f25a72b6 100644
> > --- a/tests/qtest/cxl-test.c
> > +++ b/tests/qtest/cxl-test.c
> > @@ -101,6 +101,7 @@ static void cxl_t3d(void)
> > 
> >      qtest_start(cmdline->str);
> >      qtest_end();
> > +    rmdir(tmpfs);
> >  }
> > 
> >  static void cxl_1pxb_2rp_2t3d(void)
> > @@ -115,6 +116,7 @@ static void cxl_1pxb_2rp_2t3d(void)
> > 
> >      qtest_start(cmdline->str);
> >      qtest_end();
> > +    rmdir(tmpfs);
> >  }
> > 
> >  static void cxl_2pxb_4rp_4t3d(void)
> > @@ -130,6 +132,7 @@ static void cxl_2pxb_4rp_4t3d(void)
> > 
> >      qtest_start(cmdline->str);
> >      qtest_end();
> > +    rmdir(tmpfs);
> >  }
> >  #endif /* CONFIG_POSIX */
> > 
> > --
> > 2.31.1
> >   
>