The MADT table structure has been updated in commit 37f33084ed2e
("acpi: arm/virt: madt: use build_append_int_noprefix() API to compose MADT table")
to include the 5.2.12.18 GIC ITS Structure and so table's revision also needs to
be updated. MADT and the FADT tables from the same spec need to be in sync and in
this case also the FADT needs to be updated.
Revision 6.0 of the ACPI FADT table introduces the field "Hypervisor Vendor
Identity" which is missing and must be included. Patch 2/4 includes a
suggestion for the value of this field.
Ref: https://uefi.org/sites/default/files/resources/ACPI_6_0_Errata_A.PDF
Changelog:
v2:
patch 2/4:
fix expression that checks for the revision number (Ani Sinha)
use "QEMU" as the Hypervisor Vendor ID [1] (Ani Sinha)
patch 3/4:
add Reviewed-by tag from Ani Sinha <ani@anisinha.ca>
v1: https://lists.nongnu.org/archive/html/qemu-devel/2022-10/msg00910.html
Open to discussion, your comments, thoughts and suggestions are very welcome.
Thanks in advance.
Miguel
[1]: https://lists.nongnu.org/archive/html/qemu-devel/2022-10/msg00989.html
Miguel Luis (4):
tests/acpi: virt: allow acpi MADT and FADT changes
acpi: fadt: support revision 6.0 of the ACPI specification
acpi: arm/virt: madt: bump to revision 4 accordingly to ACPI 6.0
Errata A
tests/acpi: virt: update ACPI MADT and FADT binaries
hw/acpi/aml-build.c | 13 ++++++++++---
hw/arm/virt-acpi-build.c | 26 ++++++++++++--------------
tests/data/acpi/virt/APIC | Bin 168 -> 172 bytes
tests/data/acpi/virt/APIC.memhp | Bin 168 -> 172 bytes
tests/data/acpi/virt/APIC.numamem | Bin 168 -> 172 bytes
tests/data/acpi/virt/FACP | Bin 268 -> 276 bytes
tests/data/acpi/virt/FACP.memhp | Bin 268 -> 276 bytes
tests/data/acpi/virt/FACP.numamem | Bin 268 -> 276 bytes
8 files changed, 22 insertions(+), 17 deletions(-)
--
2.37.3