quorum: Remove unnecessary forward declaration

[PATCH] quorum: Remove unnecessary forward declaration

Kevin Wolf posted 1 patch 3 years, 4 months ago

Download mbox

Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/qemu tags/patchew/20221006122607.162769-1-kwolf@redhat.com

Maintainers: Alberto Garcia <berto@igalia.com>, Kevin Wolf <kwolf@redhat.com>, Hanna Reitz <hreitz@redhat.com>

block/quorum.c | 2 --
1 file changed, 2 deletions(-)

Expand all Fold all

[PATCH] quorum: Remove unnecessary forward declaration

Posted by Kevin Wolf 3 years, 4 months ago

Signed-off-by: Kevin Wolf <kwolf@redhat.com>
---
 block/quorum.c | 2 --
 1 file changed, 2 deletions(-)

diff --git a/block/quorum.c b/block/quorum.c
index 970f63d9f9..f9e6539ceb 100644
--- a/block/quorum.c
+++ b/block/quorum.c
@@ -232,8 +232,6 @@ static bool quorum_has_too_much_io_failed(QuorumAIOCB *acb)
     return false;
 }
 
-static int read_fifo_child(QuorumAIOCB *acb);
-
 static void quorum_copy_qiov(QEMUIOVector *dest, QEMUIOVector *source)
 {
     int i;
-- 
2.37.3

Re: [PATCH] quorum: Remove unnecessary forward declaration

Posted by Philippe Mathieu-Daudé via 3 years, 4 months ago

On 6/10/22 14:26, Kevin Wolf wrote:
> Signed-off-by: Kevin Wolf <kwolf@redhat.com>
> ---
>   block/quorum.c | 2 --
>   1 file changed, 2 deletions(-)

Reviewed-by: Philippe Mathieu-Daudé <f4bug@amsat.org>

Re: [PATCH] quorum: Remove unnecessary forward declaration

Posted by Peter Maydell 3 years, 4 months ago

On Thu, 6 Oct 2022 at 14:13, Kevin Wolf <kwolf@redhat.com> wrote:
>
> Signed-off-by: Kevin Wolf <kwolf@redhat.com>
> ---
>  block/quorum.c | 2 --
>  1 file changed, 2 deletions(-)
>
> diff --git a/block/quorum.c b/block/quorum.c
> index 970f63d9f9..f9e6539ceb 100644
> --- a/block/quorum.c
> +++ b/block/quorum.c
> @@ -232,8 +232,6 @@ static bool quorum_has_too_much_io_failed(QuorumAIOCB *acb)
>      return false;
>  }
>
> -static int read_fifo_child(QuorumAIOCB *acb);
> -
>  static void quorum_copy_qiov(QEMUIOVector *dest, QEMUIOVector *source)
>  {
>      int i;
> --

Reviewed-by: Peter Maydell <peter.maydell@linaro.org>

thanks
-- PMM