[PATCH v5 0/9] Add 'q35' machine type to hotplug tests

Michael Labiuk via posted 9 patches 1 year, 6 months ago
Failed in applying to current master (apply log)
Maintainers: Thomas Huth <thuth@redhat.com>, Laurent Vivier <lvivier@redhat.com>, Paolo Bonzini <pbonzini@redhat.com>
tests/qtest/device-plug-test.c |  56 ++++--
tests/qtest/drive_del-test.c   | 125 +++++++++++--
tests/qtest/hd-geo-test.c      | 319 ++++++++++++++++++++++++---------
tests/qtest/ivshmem-test.c     |  18 ++
tests/qtest/libqos/pci-pc.c    |   8 +-
tests/qtest/libqtest.c         |  16 +-
tests/qtest/libqtest.h         |  10 ++
7 files changed, 425 insertions(+), 127 deletions(-)
[PATCH v5 0/9] Add 'q35' machine type to hotplug tests
Posted by Michael Labiuk via 1 year, 6 months ago
Add pci bridge setting to run hotplug tests on q35 machine type.
Hotplug tests was bounded to 'pc' machine type by commit 7b172333f1b

v5 -> v4:

* Unify device removing in tests.
* Using qtest_has_machine("q35") as condition.
* fixed typos.
* Replaced snprintf.

v4 -> v3:

* Moving helper function process_device_remove() to separate commit.
* Refactoring hd-geo-test to avoid code duplication.

Michael Labiuk (9):
  tests/x86: add helper qtest_qmp_device_del_send()
  tests/x86: Add subtest with 'q35' machine type to device-plug-test
  tests/x86: Refactor hot unplug hd-geo-test
  tests/x86: Add 'q35' machine type to override-tests in hd-geo-test
  tests/x86: Add 'q35' machine type to hotplug hd-geo-test
  tests/x86: Fix comment typo in drive_del-test
  tests/x86: replace snprint() by g_strdup_printf() in drive_del-test
  tests/x86: Add 'q35' machine type to drive_del-test
  tests/x86: Add 'q35' machine type to ivshmem-test

 tests/qtest/device-plug-test.c |  56 ++++--
 tests/qtest/drive_del-test.c   | 125 +++++++++++--
 tests/qtest/hd-geo-test.c      | 319 ++++++++++++++++++++++++---------
 tests/qtest/ivshmem-test.c     |  18 ++
 tests/qtest/libqos/pci-pc.c    |   8 +-
 tests/qtest/libqtest.c         |  16 +-
 tests/qtest/libqtest.h         |  10 ++
 7 files changed, 425 insertions(+), 127 deletions(-)

-- 
2.34.1
[PING PATCH v5] Add 'q35' machine type to hotplug tests
Posted by Michael Labiuk 1 year, 6 months ago
I would like to ping a patch

https://patchew.org/QEMU/20220929223547.1429580-1-michael.labiuk@virtuozzo.com/ 



On 9/30/22 01:35, Michael Labiuk via wrote:
> Add pci bridge setting to run hotplug tests on q35 machine type.
> Hotplug tests was bounded to 'pc' machine type by commit 7b172333f1b
> 
> v5 -> v4:
> 
> * Unify device removing in tests.
> * Using qtest_has_machine("q35") as condition.
> * fixed typos.
> * Replaced snprintf.
> 
> v4 -> v3:
> 
> * Moving helper function process_device_remove() to separate commit.
> * Refactoring hd-geo-test to avoid code duplication.
> 
> Michael Labiuk (9):
>    tests/x86: add helper qtest_qmp_device_del_send()
>    tests/x86: Add subtest with 'q35' machine type to device-plug-test
>    tests/x86: Refactor hot unplug hd-geo-test
>    tests/x86: Add 'q35' machine type to override-tests in hd-geo-test
>    tests/x86: Add 'q35' machine type to hotplug hd-geo-test
>    tests/x86: Fix comment typo in drive_del-test
>    tests/x86: replace snprint() by g_strdup_printf() in drive_del-test
>    tests/x86: Add 'q35' machine type to drive_del-test
>    tests/x86: Add 'q35' machine type to ivshmem-test
> 
>   tests/qtest/device-plug-test.c |  56 ++++--
>   tests/qtest/drive_del-test.c   | 125 +++++++++++--
>   tests/qtest/hd-geo-test.c      | 319 ++++++++++++++++++++++++---------
>   tests/qtest/ivshmem-test.c     |  18 ++
>   tests/qtest/libqos/pci-pc.c    |   8 +-
>   tests/qtest/libqtest.c         |  16 +-
>   tests/qtest/libqtest.h         |  10 ++
>   7 files changed, 425 insertions(+), 127 deletions(-)
>
Re: [PING PATCH v5] Add 'q35' machine type to hotplug tests
Posted by Thomas Huth 1 year, 6 months ago
On 11/10/2022 12.18, Michael Labiuk wrote:
> I would like to ping a patch

Sorry, it took me a little bit longer to get back to this...

Anyway, patches look fine, and I've queued them now (with the typo fixed in 
the first patch) to my testing-next branch:

  https://gitlab.com/thuth/qemu/-/commits/testing-next

  Thomas

> 
> 
> On 9/30/22 01:35, Michael Labiuk via wrote:
>> Add pci bridge setting to run hotplug tests on q35 machine type.
>> Hotplug tests was bounded to 'pc' machine type by commit 7b172333f1b
>>
>> v5 -> v4:
>>
>> * Unify device removing in tests.
>> * Using qtest_has_machine("q35") as condition.
>> * fixed typos.
>> * Replaced snprintf.
>>
>> v4 -> v3:
>>
>> * Moving helper function process_device_remove() to separate commit.
>> * Refactoring hd-geo-test to avoid code duplication.
>>
>> Michael Labiuk (9):
>>    tests/x86: add helper qtest_qmp_device_del_send()
>>    tests/x86: Add subtest with 'q35' machine type to device-plug-test
>>    tests/x86: Refactor hot unplug hd-geo-test
>>    tests/x86: Add 'q35' machine type to override-tests in hd-geo-test
>>    tests/x86: Add 'q35' machine type to hotplug hd-geo-test
>>    tests/x86: Fix comment typo in drive_del-test
>>    tests/x86: replace snprint() by g_strdup_printf() in drive_del-test
>>    tests/x86: Add 'q35' machine type to drive_del-test
>>    tests/x86: Add 'q35' machine type to ivshmem-test
>>
>>   tests/qtest/device-plug-test.c |  56 ++++--
>>   tests/qtest/drive_del-test.c   | 125 +++++++++++--
>>   tests/qtest/hd-geo-test.c      | 319 ++++++++++++++++++++++++---------
>>   tests/qtest/ivshmem-test.c     |  18 ++
>>   tests/qtest/libqos/pci-pc.c    |   8 +-
>>   tests/qtest/libqtest.c         |  16 +-
>>   tests/qtest/libqtest.h         |  10 ++
>>   7 files changed, 425 insertions(+), 127 deletions(-)
>>
>