1. Patchew
  2. QEMU
  3. [PATCH v1 00/51] maintainer pre-PR (testing, plugins, gitdm, semihosting)
  4. View patch

[PATCH v1 15/51] vof: add distclean target

Alex Bennée posted 51 patches 3 years, 4 months ago
Maintainers: Ed Maste <emaste@freebsd.org>, Li-Wen Hsu <lwhsu@freebsd.org>, "Alex Bennée" <alex.bennee@linaro.org>, "Philippe Mathieu-Daudé" <f4bug@amsat.org>, Thomas Huth <thuth@redhat.com>, Wainer dos Santos Moschetta <wainersm@redhat.com>, Beraldo Leal <bleal@redhat.com>, Richard Henderson <richard.henderson@linaro.org>, Paolo Bonzini <pbonzini@redhat.com>, Kevin Wolf <kwolf@redhat.com>, Hanna Reitz <hreitz@redhat.com>, Alexandre Iooss <erdnaxe@crans.org>, Mahmoud Mandour <ma.mandourr@gmail.com>, Mark Cave-Ayland <mark.cave-ayland@ilande.co.uk>, "Dr. David Alan Gilbert" <dgilbert@redhat.com>, Markus Armbruster <armbru@redhat.com>, Christian Borntraeger <borntraeger@linux.ibm.com>, Cornelia Huck <cohuck@redhat.com>, Alexey Kardashevskiy <aik@ozlabs.ru>, "Cédric Le Goater" <clg@kaod.org>, Daniel Henrique Barboza <danielhb413@gmail.com>, David Gibson <david@gibson.dropbear.id.au>, Greg Kurz <groug@kaod.org>, Laurent Vivier <lvivier@redhat.com>, Peter Maydell <peter.maydell@linaro.org>, "Edgar E. Iglesias" <edgar.iglesias@gmail.com>, Eduardo Habkost <eduardo@habkost.net>, David Hildenbrand <david@redhat.com>, Stefan Hajnoczi <stefanha@redhat.com>
[PATCH v1 15/51] vof: add distclean target
Posted by Alex Bennée 3 years, 4 months ago 
From: Paolo Bonzini <pbonzini@redhat.com>

Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
Signed-off-by: Alex Bennée <alex.bennee@linaro.org>
---
 pc-bios/vof/Makefile | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/pc-bios/vof/Makefile b/pc-bios/vof/Makefile
index 8809c82768..990f26af31 100644
--- a/pc-bios/vof/Makefile
+++ b/pc-bios/vof/Makefile
@@ -19,4 +19,6 @@ vof.elf: entry.o main.o ci.o bootmem.o libc.o
 clean:
 	rm -f *.o vof.bin vof.elf *~
 
-.PHONY: all clean
+distclean:
+
+.PHONY: all clean distclean
-- 
2.34.1
Re: [PATCH v1 15/51] vof: add distclean target
Posted by BALATON Zoltan 3 years, 4 months ago 
On Thu, 29 Sep 2022, Alex Bennée wrote:
> From: Paolo Bonzini <pbonzini@redhat.com>
>
> Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
> Signed-off-by: Alex Bennée <alex.bennee@linaro.org>
> ---
> pc-bios/vof/Makefile | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/pc-bios/vof/Makefile b/pc-bios/vof/Makefile
> index 8809c82768..990f26af31 100644
> --- a/pc-bios/vof/Makefile
> +++ b/pc-bios/vof/Makefile
> @@ -19,4 +19,6 @@ vof.elf: entry.o main.o ci.o bootmem.o libc.o
> clean:
> 	rm -f *.o vof.bin vof.elf *~
>
> -.PHONY: all clean
> +distclean:
> +
> +.PHONY: all clean distclean

Shouldn't you also do something in this like at least depend on clean? By 
the way make distclean not in VOF but in QEMU build dir fails for me with:

Cleaning... 1 files.
rm -f config-host.mak qemu-bundle
rm: cannot remove 'qemu-bundle': Is a directory
make: *** [Makefile:219: distclean] Error 1

Regards,
BALATON Zoltan
Re: [PATCH v1 15/51] vof: add distclean target
Posted by Alex Bennée 3 years, 4 months ago 
BALATON Zoltan <balaton@eik.bme.hu> writes:

> On Thu, 29 Sep 2022, Alex Bennée wrote:
>> From: Paolo Bonzini <pbonzini@redhat.com>
>>
>> Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
>> Signed-off-by: Alex Bennée <alex.bennee@linaro.org>
>> ---
>> pc-bios/vof/Makefile | 4 +++-
>> 1 file changed, 3 insertions(+), 1 deletion(-)
>>
>> diff --git a/pc-bios/vof/Makefile b/pc-bios/vof/Makefile
>> index 8809c82768..990f26af31 100644
>> --- a/pc-bios/vof/Makefile
>> +++ b/pc-bios/vof/Makefile
>> @@ -19,4 +19,6 @@ vof.elf: entry.o main.o ci.o bootmem.o libc.o
>> clean:
>> 	rm -f *.o vof.bin vof.elf *~
>>
>> -.PHONY: all clean
>> +distclean:
>> +
>> +.PHONY: all clean distclean
>
> Shouldn't you also do something in this like at least depend on clean?

I can add that.

> By the way make distclean not in VOF but in QEMU build dir fails for
> me with:
>
> Cleaning... 1 files.
> rm -f config-host.mak qemu-bundle
> rm: cannot remove 'qemu-bundle': Is a directory
> make: *** [Makefile:219: distclean] Error 1

I get this with master so I suspect it has been broken awhile.

>
> Regards,
> BALATON Zoltan


-- 
Alex Bennée
Re: [PATCH v1 15/51] vof: add distclean target
Posted by Alex Bennée 3 years, 4 months ago 
BALATON Zoltan <balaton@eik.bme.hu> writes:

> On Thu, 29 Sep 2022, Alex Bennée wrote:
>> From: Paolo Bonzini <pbonzini@redhat.com>
>>
>> Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
>> Signed-off-by: Alex Bennée <alex.bennee@linaro.org>
>> ---
>> pc-bios/vof/Makefile | 4 +++-
>> 1 file changed, 3 insertions(+), 1 deletion(-)
>>
>> diff --git a/pc-bios/vof/Makefile b/pc-bios/vof/Makefile
>> index 8809c82768..990f26af31 100644
>> --- a/pc-bios/vof/Makefile
>> +++ b/pc-bios/vof/Makefile
>> @@ -19,4 +19,6 @@ vof.elf: entry.o main.o ci.o bootmem.o libc.o
>> clean:
>> 	rm -f *.o vof.bin vof.elf *~
>>
>> -.PHONY: all clean
>> +distclean:
>> +
>> +.PHONY: all clean distclean
>
> Shouldn't you also do something in this like at least depend on clean?
> By the way make distclean not in VOF but in QEMU build dir fails for
> me with:
>
> Cleaning... 1 files.
> rm -f config-host.mak qemu-bundle
> rm: cannot remove 'qemu-bundle': Is a directory
> make: *** [Makefile:219: distclean] Error 1

In fact it has been broken since:

cf60ccc330 (cutils: Introduce bundle mechanism)

>
> Regards,
> BALATON Zoltan


-- 
Alex Bennée

Patchew 2.1-devel-b67e4c2

© 2016 - 2026 Red Hat, Inc.